Files
moby/daemon/command/daemon_freebsd.go
Cory SniderandSebastiaan van Stijn 40f06bf418 Reapply: daemon/command: add support for sd_notify "reload" notifications
This reapplies the af18206 commit which was reverted by ddb636c.

commit f74b856e1a added an [ExecReload] to
the systemd unit, which allows users to signal the daemon to reload its
config through systemd (`systemctl reload docker.service`).

While reloading works, systemd expects the `ExecReload` command to be
synchronous, so that it knows when the reload completes, and can account
for this when managing dependent services.

> Note however that reloading a daemon by enqueuing a signal (...) is usually
> not a good choice, because this is an asynchronous operation and hence not
> suitable when ordering reloads of multiple services against each other.

Systemd 253 introduced a new Type (Type=notify-reload, see [systemd#25916]),
which allows setting a "ReloadSignal" instead, if the service supports
it by including a [MONOTONIC_USEC] value in its "RELOADING=1"
notifications.

This patch:

- adds reload notifications to the daemon to notify when the daemon got
  signaled to reload its configuration see [sd_notify(3)].
- appends a [MONOTONIC_USEC] value to the reload notification to support
  systemd 253's notify-reload protocol. This is backwards-compatible
  with older systemd releases as the systemd service manager ignores
  unknown assignments in notifications.
- adds a `notifyReady` callback to notify when the reload finished,
  which we currently send regardless if the reload was successful or
  failed (which could be due to an invalid config).

[ExecReload]: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#ExecReload=
[systemd#25916]: https://github.com/systemd/systemd/pull/25916
[MONOTONIC_USEC]: https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#MONOTONIC_USEC=…
[sd_notify(3)]: https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#RELOADING=1

Signed-off-by: Cory Snider <csnider@mirantis.com>
Co-authored-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2026-02-26 12:08:46 +01:00

25 lines
675 B
Go

package command
import "github.com/moby/moby/v2/daemon/config"
// preNotifyReady sends a message to the host when the API is active, but before the daemon is
func preNotifyReady() error {
return nil
}
// notifyReady sends a message to the host when the server is ready to be used
func notifyReady() {
}
// notifyReloading sends a message to the host when the server got signaled to
// reloading its configuration. It is a no-op on FreeBSD.
func notifyReloading() func() { return func() {} }
// notifyStopping sends a message to the host when the server is shutting down
func notifyStopping() {
}
func validateCPURealtimeOptions(_ *config.Config) error {
return nil
}