dilim/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-08-12 22:16:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
54,743 Commits 19 Branches 592 Tags
7a8d8733c0f04d4057ebd3b1809efbc6b404c7cf
Commit Graph

1881 Commits

Author SHA1 Message Date
Sebastiaan van Stijn
7a8d8733c0 Merge pull request #51330 from thaJeztah/fix_client_example 
client: fix example, and add runnable example
 2025-10-29 18:17:34 +01:00
Austin Vazquez
6cf02b5cba client: remove unused import 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-29 11:21:52 -05:00
Austin Vazquez
c5e318dbde Merge pull request #51328 from vvoland/client-containercopy-structs 
client/container_copy: Wrap options and result struct
 2025-10-29 10:44:59 -05:00
Sebastiaan van Stijn
b910408187 Merge pull request #51326 from vvoland/client-containerupdate-structs 
client/container_update: Wrap options and result
 2025-10-29 15:17:28 +01:00
Sebastiaan van Stijn
3c62b06de2 client: fix example, and add runnable example 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 15:16:58 +01:00
Paweł Gronowski
1cc2ab16ce client/container_copy: Wrap options and result struct 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-10-29 14:34:19 +01:00
Austin Vazquez
214cd508c0 Merge pull request #51327 from thaJeztah/unexport_NewVersionError 
client: un-export NewVersionError, rename to requiresVersion
 2025-10-29 08:08:41 -05:00
Austin Vazquez
a7a94c393d Merge pull request #51325 from thaJeztah/refactor_client_network_step1 
client: refactor NetworkConnect, NetworkDisconnect, NetworkRemove
 2025-10-29 08:06:32 -05:00
Sebastiaan van Stijn
e9631b507e Merge pull request #51323 from thaJeztah/container_wait_nits 
client: ContainerWait: touch-up GoDoc, and remove legacy code, and use singular for channels (ContainerWaitResult)
 2025-10-29 13:41:02 +01:00
Paweł Gronowski
38d703ff6f client/container_update: Wrap options and result 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-10-29 13:30:22 +01:00
Austin Vazquez
e9f28e2a41 client: refactor NetworkConnect, NetworkDisconnect, NetworkRemove 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 13:02:01 +01:00
Paweł Gronowski
c755b9635d Merge pull request #51322 from vvoland/client-fixup 
client: Rename ContainerUnPause* to ContainerUnpause*
 2025-10-29 12:56:32 +01:00
Paweł Gronowski
f708214dbf Merge pull request #51324 from thaJeztah/network_connect_disconnect 
api/types/network: define `ConnectRequest` and `DisconnectRequest`
 2025-10-29 12:56:15 +01:00
Sebastiaan van Stijn
2d6bf9332b client: un-export NewVersionError, rename to requiresVersion 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 12:44:41 +01:00
Sebastiaan van Stijn
29ad05b130 client: ContainerWaitResult: use singular for channels 
These channels should ever only return a single result, so rename
them to match that expectation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 12:37:46 +01:00
Sebastiaan van Stijn
51a0584088 client: ContainerWait: touch-up GoDoc, remove legacy code 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 12:37:42 +01:00
Sebastiaan van Stijn
7041c02abd Merge pull request #51320 from thaJeztah/refactor_client_system_step1 
client: refactor Events, Info, RegistryLogin
 2025-10-29 12:25:28 +01:00
Austin Vazquez
bae45f766d api/types/network: define ConnectRequest and DisconnectRequest 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-29 11:44:18 +01:00
Sebastiaan van Stijn
b5971b6ae3 Merge pull request #51315 from austinvazquez/refactor-client-container-rename 
client: refactor `ContainerRename` to wrap options/result structs
 2025-10-29 11:41:33 +01:00
Paweł Gronowski
fc97a2ff0d client: Rename ContainerUnPause* to ContainerUnpause* 
To better match the method name itself

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-10-29 11:32:32 +01:00
Sebastiaan van Stijn
d3eb04fe59 Merge pull request #51312 from austinvazquez/refactor-client-container-wait 
client: refactor ContainerWait to use client defined options/results structs
 2025-10-29 11:12:52 +01:00
Austin Vazquez
40bf2b05f3 Merge pull request #51317 from austinvazquez/refactor-client-container-logs 
client: refactor `ContainerLogs` to wrap result
 2025-10-29 05:06:22 -05:00
Austin Vazquez
d2e7465293 client: refactor ContainerRename to wrap options/result structs 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 10:14:26 +01:00
Sebastiaan van Stijn
a0f877d1b3 Merge pull request #51316 from austinvazquez/refactor-client-container-export 
client: refactor `ContainerExport` to wrap options/result structs
 2025-10-29 10:01:07 +01:00
Austin Vazquez
28ed1ef927 client: refactor ContainerLogs to wrap result 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-29 09:54:23 +01:00
Austin Vazquez
e46058cbae client: refactor Events, Info, RegistryLogin 
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-29 09:36:23 +01:00
Sebastiaan van Stijn
c438b3fbbf Merge pull request #51314 from austinvazquez/refactor-client-container-list 
client: refactor `ContainerList` to wrap result
 2025-10-29 08:31:22 +01:00
Austin Vazquez
749c980d4e client: refactor ContainerExport to wrap options/result structs 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-28 19:39:13 -05:00
Austin Vazquez
ec22a1e5b2 client: refactor ContainerTop to wrap options and results 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-28 18:54:43 -05:00
Austin Vazquez
c5ddef1122 client: refactor ContainerList to wrap result 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-28 18:52:52 -05:00
Austin Vazquez
cf173bc941 client: refactor ContainerWait to use client defined options/results structs 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
 2025-10-28 18:15:01 -05:00
Austin Vazquez
4ce86e2c9b Merge pull request #51310 from thaJeztah/volume_output_structs 
client: VolumeRemove, VolumeUpdate: add output struct
 2025-10-28 18:14:24 -05:00
Austin Vazquez
e95f6c8191 Merge pull request #51307 from thaJeztah/ping_once 
client: remove NegotiateAPIVersion, NegotiateAPIVersionPing
 2025-10-28 14:08:56 -05:00
Sebastiaan van Stijn
848b0452d3 client: VolumesPrune: rename argument for consistency 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-28 15:42:34 +01:00
Sebastiaan van Stijn
1985a8979e client: VolumeUpdate: add output struct, and move "version" 
- Add a VolumeUpdateResult output struct
- Move the swarm version argument to the options, to align
  with other swarm-related methods.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-28 15:42:33 +01:00
Sebastiaan van Stijn
faee204c02 client: VolumeRemove: add output struct 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-28 15:42:33 +01:00
Sebastiaan van Stijn
90109a373d Merge pull request #51308 from thaJeztah/client_container_types 
client: add option and output structs for various container methods
 2025-10-28 15:42:25 +01:00
Sebastiaan van Stijn
9e7e01ef16 Merge pull request #51153 from corhere/excise-json-streams-from-api 
api: move `pkg/streamformatter`, `pkg/progress` to `daemon/internal`
 2025-10-28 13:36:16 +01:00
Sebastiaan van Stijn
1f5c82b9fa client: add option and output structs for various container methods 
Add option- and output structs for;

- Client.ContainerKill
- Client.ContainerPause
- Client.ContainerRemove
- Client.ContainerResize
- Client.ContainerRestart
- Client.ContainerStart
- Client.ContainerStop
- Client.ContainerUnpause

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-27 23:46:28 +01:00
Sebastiaan van Stijn
edbf321ce6 client: remove NegotiateAPIVersion, NegotiateAPIVersionPing 
Remove these methods in favor of adding negotiation options to the
Ping method.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-27 19:27:48 +01:00
Sebastiaan van Stijn
c4aee2a50e client: remove ContainerStatsResult.OSType field 
The API now includes this information per record, and clients can
get this information using the `Ping` method if needed as fallback.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-27 17:20:16 +01:00
Sebastiaan van Stijn
6a2a1dd6cf api/types/container: StatsResponse: add OSType field 
Adds a per-stats OSType field to allow handle the platform-specific fields.
Before this change, the client had to get the OSType field from the server's
API response header and copy it to each record.

Older daemon versions don't have this field, so the client still needs to
handle fallbacks.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-27 16:39:32 +01:00
Sebastiaan van Stijn
8118385ba8 client: ContainerStats: add option, output-structs, remove ContainerStatsOneShot 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-27 14:03:55 +01:00
Sebastiaan van Stijn
370ca31ecf Merge pull request #51299 from thaJeztah/cleanup_stats_type 
api/types/container: StatsResponse: cleanup fields and GoDoc
 2025-10-27 12:08:58 +01:00
Sebastiaan van Stijn
3088c4e192 api/types/container: StatsResponse: cleanup fields and GoDoc 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-26 20:37:40 +01:00
Sebastiaan van Stijn
9b795c53a7 client: remove ImageLoadResult.JSON field 
The JSON field was added in [moby@9fd2c0f], to address [moby#19177], which
reported an incompatibility with Classic (V1) Swarm, which produced a non-
standard response;

> Make docker load to output json when the response content type is json
> Swarm hijacks the response from docker load and returns JSON rather
> than plain text like the Engine does. This makes the API library to return
> information to figure that out.

A later change in [moby@96d7db6] added additional logic to make sure the
correct content-type was returned, depending on whether the `quiet` option
was set (which produced a non-JSON response). This caused inconsistency in
the API response, and [moby@2f27632] changed the endpoint to always produce
JSON (only skipping the "progress" output if `quiet` was set).

This means that the "load" endpoint ([`imageRouter.postImagesLoad`]) now
unconditionally returns JSON, making the `JSON` field fully redundant.

We should consider deprecating the "quiet" option, as it's really the client's
responsibility to show or hide progress-bars, but we can do this separately.

This patch removes the JSON field, as it's redundant, and the way it handles
the content-type is incorrect because it would not handle correct, but different
formatted response-headers (`application/json; charset=utf-8`), which could
result in malformed output on the client.

[moby@9fd2c0f]: 9fd2c0feb0
[moby#19177]: https://github.com/moby/moby/issues/19177
[moby@96d7db6]: 96d7db665b
[moby@2f27632]: 2f27632cde
[`imageRouter.postImagesLoad`]: 7b9d2ef6e5/api/server/router/image/image_routes.go (L248-L255)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-26 19:46:49 +01:00
Sebastiaan van Stijn
ef589ef824 client: fix ImageLoadResult GoDoc 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-26 12:30:18 +01:00
Paweł Gronowski
4aac139fc0 client/container_exec: Separate structs for Start and Attach 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-10-25 12:23:14 +02:00
Sebastiaan van Stijn
425975313a client: merge ContainerInspectWithRaw with ContainerInspect 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-24 22:01:23 +02:00
Sebastiaan van Stijn
58356450fa client: remove redundant closing and draining of response 
For methods using the decodeWithRaw utility, we were handling closing
of the body twice. The ensureReaderClosed utility also drains the
response to let the transport reuse the connnection. Let's use that
utility in decodeWithRaw as well.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-10-24 19:30:22 +02:00