From e410daf8f7b3b958f5a2595cb8cf74aba48d0d58 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 27 Oct 2025 10:19:16 +0100 Subject: [PATCH] integration-cli: TestContainerAPIStatsWithNetworkDisabled: check result Signed-off-by: Sebastiaan van Stijn --- integration-cli/docker_api_containers_test.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/integration-cli/docker_api_containers_test.go b/integration-cli/docker_api_containers_test.go index abb60e91e1..f6806f8484 100644 --- a/integration-cli/docker_api_containers_test.go +++ b/integration-cli/docker_api_containers_test.go @@ -1134,7 +1134,7 @@ func (s *DockerAPISuite) TestContainerAPIStatsWithNetworkDisabled(c *testing.T) assert.NilError(c, err) defer apiClient.Close() - _, err = apiClient.ContainerCreate(testutil.GetContext(c), client.ContainerCreateOptions{ + ctr, err := apiClient.ContainerCreate(testutil.GetContext(c), client.ContainerCreateOptions{ Config: &config, HostConfig: &container.HostConfig{}, NetworkingConfig: &network.NetworkingConfig{}, @@ -1142,9 +1142,9 @@ func (s *DockerAPISuite) TestContainerAPIStatsWithNetworkDisabled(c *testing.T) }) assert.NilError(c, err) - err = apiClient.ContainerStart(testutil.GetContext(c), name, client.ContainerStartOptions{}) + err = apiClient.ContainerStart(testutil.GetContext(c), ctr.ID, client.ContainerStartOptions{}) assert.NilError(c, err) - cli.WaitRun(c, name) + cli.WaitRun(c, ctr.ID) type b struct { stats client.StatsResponseReader @@ -1153,7 +1153,7 @@ func (s *DockerAPISuite) TestContainerAPIStatsWithNetworkDisabled(c *testing.T) bc := make(chan b, 1) go func() { stats, err := apiClient.ContainerStats(testutil.GetContext(c), name, false) - bc <- b{stats, err} + bc <- b{stats: stats, err: err} }() // allow some time to stream the stats from the container @@ -1167,7 +1167,10 @@ func (s *DockerAPISuite) TestContainerAPIStatsWithNetworkDisabled(c *testing.T) c.Fatal("stream was not closed after container was removed") case sr := <-bc: assert.NilError(c, sr.err) - sr.stats.Body.Close() + var v container.StatsResponse + assert.NilError(c, json.NewDecoder(sr.stats.Body).Decode(&v)) + assert.Check(c, is.Equal(v.ID, ctr.ID)) + _ = sr.stats.Body.Close() } }