diff --git a/api/client/commands.go b/api/client/commands.go index b50fad6853..4cfe97cdd7 100644 --- a/api/client/commands.go +++ b/api/client/commands.go @@ -50,10 +50,6 @@ const ( tarHeaderSize = 512 ) -var ( - acceptedImageFilterTags = map[string]struct{}{"dangling": {}} -) - func (cli *DockerCli) CmdHelp(args ...string) error { if len(args) > 1 { method, exists := cli.getMethod(args[:2]...) @@ -1352,12 +1348,6 @@ func (cli *DockerCli) CmdImages(args ...string) error { } } - for name := range imageFilterArgs { - if _, ok := acceptedImageFilterTags[name]; !ok { - return fmt.Errorf("Invalid filter '%s'", name) - } - } - matchName := cmd.Arg(0) // FIXME: --viz and --tree are deprecated. Remove them in a future version. if *flViz || *flTree { diff --git a/graph/list.go b/graph/list.go index 63a906b9a9..49d4072be5 100644 --- a/graph/list.go +++ b/graph/list.go @@ -11,6 +11,8 @@ import ( "github.com/docker/docker/pkg/parsers/filters" ) +var acceptedImageFilterTags = map[string]struct{}{"dangling": {}} + func (s *TagStore) CmdImages(job *engine.Job) engine.Status { var ( allImages map[string]*image.Image @@ -22,6 +24,12 @@ func (s *TagStore) CmdImages(job *engine.Job) engine.Status { if err != nil { return job.Error(err) } + for name := range imageFilters { + if _, ok := acceptedImageFilterTags[name]; !ok { + return job.Errorf("Invalid filter '%s'", name) + } + } + if i, ok := imageFilters["dangling"]; ok { for _, value := range i { if strings.ToLower(value) == "true" {