From caae209d25757682c8ca39d864752e85dd97160f Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 12 Sep 2025 10:18:24 +0200 Subject: [PATCH] api/types/container: remove deprecated ExecOptions.Detach This field was deprecated in 0c182d4d57e30e77fd940201205db20403fc7282, which should be included in a 28.x release, but we don't need to carry it in the new module. We should also considering duplicating the `ExecOptions` type as a client option, and renaming it to `ExecCreateRequest`, so that we can decouple client options from the shape of the request. Signed-off-by: Sebastiaan van Stijn --- api/types/container/exec.go | 3 --- vendor/github.com/moby/moby/api/types/container/exec.go | 3 --- 2 files changed, 6 deletions(-) diff --git a/api/types/container/exec.go b/api/types/container/exec.go index d4ed9f8bd2..4dfb56084b 100644 --- a/api/types/container/exec.go +++ b/api/types/container/exec.go @@ -22,9 +22,6 @@ type ExecOptions struct { Env []string // Environment variables WorkingDir string // Working directory Cmd []string // Execution commands and args - - // Deprecated: the Detach field is not used, and will be removed in a future release. - Detach bool } // ExecStartOptions is a temp struct used by execStart diff --git a/vendor/github.com/moby/moby/api/types/container/exec.go b/vendor/github.com/moby/moby/api/types/container/exec.go index d4ed9f8bd2..4dfb56084b 100644 --- a/vendor/github.com/moby/moby/api/types/container/exec.go +++ b/vendor/github.com/moby/moby/api/types/container/exec.go @@ -22,9 +22,6 @@ type ExecOptions struct { Env []string // Environment variables WorkingDir string // Working directory Cmd []string // Execution commands and args - - // Deprecated: the Detach field is not used, and will be removed in a future release. - Detach bool } // ExecStartOptions is a temp struct used by execStart