dilim/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-06-24 08:48:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

dockerversion: touch-up escapeStr to mention RFC and add TODO

Browse Source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2026-05-14 15:36:40 +02:00
parent 91ae7ea8c8
commit 854307e013
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dockerversion/useragent.go
View File

@@ -88,13 +88,16 @@ func getUpstreamUserAgent(ctx context.Context) string {
return "UpstreamClient(" + escapeStr(upstreamUA) + ")" return "UpstreamClient(" + escapeStr(upstreamUA) + ")"
} }
// escapeStr escapes and sanitizes s for use in a User-Agent comment. // escapeStr escapes and sanitizes s for use in a User-Agent comment ([RFC9110]).
//
// [RFC9110]: https://www.rfc-editor.org/rfc/rfc9110#section-10.1.5
func escapeStr(s string) string { func escapeStr(s string) string {
var b strings.Builder var b strings.Builder
b.Grow(len(s)) b.Grow(len(s))
for i := range len(s) { for i := range len(s) {
switch c := s[i]; c { switch c := s[i]; c {
// TODO(thaJeztah): remove redundant escaping semicolons; see https://github.com/moby/moby/pull/52356#discussion_r3234266285
case '(', ')', ';', '\\': case '(', ')', ';', '\\':
b.WriteByte('\\') b.WriteByte('\\')
b.WriteByte(c) b.WriteByte(c)