diff --git a/pkg/authorization/authz.go b/pkg/authorization/authz.go index 4c2e90b251..d568a2b597 100644 --- a/pkg/authorization/authz.go +++ b/pkg/authorization/authz.go @@ -57,11 +57,11 @@ type Ctx struct { func isChunked(r *http.Request) bool { // RFC 7230 specifies that content length is to be ignored if Transfer-Encoding is chunked - if strings.ToLower(r.Header.Get("Transfer-Encoding")) == "chunked" { + if strings.EqualFold(r.Header.Get("Transfer-Encoding"), "chunked") { return true } for _, v := range r.TransferEncoding { - if 0 == strings.Compare(strings.ToLower(v), "chunked") { + if strings.EqualFold(v, "chunked") { return true } } @@ -163,7 +163,7 @@ func drainBody(body io.ReadCloser) ([]byte, io.ReadCloser, error) { func isAuthEndpoint(urlPath string) (bool, error) { // eg www.test.com/v1.24/auth/optional?optional1=something&optional2=something (version optional) - matched, err := regexp.MatchString(`^[^\/]+\/(v\d[\d\.]*\/)?auth.*`, urlPath) + matched, err := regexp.MatchString(`^[^\/]*\/(v\d[\d\.]*\/)?auth.*`, urlPath) if err != nil { return false, err } diff --git a/pkg/authorization/authz_unix_test.go b/pkg/authorization/authz_unix_test.go index 275f1dd3d0..66b4d20452 100644 --- a/pkg/authorization/authz_unix_test.go +++ b/pkg/authorization/authz_unix_test.go @@ -259,6 +259,41 @@ func TestSendBody(t *testing.T) { contentType: "application/json;charset=UTF8", expected: false, }, + { + url: "www.nothing.com/v1.24/auth/test", + contentType: "application/json;charset=UTF8", + expected: false, + }, + { + url: "https://www.nothing.com/v1.24/auth/test", + contentType: "application/json;charset=UTF8", + expected: false, + }, + { + url: "http://nothing.com/v1.24/auth/test", + contentType: "application/json;charset=UTF8", + expected: false, + }, + { + url: "www.nothing.com/test?p1=/auth", + contentType: "application/json;charset=UTF8", + expected: true, + }, + { + url: "http://www.nothing.com/test?p1=/auth", + contentType: "application/json;charset=UTF8", + expected: true, + }, + { + url: "www.nothing.com/something/auth", + contentType: "application/json;charset=UTF8", + expected: true, + }, + { + url: "https://www.nothing.com/something/auth", + contentType: "application/json;charset=UTF8", + expected: true, + }, } )