From 3a9f4e0146728e7706e4d1a584f6f439b069130d Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 28 Jan 2025 13:37:35 +0100 Subject: [PATCH] libnetwork/drivers/bridge: remove ErrInvalidMtu It's a generic errdefs.ErrInvalidParameter, and the type itself is not used as sentinel error anywhere. Signed-off-by: Sebastiaan van Stijn --- libnetwork/drivers/bridge/bridge_linux.go | 2 +- libnetwork/drivers/bridge/errors.go | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/libnetwork/drivers/bridge/bridge_linux.go b/libnetwork/drivers/bridge/bridge_linux.go index df4eaeca70..aa3a953be1 100644 --- a/libnetwork/drivers/bridge/bridge_linux.go +++ b/libnetwork/drivers/bridge/bridge_linux.go @@ -235,7 +235,7 @@ func ValidateFixedCIDRV6(val string) error { // Whatever can be assessed a priori before attempting any programming. func (c *networkConfiguration) Validate() error { if c.Mtu < 0 { - return ErrInvalidMtu(c.Mtu) + return errdefs.InvalidParameter(fmt.Errorf("invalid MTU number: %d", c.Mtu)) } if c.EnableIPv4 { diff --git a/libnetwork/drivers/bridge/errors.go b/libnetwork/drivers/bridge/errors.go index 54ee551143..ffef40ba28 100644 --- a/libnetwork/drivers/bridge/errors.go +++ b/libnetwork/drivers/bridge/errors.go @@ -16,16 +16,6 @@ func (eig *ErrInvalidGateway) Error() string { // InvalidParameter denotes the type of this error func (eig *ErrInvalidGateway) InvalidParameter() {} -// ErrInvalidMtu is returned when the user provided MTU is not valid. -type ErrInvalidMtu int - -func (eim ErrInvalidMtu) Error() string { - return fmt.Sprintf("invalid MTU number: %d", int(eim)) -} - -// InvalidParameter denotes the type of this error -func (eim ErrInvalidMtu) InvalidParameter() {} - // InvalidNetworkIDError is returned when the passed // network id for an existing network is not a known id. type InvalidNetworkIDError string