From 23c56099ee67eb133d67d4a228fb4364148d5079 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 10 Jun 2025 13:54:56 +0200 Subject: [PATCH] daemon/logger/loggerutils: use defer to fix gocritic "badlock" linter daemon/logger/loggerutils/logfile.go:374:2: badLock: defer is missing, mutex is unlocked immediately (gocritic) w.rotateMu.Unlock() ^ Signed-off-by: Sebastiaan van Stijn --- daemon/logger/loggerutils/logfile.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/logger/loggerutils/logfile.go b/daemon/logger/loggerutils/logfile.go index 7282601b1d..0ee196e186 100644 --- a/daemon/logger/loggerutils/logfile.go +++ b/daemon/logger/loggerutils/logfile.go @@ -371,7 +371,7 @@ func (w *LogFile) Close() error { close(w.closed) // Wait until any in-progress rotation is complete. w.rotateMu.Lock() - w.rotateMu.Unlock() //nolint:staticcheck,gocritic + defer w.rotateMu.Unlock() return nil }