From 0d36ab1875db00bcbeda0740b3a14cd3bf1ec889 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 15 Oct 2024 11:52:38 +0200 Subject: [PATCH] container: TestNames: don't string-match error assertions Signed-off-by: Sebastiaan van Stijn --- container/view_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/container/view_test.go b/container/view_test.go index b32a0b772c..644d79589c 100644 --- a/container/view_test.go +++ b/container/view_test.go @@ -114,7 +114,9 @@ func TestNames(t *testing.T) { assert.Check(t, db.ReserveName("name1", "containerid1")) assert.Check(t, db.ReserveName("name1", "containerid1")) // idempotent assert.Check(t, db.ReserveName("name2", "containerid2")) - assert.Check(t, is.Error(db.ReserveName("name2", "containerid3"), ErrNameReserved.Error())) + + err = db.ReserveName("name2", "containerid3") + assert.Check(t, is.ErrorIs(err, ErrNameReserved)) // Releasing a name allows the name to point to something else later. assert.Check(t, db.ReleaseName("name2")) @@ -131,7 +133,7 @@ func TestNames(t *testing.T) { assert.Check(t, is.Equal("containerid3", id)) _, err = view.GetID("notreserved") - assert.Check(t, is.Error(err, ErrNameNotReserved.Error())) + assert.Check(t, is.ErrorIs(err, ErrNameNotReserved)) // Releasing and re-reserving a name doesn't affect the snapshot. assert.Check(t, db.ReleaseName("name2"))