mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-11-06 13:28:22 +00:00
The setup and teardown functions intended for TestOSFileTypeChecker suggest that it was intended to use real files where possible, but it doesn't (or no longer does). This reworks the test function to use a temporary directory and real files for all appropriate tests (based on directories and files), and adds scenarios to cover the various code paths in the checkType(). The resulting coverage includes all the code covered by TestHostPathTypeCheckerInternal, so the latter can be dropped, which allows checkType() to be simplified and the whole hostPathTypeChecker interface and implementations to be dropped. Type checks all end up comparing strings returned by HostUtils, so the IsDir(), IsFile() etc. functions are also dropped in favour of direct type comparisons. Overall hostpath test coverage increases from 65.8% to 68.1%, on fewer lines of code. Signed-off-by: Stephen Kitt <skitt@redhat.com>
447 lines
14 KiB
Go
447 lines
14 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package hostpath
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"regexp"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
"github.com/opencontainers/selinux/go-selinux"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/apimachinery/pkg/util/uuid"
|
|
"k8s.io/kubernetes/pkg/kubelet/kubeletconfig"
|
|
"k8s.io/kubernetes/pkg/volume"
|
|
"k8s.io/kubernetes/pkg/volume/util"
|
|
"k8s.io/kubernetes/pkg/volume/util/hostutil"
|
|
"k8s.io/kubernetes/pkg/volume/util/recyclerclient"
|
|
"k8s.io/kubernetes/pkg/volume/validation"
|
|
"k8s.io/mount-utils"
|
|
)
|
|
|
|
// ProbeVolumePlugins is the primary entrypoint for volume plugins.
|
|
// The volumeConfig arg provides the ability to configure volume behavior. It is implemented as a pointer to allow nils.
|
|
// The hostPathPlugin is used to store the volumeConfig and give it, when needed, to the func that Recycles.
|
|
// Tests that exercise recycling should not use this func but instead use ProbeRecyclablePlugins() to override default behavior.
|
|
func ProbeVolumePlugins(volumeConfig volume.VolumeConfig) []volume.VolumePlugin {
|
|
return []volume.VolumePlugin{
|
|
&hostPathPlugin{
|
|
host: nil,
|
|
config: volumeConfig,
|
|
},
|
|
}
|
|
}
|
|
|
|
func FakeProbeVolumePlugins(volumeConfig volume.VolumeConfig) []volume.VolumePlugin {
|
|
return []volume.VolumePlugin{
|
|
&hostPathPlugin{
|
|
host: nil,
|
|
config: volumeConfig,
|
|
noTypeChecker: true,
|
|
},
|
|
}
|
|
}
|
|
|
|
type hostPathPlugin struct {
|
|
host volume.VolumeHost
|
|
config volume.VolumeConfig
|
|
noTypeChecker bool
|
|
}
|
|
|
|
var _ volume.VolumePlugin = &hostPathPlugin{}
|
|
var _ volume.PersistentVolumePlugin = &hostPathPlugin{}
|
|
var _ volume.RecyclableVolumePlugin = &hostPathPlugin{}
|
|
var _ volume.DeletableVolumePlugin = &hostPathPlugin{}
|
|
var _ volume.ProvisionableVolumePlugin = &hostPathPlugin{}
|
|
|
|
const (
|
|
hostPathPluginName = "kubernetes.io/host-path"
|
|
)
|
|
|
|
func (plugin *hostPathPlugin) Init(host volume.VolumeHost) error {
|
|
plugin.host = host
|
|
return nil
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) GetPluginName() string {
|
|
return hostPathPluginName
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) GetVolumeName(spec *volume.Spec) (string, error) {
|
|
volumeSource, _, err := getVolumeSource(spec)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return volumeSource.Path, nil
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) CanSupport(spec *volume.Spec) bool {
|
|
return (spec.PersistentVolume != nil && spec.PersistentVolume.Spec.HostPath != nil) ||
|
|
(spec.Volume != nil && spec.Volume.HostPath != nil)
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) RequiresRemount(spec *volume.Spec) bool {
|
|
return false
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) SupportsMountOption() bool {
|
|
return false
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) SupportsSELinuxContextMount(spec *volume.Spec) (bool, error) {
|
|
return false, nil
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) GetAccessModes() []v1.PersistentVolumeAccessMode {
|
|
return []v1.PersistentVolumeAccessMode{
|
|
v1.ReadWriteOnce,
|
|
}
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) NewMounter(spec *volume.Spec, pod *v1.Pod) (volume.Mounter, error) {
|
|
hostPathVolumeSource, readOnly, err := getVolumeSource(spec)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
path := hostPathVolumeSource.Path
|
|
pathType := new(v1.HostPathType)
|
|
if hostPathVolumeSource.Type == nil {
|
|
*pathType = v1.HostPathUnset
|
|
} else {
|
|
pathType = hostPathVolumeSource.Type
|
|
}
|
|
kvh, ok := plugin.host.(volume.KubeletVolumeHost)
|
|
if !ok {
|
|
return nil, fmt.Errorf("plugin volume host does not implement KubeletVolumeHost interface")
|
|
}
|
|
return &hostPathMounter{
|
|
hostPath: &hostPath{path: path, pathType: pathType},
|
|
readOnly: readOnly,
|
|
mounter: plugin.host.GetMounter(),
|
|
hu: kvh.GetHostUtil(),
|
|
noTypeChecker: plugin.noTypeChecker,
|
|
}, nil
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) NewUnmounter(volName string, podUID types.UID) (volume.Unmounter, error) {
|
|
return &hostPathUnmounter{&hostPath{
|
|
path: "",
|
|
}}, nil
|
|
}
|
|
|
|
// Recycle recycles/scrubs clean a HostPath volume.
|
|
// Recycle blocks until the pod has completed or any error occurs.
|
|
// HostPath recycling only works in single node clusters and is meant for testing purposes only.
|
|
func (plugin *hostPathPlugin) Recycle(pvName string, spec *volume.Spec, eventRecorder recyclerclient.RecycleEventRecorder) error {
|
|
if spec.PersistentVolume == nil || spec.PersistentVolume.Spec.HostPath == nil {
|
|
return fmt.Errorf("spec.PersistentVolume.Spec.HostPath is nil")
|
|
}
|
|
|
|
pod := plugin.config.RecyclerPodTemplate
|
|
timeout := util.CalculateTimeoutForVolume(plugin.config.RecyclerMinimumTimeout, plugin.config.RecyclerTimeoutIncrement, spec.PersistentVolume)
|
|
// overrides
|
|
pod.Spec.ActiveDeadlineSeconds = &timeout
|
|
pod.Spec.Volumes[0].VolumeSource = v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{
|
|
Path: spec.PersistentVolume.Spec.HostPath.Path,
|
|
},
|
|
}
|
|
return recyclerclient.RecycleVolumeByWatchingPodUntilCompletion(pvName, pod, plugin.host.GetKubeClient(), eventRecorder)
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) NewDeleter(logger klog.Logger, spec *volume.Spec) (volume.Deleter, error) {
|
|
return newDeleter(spec, plugin.host)
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) NewProvisioner(logger klog.Logger, options volume.VolumeOptions) (volume.Provisioner, error) {
|
|
if !plugin.config.ProvisioningEnabled {
|
|
return nil, fmt.Errorf("provisioning in volume plugin %q is disabled", plugin.GetPluginName())
|
|
}
|
|
return newProvisioner(options, plugin.host, plugin)
|
|
}
|
|
|
|
func (plugin *hostPathPlugin) ConstructVolumeSpec(volumeName, mountPath string) (volume.ReconstructedVolume, error) {
|
|
hostPathVolume := &v1.Volume{
|
|
Name: volumeName,
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{
|
|
Path: volumeName,
|
|
},
|
|
},
|
|
}
|
|
return volume.ReconstructedVolume{
|
|
Spec: volume.NewSpecFromVolume(hostPathVolume),
|
|
}, nil
|
|
}
|
|
|
|
func newDeleter(spec *volume.Spec, host volume.VolumeHost) (volume.Deleter, error) {
|
|
if spec.PersistentVolume != nil && spec.PersistentVolume.Spec.HostPath == nil {
|
|
return nil, fmt.Errorf("spec.PersistentVolumeSource.HostPath is nil")
|
|
}
|
|
path := spec.PersistentVolume.Spec.HostPath.Path
|
|
return &hostPathDeleter{name: spec.Name(), path: path, host: host}, nil
|
|
}
|
|
|
|
func newProvisioner(options volume.VolumeOptions, host volume.VolumeHost, plugin *hostPathPlugin) (volume.Provisioner, error) {
|
|
return &hostPathProvisioner{options: options, host: host, plugin: plugin, basePath: "hostpath_pv"}, nil
|
|
}
|
|
|
|
// HostPath volumes represent a bare host file or directory mount.
|
|
// The direct at the specified path will be directly exposed to the container.
|
|
type hostPath struct {
|
|
path string
|
|
pathType *v1.HostPathType
|
|
volume.MetricsNil
|
|
}
|
|
|
|
func (hp *hostPath) GetPath() string {
|
|
return hp.path
|
|
}
|
|
|
|
type hostPathMounter struct {
|
|
*hostPath
|
|
readOnly bool
|
|
mounter mount.Interface
|
|
hu hostutil.HostUtils
|
|
noTypeChecker bool
|
|
}
|
|
|
|
var _ volume.Mounter = &hostPathMounter{}
|
|
|
|
func (b *hostPathMounter) GetAttributes() volume.Attributes {
|
|
return volume.Attributes{
|
|
ReadOnly: b.readOnly,
|
|
Managed: false,
|
|
SELinuxRelabel: false,
|
|
}
|
|
}
|
|
|
|
// SetUp does nothing.
|
|
func (b *hostPathMounter) SetUp(mounterArgs volume.MounterArgs) error {
|
|
err := validation.ValidatePathNoBacksteps(b.GetPath())
|
|
if err != nil {
|
|
return fmt.Errorf("invalid HostPath `%s`: %v", b.GetPath(), err)
|
|
}
|
|
|
|
if *b.pathType == v1.HostPathUnset {
|
|
return nil
|
|
}
|
|
if b.noTypeChecker {
|
|
return nil
|
|
} else {
|
|
return checkType(b.GetPath(), b.pathType, b.hu)
|
|
}
|
|
}
|
|
|
|
// SetUpAt does not make sense for host paths - probably programmer error.
|
|
func (b *hostPathMounter) SetUpAt(dir string, mounterArgs volume.MounterArgs) error {
|
|
return fmt.Errorf("SetUpAt() does not make sense for host paths")
|
|
}
|
|
|
|
func (b *hostPathMounter) GetPath() string {
|
|
return b.path
|
|
}
|
|
|
|
type hostPathUnmounter struct {
|
|
*hostPath
|
|
}
|
|
|
|
var _ volume.Unmounter = &hostPathUnmounter{}
|
|
|
|
// TearDown does nothing.
|
|
func (c *hostPathUnmounter) TearDown() error {
|
|
return nil
|
|
}
|
|
|
|
// TearDownAt does not make sense for host paths - probably programmer error.
|
|
func (c *hostPathUnmounter) TearDownAt(dir string) error {
|
|
return fmt.Errorf("TearDownAt() does not make sense for host paths")
|
|
}
|
|
|
|
// hostPathProvisioner implements a Provisioner for the HostPath plugin
|
|
// This implementation is meant for testing only and only works in a single node cluster.
|
|
type hostPathProvisioner struct {
|
|
host volume.VolumeHost
|
|
options volume.VolumeOptions
|
|
plugin *hostPathPlugin
|
|
basePath string
|
|
}
|
|
|
|
// Create for hostPath simply creates a local /tmp/%/%s directory as a new PersistentVolume, default /tmp/hostpath_pv/%s.
|
|
// This Provisioner is meant for development and testing only and WILL NOT WORK in a multi-node cluster.
|
|
func (r *hostPathProvisioner) Provision(selectedNode *v1.Node, allowedTopologies []v1.TopologySelectorTerm) (*v1.PersistentVolume, error) {
|
|
if util.CheckPersistentVolumeClaimModeBlock(r.options.PVC) {
|
|
return nil, fmt.Errorf("%s does not support block volume provisioning", r.plugin.GetPluginName())
|
|
}
|
|
|
|
fullpath := fmt.Sprintf("/tmp/%s/%s", r.basePath, uuid.NewUUID())
|
|
|
|
capacity := r.options.PVC.Spec.Resources.Requests[v1.ResourceName(v1.ResourceStorage)]
|
|
pv := &v1.PersistentVolume{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: r.options.PVName,
|
|
Annotations: map[string]string{
|
|
util.VolumeDynamicallyCreatedByKey: "hostpath-dynamic-provisioner",
|
|
},
|
|
},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeReclaimPolicy: r.options.PersistentVolumeReclaimPolicy,
|
|
AccessModes: r.options.PVC.Spec.AccessModes,
|
|
Capacity: v1.ResourceList{
|
|
v1.ResourceName(v1.ResourceStorage): capacity,
|
|
},
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{
|
|
Path: fullpath,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if len(r.options.PVC.Spec.AccessModes) == 0 {
|
|
pv.Spec.AccessModes = r.plugin.GetAccessModes()
|
|
}
|
|
|
|
if err := os.MkdirAll(pv.Spec.HostPath.Path, 0750); err != nil {
|
|
return nil, err
|
|
}
|
|
if selinux.GetEnabled() {
|
|
err := selinux.SetFileLabel(pv.Spec.HostPath.Path, kubeletconfig.KubeletContainersSharedSELinuxLabel)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to set selinux label for %q: %v", pv.Spec.HostPath.Path, err)
|
|
}
|
|
}
|
|
|
|
return pv, nil
|
|
}
|
|
|
|
// hostPathDeleter deletes a hostPath PV from the cluster.
|
|
// This deleter only works on a single host cluster and is for testing purposes only.
|
|
type hostPathDeleter struct {
|
|
name string
|
|
path string
|
|
host volume.VolumeHost
|
|
volume.MetricsNil
|
|
}
|
|
|
|
func (r *hostPathDeleter) GetPath() string {
|
|
return r.path
|
|
}
|
|
|
|
// Delete for hostPath removes the local directory so long as it is beneath /tmp/*.
|
|
// THIS IS FOR TESTING AND LOCAL DEVELOPMENT ONLY! This message should scare you away from using
|
|
// this deleter for anything other than development and testing.
|
|
func (r *hostPathDeleter) Delete() error {
|
|
regexp := regexp.MustCompile("/tmp/.+")
|
|
if !regexp.MatchString(r.GetPath()) {
|
|
return fmt.Errorf("host_path deleter only supports /tmp/.+ but received provided %s", r.GetPath())
|
|
}
|
|
return os.RemoveAll(r.GetPath())
|
|
}
|
|
|
|
func getVolumeSource(spec *volume.Spec) (*v1.HostPathVolumeSource, bool, error) {
|
|
if spec.Volume != nil && spec.Volume.HostPath != nil {
|
|
return spec.Volume.HostPath, spec.ReadOnly, nil
|
|
} else if spec.PersistentVolume != nil &&
|
|
spec.PersistentVolume.Spec.HostPath != nil {
|
|
return spec.PersistentVolume.Spec.HostPath, spec.ReadOnly, nil
|
|
}
|
|
|
|
return nil, false, fmt.Errorf("spec does not reference an HostPath volume type")
|
|
}
|
|
|
|
func exists(path string, hu hostutil.HostUtils) bool {
|
|
exists, err := hu.PathExists(path)
|
|
return exists && err == nil
|
|
}
|
|
|
|
// checkType checks whether the given path is the exact pathType
|
|
func checkType(path string, pathType *v1.HostPathType, hu hostutil.HostUtils) error {
|
|
switch *pathType {
|
|
case v1.HostPathDirectoryOrCreate:
|
|
if !exists(path, hu) {
|
|
return makeDir(path)
|
|
}
|
|
fallthrough
|
|
case v1.HostPathDirectory:
|
|
return typeMatchedOrError(path, hu, new(v1.HostPathDirectory), "directory")
|
|
case v1.HostPathFileOrCreate:
|
|
if !exists(path, hu) {
|
|
return makeFile(path)
|
|
}
|
|
fallthrough
|
|
case v1.HostPathFile:
|
|
return typeMatchedOrError(path, hu, new(v1.HostPathFile), "file")
|
|
case v1.HostPathSocket:
|
|
return typeMatchedOrError(path, hu, new(v1.HostPathSocket), "socket file")
|
|
case v1.HostPathCharDev:
|
|
return typeMatchedOrError(path, hu, new(v1.HostPathCharDev), "character device")
|
|
case v1.HostPathBlockDev:
|
|
return typeMatchedOrError(path, hu, new(v1.HostPathBlockDev), "block device")
|
|
default:
|
|
return fmt.Errorf("%s is an invalid volume type", *pathType)
|
|
}
|
|
}
|
|
|
|
func typeMatchedOrError(path string, hu hostutil.HostUtils, expectedType *v1.HostPathType, expectedDescription string) error {
|
|
if !exists(path, hu) {
|
|
return fmt.Errorf("hostPath %s doesn't exist", path)
|
|
}
|
|
pathType, err := hu.GetFileType(path)
|
|
if err != nil {
|
|
return fmt.Errorf("hostPath type check failed, %s is not a %s, unable to determine its type: %w", path, expectedDescription, err)
|
|
}
|
|
if string(pathType) != string(*expectedType) {
|
|
return fmt.Errorf("hostPath type check failed: %s is not a %s, it's a %s", path, expectedDescription, pathType)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// makeDir creates a new directory.
|
|
// If pathname already exists as a directory, no error is returned.
|
|
// If pathname already exists as a file, an error is returned.
|
|
func makeDir(pathname string) error {
|
|
err := os.MkdirAll(pathname, os.FileMode(0755))
|
|
if err != nil {
|
|
if !os.IsExist(err) {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// makeFile creates an empty file.
|
|
// If pathname already exists, whether a file or directory, no error is returned.
|
|
func makeFile(pathname string) error {
|
|
f, err := os.OpenFile(pathname, os.O_CREATE, os.FileMode(0644))
|
|
if f != nil {
|
|
f.Close()
|
|
}
|
|
if err != nil {
|
|
if !os.IsExist(err) {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|