mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-11-06 05:17:08 +00:00
Patrick Ohly
7bec3d14e0
The updated logcheck now warns about passing a pointer as value where String could crash if nil. The new findings are false positives, but there have been real issues before and adding klog.SafePtr is cheap mitigation for false positives. The HandleError* wrappers around contextual logging are now annotated such that the new logcheck knows that they do contextual logging. This revealed some real issues (expecting printf-style formatting or missing keys, passing a *function* instead of the function result).