mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-06 13:26:40 +00:00
kshitijk4poor
310bcf444a
The stall/registry work pushed agent/memory_manager.py past 1,000 lines. The memory-provider tool-schema helpers (normalize_tool_schema, memory_provider_tools_enabled, memory_provider_tools_exposed, inject_memory_provider_tools) are a self-contained topic with no dependency on MemoryManager, so they move verbatim to a memory_manager_tools sibling and every in-tree caller imports from the new module. agent.memory_manager is a public plugin module (hermes_cli/plugin_validate_private_imports.py), so it re-exports the four names, as it already does for the helpers that moved to agent.memory_context.
107 lines
4.5 KiB
Python
107 lines
4.5 KiB
Python
"""Memory-provider tool-schema plumbing: the gate that decides whether external memory-provider
|
|
tools are exposed on an agent's tool surface, and the injection of their schemas."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from typing import Any, Optional
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def normalize_tool_schema(schema: Any) -> Optional[dict[str, Any]]:
|
|
"""Return a bare function-tool dict with a resolvable top-level ``name``, else None.
|
|
|
|
Providers should return ``{"name", "description", "parameters"}`` but some return the
|
|
wrapped OpenAI form; wrapping that twice yields a nameless ``function`` and strict
|
|
providers (DeepSeek) reject the ENTIRE request, so both shapes are normalized here.
|
|
"""
|
|
if not isinstance(schema, dict):
|
|
return None
|
|
if schema.get("type") == "function" and isinstance(schema.get("function"), dict):
|
|
schema = schema["function"]
|
|
name = schema.get("name", "")
|
|
return schema if name and isinstance(name, str) else None
|
|
|
|
|
|
def memory_provider_tools_enabled(enabled_toolsets: Optional[list[str]], disabled_toolsets: Optional[list[str]] = None,
|
|
*, memory_tool_present: bool = False) -> bool:
|
|
"""Return whether external memory-provider tools should be exposed."""
|
|
if disabled_toolsets and "memory" in disabled_toolsets:
|
|
return False
|
|
if memory_tool_present or enabled_toolsets is None:
|
|
return True
|
|
if not enabled_toolsets:
|
|
return False
|
|
if "memory" in enabled_toolsets:
|
|
return True
|
|
try:
|
|
from toolsets import resolve_toolset
|
|
|
|
return any("memory" in resolve_toolset(name) for name in enabled_toolsets)
|
|
except Exception:
|
|
logger.debug("Failed to resolve enabled toolsets for memory-provider tools", exc_info=True)
|
|
return False
|
|
|
|
|
|
def _tool_name(tool: Any) -> Any:
|
|
return tool.get("function", {}).get("name") if isinstance(tool, dict) else None
|
|
|
|
|
|
def memory_provider_tools_exposed(agent: Any) -> bool:
|
|
"""Whether external memory-provider tools are exposed on ``agent``.
|
|
|
|
Same gate as ``inject_memory_provider_tools`` so a provider's ``system_prompt_block()``
|
|
never advertises tools absent from the tool surface.
|
|
"""
|
|
tools = getattr(agent, "tools", None)
|
|
present = isinstance(tools, (list, tuple)) and any(_tool_name(t) == "memory" for t in tools)
|
|
enabled, disabled = getattr(agent, "enabled_toolsets", None), getattr(agent, "disabled_toolsets", None)
|
|
return memory_provider_tools_enabled(enabled, disabled, memory_tool_present=present)
|
|
|
|
|
|
def inject_memory_provider_tools(agent: Any) -> int:
|
|
"""Append external memory-provider tool schemas to an agent tool surface; return count added."""
|
|
memory_manager = getattr(agent, "_memory_manager", None)
|
|
tools = getattr(agent, "tools", None)
|
|
if not memory_manager or tools is None:
|
|
return 0
|
|
|
|
if not memory_provider_tools_exposed(agent):
|
|
# Say so once: a silent 0 leaves the provider looking "half on" with no clue which
|
|
# config key (platform_toolsets / disabled_toolsets) gated it.
|
|
# See #81014.
|
|
_providers = [p for p in getattr(memory_manager, "providers", None) or []
|
|
if getattr(p, "name", "") != "builtin"]
|
|
if _providers:
|
|
logger.info(
|
|
"Memory provider(s) %s configured but the 'memory' toolset is "
|
|
"gated off for this session (platform_toolsets / "
|
|
"agent.disabled_toolsets) — provider tools and system-prompt "
|
|
"block are both withheld.",
|
|
[getattr(p, "name", type(p).__name__) for p in _providers],
|
|
)
|
|
return 0
|
|
|
|
get_schemas = getattr(memory_manager, "get_all_tool_schemas", None)
|
|
if not callable(get_schemas):
|
|
return 0
|
|
|
|
if getattr(agent, "valid_tool_names", None) is None:
|
|
agent.valid_tool_names = set()
|
|
existing_tool_names = {_tool_name(tool) for tool in tools if isinstance(tool, dict)}
|
|
added = 0
|
|
for raw_schema in get_schemas():
|
|
schema = normalize_tool_schema(raw_schema)
|
|
if schema is None:
|
|
logger.warning(
|
|
"Memory provider returned a tool schema with no resolvable "
|
|
"name; skipping to avoid poisoning the request (%r)", raw_schema,
|
|
)
|
|
elif schema["name"] not in existing_tool_names:
|
|
tools.append({"type": "function", "function": schema})
|
|
agent.valid_tool_names.add(schema["name"])
|
|
existing_tool_names.add(schema["name"])
|
|
added += 1
|
|
return added
|