mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-06 05:17:15 +00:00
R4 review P2-6: moving the Copilot ACP provider out of core deleted the e2e and unit tests that guarded the public agent.acp_client.ACPClient base (permission never granted, fs reads confined to cwd + redacted, no agent process outliving the CLI, per-session process reaping, tool-call round trip, compaction, retry semantics, long-reasoning progress). Re-home them in core against a vendor-neutral fake ACP agent (tests/fakes/providers/fake_acp_agent.py) and a generic `fake-acp` external_process user plugin written into the temp HERMES_HOME, with the same assertions as the deleted tests. Known open gaps stay xfail behind their existing KnownSymptom gates (#65788, #120550, #101507, #121290). Red proof: breaking each invariant in agent/acp_client.py (auto-grant permission, drop cwd confinement, drop redaction, no-op terminate, reap a sibling's process, drop tool extraction, crash-as-timeout, ...) turns the matching tests red.