From 48ef546fb2a57124dfc296fd825b9fe3dcabc6e1 Mon Sep 17 00:00:00 2001 From: Maciej Lisiewski Date: Sat, 24 Oct 2026 01:25:36 +0200 Subject: [PATCH] chore(js): declare dependencies the workspaces only reached through hoisting Every workspace imported packages it never declared and found them only because npm hoists the whole tree to the root node_modules: desktop (app-builder-lib, @electron/osx-sign, @electron/asar, plist, @tailwindcss/node, remark-gfm, remark-parse), bootstrap-installer (@nanostores/react), shared (vitest), ui-tui (chalk, strip-ansi) and tests-js (@types/node, vite, esbuild). Each is pinned to the version npm already resolves for it, so the installed tree is unchanged apart from a tests-js copy of @types/node matching the other workspaces' 22.20.5. --- apps/bootstrap-installer/package.json | 1 + apps/desktop/package.json | 7 +++++++ apps/shared/package.json | 3 ++- package-lock.json | 26 +++++++++++++++++++++++++- tests-js/package.json | 3 +++ ui-tui/package.json | 2 ++ 6 files changed, 40 insertions(+), 2 deletions(-) diff --git a/apps/bootstrap-installer/package.json b/apps/bootstrap-installer/package.json index 10ce156614..eec80c08b2 100644 --- a/apps/bootstrap-installer/package.json +++ b/apps/bootstrap-installer/package.json @@ -19,6 +19,7 @@ "fix": "npm run lint:fix" }, "dependencies": { + "@nanostores/react": "1.1.0", "@nous-research/ui": "0.19.1", "@tailwindcss/typography": "0.5.20", "@tailwindcss/vite": "4.3.3", diff --git a/apps/desktop/package.json b/apps/desktop/package.json index ecdbf0a532..28d2eef1b2 100644 --- a/apps/desktop/package.json +++ b/apps/desktop/package.json @@ -169,9 +169,12 @@ }, "devDependencies": { "@babel/core": "8.0.7", + "@electron/asar": "4.1.1", + "@electron/osx-sign": "2.4.0", "@electron/rebuild": "4.2.1", "@playwright/test": "1.64.0", "@rolldown/plugin-babel": "0.2.4", + "@tailwindcss/node": "4.3.3", "@testing-library/dom": "10.4.2", "@testing-library/react": "16.3.3", "@types/babel__core": "7.20.5", @@ -184,6 +187,7 @@ "@types/react": "19.3.0", "@types/react-dom": "19.3.0", "@vitejs/plugin-react": "6.0.3", + "app-builder-lib": "27.0.0-alpha.6", "babel-plugin-react-compiler": "1.0.0", "bippy": "0.7.3", "concurrently": "10.0.6", @@ -192,8 +196,11 @@ "electron-builder": "27.0.0-alpha.6", "esbuild": "0.28.2", "jsdom": "29.1.1", + "plist": "3.1.0", "prettier": "3.9.9", "rcedit": "5.0.2", + "remark-gfm": "4.0.1", + "remark-parse": "11.0.0", "tsx": "4.23.15", "typescript": "6.0.3", "vite": "8.3.4", diff --git a/apps/shared/package.json b/apps/shared/package.json index ca592ec60a..8df0d2eb5b 100644 --- a/apps/shared/package.json +++ b/apps/shared/package.json @@ -33,6 +33,7 @@ "check": "npm run typecheck && npm run lint" }, "devDependencies": { - "typescript": "6.0.3" + "typescript": "6.0.3", + "vitest": "4.1.12" } } diff --git a/package-lock.json b/package-lock.json index 31db2ec070..6d9c18f091 100644 --- a/package-lock.json +++ b/package-lock.json @@ -40,6 +40,7 @@ "name": "@hermes/bootstrap-installer", "version": "0.0.0", "dependencies": { + "@nanostores/react": "1.1.0", "@nous-research/ui": "0.19.1", "@tailwindcss/typography": "0.5.20", "@tailwindcss/vite": "4.3.3", @@ -159,9 +160,12 @@ }, "devDependencies": { "@babel/core": "8.0.7", + "@electron/asar": "4.1.1", + "@electron/osx-sign": "2.4.0", "@electron/rebuild": "4.2.1", "@playwright/test": "1.64.0", "@rolldown/plugin-babel": "0.2.4", + "@tailwindcss/node": "4.3.3", "@testing-library/dom": "10.4.2", "@testing-library/react": "16.3.3", "@types/babel__core": "7.20.5", @@ -174,6 +178,7 @@ "@types/react": "19.3.0", "@types/react-dom": "19.3.0", "@vitejs/plugin-react": "6.0.3", + "app-builder-lib": "27.0.0-alpha.6", "babel-plugin-react-compiler": "1.0.0", "bippy": "0.7.3", "concurrently": "10.0.6", @@ -182,8 +187,11 @@ "electron-builder": "27.0.0-alpha.6", "esbuild": "0.28.2", "jsdom": "29.1.1", + "plist": "3.1.0", "prettier": "3.9.9", "rcedit": "5.0.2", + "remark-gfm": "4.0.1", + "remark-parse": "11.0.0", "tsx": "4.23.15", "typescript": "6.0.3", "vite": "8.3.4", @@ -493,7 +501,8 @@ "name": "@hermes/shared", "version": "0.0.0", "devDependencies": { - "typescript": "6.0.3" + "typescript": "6.0.3", + "vitest": "4.1.12" } }, "node_modules/@alcalzone/ansi-tokenize": { @@ -18446,15 +18455,28 @@ }, "devDependencies": { "@types/js-yaml": "4.0.9", + "@types/node": "22.20.5", "@types/plist": "3.0.5", + "esbuild": "0.28.2", "get-windows": "9.3.0", "jsdom": "29.1.1", "node-pty": "1.1.0", "plist": "3.1.1", "typescript": "6.0.3", + "vite": "8.3.4", "vitest": "4.1.12" } }, + "tests-js/node_modules/@types/node": { + "version": "22.20.5", + "resolved": "https://registry.npmjs.org/@types/node/-/node-22.20.5.tgz", + "integrity": "sha512-U2+DNr+wSjpsTS/wZGYHq7GcwfuSmKiKvoPvK22zwTlRhU91yOniN4qRR5KhIjvif7ysw/dz/hKmfDH0Ris4aA==", + "dev": true, + "license": "MIT", + "dependencies": { + "undici-types": "~6.21.0" + } + }, "tests-js/node_modules/@xmldom/xmldom": { "version": "0.9.12", "resolved": "https://registry.npmjs.org/@xmldom/xmldom/-/xmldom-0.9.12.tgz", @@ -18496,8 +18518,10 @@ "devDependencies": { "@types/node": "22.20.5", "@types/react": "19.3.0", + "chalk": "5.6.2", "esbuild": "0.28.2", "prettier": "3.9.9", + "strip-ansi": "7.2.0", "tsx": "4.23.15", "typescript": "6.0.3", "vitest": "4.1.12" diff --git a/tests-js/package.json b/tests-js/package.json index 12489f98cb..7cea9d6cb4 100644 --- a/tests-js/package.json +++ b/tests-js/package.json @@ -12,12 +12,15 @@ }, "devDependencies": { "@types/js-yaml": "4.0.9", + "@types/node": "22.20.5", "@types/plist": "3.0.5", + "esbuild": "0.28.2", "get-windows": "9.3.0", "jsdom": "29.1.1", "node-pty": "1.1.0", "plist": "3.1.1", "typescript": "6.0.3", + "vite": "8.3.4", "vitest": "4.1.12" }, "dependencies": { diff --git a/ui-tui/package.json b/ui-tui/package.json index 7e9bcbe5c7..d78ea99c36 100644 --- a/ui-tui/package.json +++ b/ui-tui/package.json @@ -38,8 +38,10 @@ "devDependencies": { "@types/node": "22.20.5", "@types/react": "19.3.0", + "chalk": "5.6.2", "esbuild": "0.28.2", "prettier": "3.9.9", + "strip-ansi": "7.2.0", "tsx": "4.23.15", "typescript": "6.0.3", "vitest": "4.1.12"