Gates Wang f76a5f46a9 fix: pass registry client to downloader.Manager in upgrade ...

`helm upgrade --dependency-update` built its downloader.Manager without a
RegistryClient, unlike the identical literals in install, dependency update,
and dependency build. Resolving an OCI chart dependency whose version is a
range then dereferenced a nil *registry.Client in registry.(*Client).Tags,
panicking the process. Pass the registry client already constructed for the
command, matching install.

Add a regression test that runs `upgrade --dependency-update` against a chart
with an unresolved OCI dependency and asserts the command returns an error
instead of panicking.

Signed-off-by: Gates Wang <9372086+SetagGnaw@users.noreply.github.com>
(cherry picked from commit 0604d8fb1e)

2026-08-12 21:46:59 -04:00

..

require

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

search

Use modernize to use newer Golang features.

2025-11-22 18:52:40 +01:00

testdata

chore: Improve error reporting for helm template --debug with --show-only

2026-08-12 20:56:32 -04:00

completion_test.go

Moved release objects to enable versioning

2025-10-10 11:49:08 -04:00

completion.go

chore: fix unnecessary-format issues from revive

2026-03-23 07:07:27 +01:00

create_test.go

Merge pull request #31875 from mmorel-35/perfsprint-pkg-2-0e1acbc

2026-03-02 07:26:50 -08:00

create.go

feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) (#31592)

2026-02-06 18:29:59 +00:00

dependency_build_test.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

dependency_build.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

dependency_test.go

squash

2025-02-24 15:11:54 +00:00

dependency_update_test.go

Replace unneeded use of t.Fatalf with t.Fatal

2026-02-26 18:18:57 +01:00

dependency_update.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

dependency.go

for all other similar cases

2025-11-04 11:33:42 +08:00

docs_test.go

squash

2025-02-24 15:11:54 +00:00

docs.go

Merge branch 'main' into stdlib-errors-2

2025-04-21 12:13:10 -04:00

env_test.go

squash

2025-02-24 15:11:54 +00:00

env.go

squash

2025-02-24 15:11:54 +00:00

flags_test.go

Moved release objects to enable versioning

2025-10-10 11:49:08 -04:00

flags.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

get_all_test.go

merge

2025-02-27 13:55:49 +00:00

get_all.go

chore: fixes

2026-02-23 16:46:35 -08:00

get_hooks_test.go

merge

2025-02-27 13:55:49 +00:00

get_hooks.go

Move all the get commands to the new release interface

2025-10-10 11:49:08 -04:00

get_manifest_test.go

merge

2025-02-27 13:55:49 +00:00

get_manifest.go

Move all the get commands to the new release interface

2025-10-10 11:49:08 -04:00

get_metadata_test.go

Add release labels to the release Metadata

2025-07-09 11:30:22 +04:00

get_metadata.go

Helm client/SDK support server-side apply

2025-08-18 10:05:07 -07:00

get_notes_test.go

merge

2025-02-27 13:55:49 +00:00

get_notes.go

Move all the get commands to the new release interface

2025-10-10 11:49:08 -04:00

get_test.go

squash

2025-02-24 15:11:54 +00:00

get_values_test.go

merge

2025-02-27 13:55:49 +00:00

get_values.go

chore: fixes

2026-02-23 16:46:35 -08:00

get.go

squash

2025-02-24 15:11:54 +00:00

helpers_test.go

refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations

2025-09-21 08:03:02 -07:00

helpers.go

refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations

2025-09-21 08:03:02 -07:00

history_test.go

chore: fixes

2026-02-23 16:46:35 -08:00

history.go

chore(pkg): fix perfsprint linter issues part 6

2026-02-26 19:06:38 +01:00

install_test.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

install.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

lint_test.go

Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1

2026-04-25 17:06:10 +01:00

lint.go

Remove implicit support for helm lint current directory

2025-09-15 14:15:01 -06:00

list_test.go

fix: increase helm list test coverage

2025-10-13 16:16:50 -06:00

list.go

chore(pkg): fix perfsprint linter issues part 6

2026-02-26 19:06:38 +01:00

load_plugins.go

fix(pkg): errorlint linter

2026-02-09 07:54:59 +01:00

package_test.go

Call ensure.HelmHome() in package_test.go

2025-07-02 16:20:45 -07:00

package.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

plugin_install.go

fix: Plugin missing provenance bypass

2026-04-08 21:31:08 -07:00

plugin_list.go

Cleanup plugin config

2025-09-02 09:53:22 -07:00

plugin_package_test.go

Remove legacy Command/Hooks from v1 Subprocess (#23)

2025-08-31 22:24:31 -07:00

plugin_package.go

chore: fix unnecessary-format issues from revive

2026-03-23 07:07:27 +01:00

plugin_test.go

Merge commit from fork

2026-04-08 21:22:47 -07:00

plugin_uninstall_test.go

Plugin OCI installer

2025-08-25 23:04:01 -04:00

plugin_uninstall.go

ignore error plugin loads (cli, getter)

2026-03-12 17:56:01 -07:00

plugin_update.go

ignore error plugin loads (cli, getter)

2026-03-12 17:56:01 -07:00

plugin_verify_test.go

[HIP-0026] Plugin packaging, signing, and verification (#31176)

2025-08-30 13:25:28 -04:00

plugin_verify.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:56 +01:00

plugin.go

Remove SetupPluginEnv

2025-09-01 10:49:01 -07:00

printer.go

chore: fixes

2026-02-23 16:46:35 -08:00

profiling.go

squash

2025-02-24 15:11:54 +00:00

pull_test.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

pull.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

push_test.go

squash

2025-02-24 15:11:54 +00:00

push.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

registry_login_test.go

squash

2025-02-24 15:11:54 +00:00

registry_login.go

Merge pull request #30904 from benoittgt/document-ideal-registry-login-command

2025-05-23 08:06:12 -04:00

registry_logout_test.go

squash

2025-02-24 15:11:54 +00:00

registry_logout.go

squash

2025-02-24 15:11:54 +00:00

registry.go

squash

2025-02-24 15:11:54 +00:00

release_testing_test.go

Moved release objects to enable versioning

2025-10-10 11:49:08 -04:00

release_testing.go

Fix linting issue

2025-11-26 17:24:33 +01:00

repo_add_test.go

chore: fix unnecessary-format issues from revive

2026-03-23 07:07:27 +01:00

repo_add.go

for all other similar cases

2025-11-04 11:33:42 +08:00

repo_index_test.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

repo_index.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

repo_list_test.go

feat(repo): add --no-headers option to 'helm repo list'

2025-10-30 18:00:08 +01:00

repo_list.go

fix: add default casess to switch statements

2025-12-21 09:13:24 -07:00

repo_remove_test.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

repo_remove.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

repo_test.go

squash

2025-02-24 15:11:54 +00:00

repo_update_test.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

repo_update.go

Move repo package to versioned directory

2025-09-02 10:19:48 -04:00

repo.go

Merge branch 'main' into stdlib-errors-2

2025-04-21 12:13:10 -04:00

rollback_test.go

Moved release objects to enable versioning

2025-10-10 11:49:08 -04:00

rollback.go

chore: fix unnecessary-format issues from revive

2026-03-23 07:07:27 +01:00

root_test.go

Fix kube client logging

2025-11-21 17:45:22 -05:00

root.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

search_hub_test.go

chore: fix unnecessary-format issues from revive

2026-03-23 07:07:27 +01:00

search_hub.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

search_repo_test.go

squash

2025-02-24 15:11:54 +00:00

search_repo.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

search_test.go

squash

2025-02-24 15:11:54 +00:00

search.go

squash

2025-02-24 15:11:54 +00:00

show_test.go

chore(pkg): enable perfsprint linter

2026-02-26 18:55:55 +01:00

show.go

fix: route registry client output to stdout instead of stderr (#32056)

2026-06-11 22:59:03 -04:00

status_test.go

Moved release objects to enable versioning

2025-10-10 11:49:08 -04:00

status.go

Update pkg/cmd/status.go

2026-02-28 11:11:02 +01:00

template_test.go

chore: Improve error reporting for helm template --debug with --show-only

2026-08-12 20:56:32 -04:00

template.go

chore: rename savedErr to clear its specific purpose

2026-08-12 20:56:48 -04:00

uninstall_test.go

fix(uninstall): supersede deployed releases

2025-11-07 23:09:48 +01:00

uninstall.go

docs: document uninstall using cascade foreground flag

2026-01-19 16:42:04 +00:00

upgrade_test.go

fix: pass registry client to downloader.Manager in upgrade

2026-08-12 21:46:59 -04:00

upgrade.go

fix: pass registry client to downloader.Manager in upgrade

2026-08-12 21:46:59 -04:00

verify_test.go

squash

2025-02-24 15:11:54 +00:00

verify.go

fix: helm verify run signature

2025-09-17 11:14:34 -06:00

version_test.go

chore: remove helm version client option

2025-09-16 20:00:24 -06:00

version.go

chore: remove helm version client option

2025-09-16 20:00:24 -06:00