helm/pkg/lint/rules at 8ca401398d8b6dfd41b46f446abcd5285e219829 - helm

dilim/helm

0 Fork 0

mirror of https://github.com/helm/helm.git synced 2026-11-07 05:48:12 +00:00

Files

T

Matt Farina 7838fb769d Fix specifying of Kubernetes version from build scripts

This bug came about because of three issues that this change
corrects:
- The CI scripts run on a pull request did not test building
  Helm. This means that a failure to set a variable using LDFLAGS
  had no opportunity to be caught.
- #8608 provided a means to match the k8s version used in linting
  and chartutil with the version of the package we pull in. With
  one problem. It attempts to set a const as if it were a string.
  This is ignored and everyone missed it.
- #10325 moved those constants to vars so it could be set. This
  looked good and passed tests but missed that you can't set an
  int as if it were a string. See first bullet.

This change fixes this by moved the internal representation to
be a string. These are internal variables not exposed in the public
API which makes this change non-breaking to the API.

Closes #10367

Signed-off-by: Matt Farina <matt.farina@suse.com>

2021-11-18 11:48:02 -05:00

testdata

fix(helm): process dependencies import-values

2021-10-24 11:38:02 +01:00

chartfile_test.go

Show errors when linting for Chart.yaml version and appVersion fields of type non-string

2020-05-25 13:24:15 +05:30

chartfile.go

Show errors when linting for Chart.yaml version and appVersion fields of type non-string

2020-05-25 13:24:15 +05:30

dependencies_test.go

Lint dependencies (#7970 )