mirror of
https://github.com/helm/helm.git
synced 2026-06-24 08:48:06 +00:00
c2f1b238a1
Commands like 'helm registry login', 'helm push', and 'helm pull' were
writing success messages ("Login Succeeded", "Pushed:", "Pulled:",
"Digest:") to stderr instead of stdout. The root cause was that
newDefaultRegistryClient and newRegistryClientWithTLS hard-coded
os.Stderr as the registry client writer, ignoring the out io.Writer
that main() passes as os.Stdout.
Thread out io.Writer through newRegistryClient, newDefaultRegistryClient,
and newRegistryClientWithTLS, and update all call sites in pkg/cmd.
Fixes #13464
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
107 lines
3.6 KiB
Go
107 lines
3.6 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"log"
|
|
"log/slog"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"helm.sh/helm/v4/pkg/action"
|
|
"helm.sh/helm/v4/pkg/cmd/require"
|
|
)
|
|
|
|
const pullDesc = `
|
|
Retrieve a package from a package repository, and download it locally.
|
|
|
|
This is useful for fetching packages to inspect, modify, or repackage. It can
|
|
also be used to perform cryptographic verification of a chart without installing
|
|
the chart.
|
|
|
|
There are options for unpacking the chart after download. This will create a
|
|
directory for the chart and uncompress into that directory.
|
|
|
|
If the --verify flag is specified, the requested chart MUST have a provenance
|
|
file, and MUST pass the verification process. Failure in any part of this will
|
|
result in an error, and the chart will not be saved locally.
|
|
`
|
|
|
|
func newPullCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
|
|
client := action.NewPull(action.WithConfig(cfg))
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "pull [chart URL | repo/chartname] [...]",
|
|
Short: "download a chart from a repository and (optionally) unpack it in local directory",
|
|
Aliases: []string{"fetch"},
|
|
Long: pullDesc,
|
|
Args: require.MinimumNArgs(1),
|
|
ValidArgsFunction: func(_ *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
|
|
if len(args) != 0 {
|
|
return nil, cobra.ShellCompDirectiveNoFileComp
|
|
}
|
|
return compListCharts(toComplete, false)
|
|
},
|
|
RunE: func(_ *cobra.Command, args []string) error {
|
|
client.Settings = settings
|
|
if client.Version == "" && client.Devel {
|
|
slog.Debug("setting version to >0.0.0-0")
|
|
client.Version = ">0.0.0-0"
|
|
}
|
|
|
|
registryClient, err := newRegistryClient(out, client.CertFile, client.KeyFile, client.CaFile,
|
|
client.InsecureSkipTLSVerify, client.PlainHTTP, client.Username, client.Password)
|
|
if err != nil {
|
|
return fmt.Errorf("missing registry client: %w", err)
|
|
}
|
|
client.SetRegistryClient(registryClient)
|
|
|
|
for i := range args {
|
|
output, err := client.Run(args[i])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Fprint(out, output)
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
|
|
f := cmd.Flags()
|
|
f.BoolVar(&client.Devel, "devel", false, "use development versions, too. Equivalent to version '>0.0.0-0'. If --version is set, this is ignored.")
|
|
f.BoolVar(&client.Untar, "untar", false, "if set to true, will untar the chart after downloading it")
|
|
f.BoolVar(&client.VerifyLater, "prov", false, "fetch the provenance file, but don't perform verification")
|
|
f.StringVar(&client.UntarDir, "untardir", ".", "if untar is specified, this flag specifies the name of the directory into which the chart is expanded")
|
|
f.StringVarP(&client.DestDir, "destination", "d", ".", "location to write the chart. If this and untardir are specified, untardir is appended to this")
|
|
addChartPathOptionsFlags(f, &client.ChartPathOptions)
|
|
|
|
err := cmd.RegisterFlagCompletionFunc("version", func(_ *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
|
|
if len(args) != 1 {
|
|
return nil, cobra.ShellCompDirectiveNoFileComp
|
|
}
|
|
return compVersionFlag(args[0], toComplete)
|
|
})
|
|
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
|
|
return cmd
|
|
}
|