72 Commits
Author SHA1 Message Date
George Jenkins 087736b66e fix: unnecessary-format lint issues from merge
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-04-08 22:00:58 -07:00
George Jenkins 586eb57338 fix: Plugin missing provenance bypass
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-04-08 21:31:08 -07:00
George Jenkins f8afb35f4e Merge commit from fork
fix: Plugin version path traversal
2026-04-08 21:22:47 -07:00
Matthieu MOREL 7edfff33eb chore: fix unnecessary-format issues from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-23 07:07:27 +01:00
George Jenkins 47a084091e ignore error plugin loads (cli, getter)
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-03-12 17:56:01 -07:00
George Jenkins 36dcc27ca3 fix: Plugin version path traversal
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-03-11 17:43:13 -07:00
tsinglua 259f181808 chore: fix some minor issues in the comments
Signed-off-by: tsinglua <tsinglua@outlook.com>
2026-03-11 16:55:34 +08:00
George Jenkins c4392033cc Merge pull request #31853 from atombrella/feature/fmt_unneeded
Replace non-format use of t.Fatalf with t.Fatal
2026-03-01 21:24:21 -08:00
Matthieu MOREL d4f6193a7e chore(internal): enable perfsprint linter (#31871)
#### Description

enable perfsprint linter in internal/plugin

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-27 12:41:41 +00:00
Matthieu MOREL 9409226e15 chore(internal): enable perfsprint linter
#### Description

enable perfsprint linter in internal/plugin/installer

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Mads Jensen 36cb3a2fe9 Replace unneeded use of t.Fatalf with t.Fatal
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2026-02-26 18:18:57 +01:00
Matthieu MOREL 5b6c6bbfc7 fix: enable nolinlint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-25 07:50:29 +01:00
George Jenkins bc43812115 Merge pull request #31807 from mmorel-35/errorlint-internal-3-48c7a5a
fix(internal): errorlint linter
2026-02-24 16:01:26 -08:00
Matthieu MOREL 025418291a fix(internal): errorlint linter
errorlint linter in internal/third_party/dep/fs

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:51:29 +01:00
Matthieu MOREL abecafa0f5 fix(internal): errorlint linter
#### Description

errorlint linter in internal

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-09 07:45:31 +01:00
Terry Howe 429ce93848 Merge pull request #31613 from aslafy-z/feat/getter-env
fix(getter): pass settings environment variables
2026-01-07 07:41:31 -07:00
Gergely Brautigam 138f730aac fix: typo in the function names
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
2025-12-31 07:46:52 +01:00
Mads Jensen a490bb3c20 Use errors.Is to check for io.EOF and gzip.ErrHeader
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-14 08:54:11 +01:00
Terry Howe b52b6615f0 Merge pull request #31207 from zyfy29/delete-unused-var
chore: delete unused var in installer.go
2025-12-13 08:27:37 -07:00
Terry Howe d28853e206 Merge pull request #31624 from atombrella/feature/sloglint
Enable the `sloglint` linter
2025-12-12 08:04:45 -07:00
Terry Howe 642462e9fe Merge pull request #11991 from twz123/no-bash-in-testscripts
Make test scripts run without /bin/bash
2025-12-12 07:57:37 -07:00
Mads Jensen a18e59e465 Enable the sloglint linter
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-12-09 08:24:36 +01:00
Zadkiel AHARONIAN 119341dca7 fix(getter): pass settings environment variables
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
2025-12-07 17:08:29 +01:00
Scott Rigby 4d54bea5ff Merge pull request #31491 from benoittgt/31490-plugin-name-helper
feat: improve plugin name validation error messages and field name detection (v1)
2025-11-25 11:49:58 -05:00
Benoit Tigeot 71591ee63e style: linting
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 12:21:45 +01:00
Benoit Tigeot b296cbef6c test: split tests between valid and invalid
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:49:08 +01:00
Benoit Tigeot 9b242dd9ed test: convert tests to table drive tests
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:44:49 +01:00
Benoit Tigeot c81a09b89a test: refactor TestMetadataLegacyValidate to be more generic
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:37:18 +01:00
yxxhero 8c87024860 update tests
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-11-16 10:05:27 +08:00
yxxhero 2d49f0cb4a Refactor environment variable expansion in PrepareCommands and update tests
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-11-15 11:16:08 +08:00
Benoit Tigeot acf331a005 fix: improve plugin name validation err messages early via unmarshalling
- Add strict YAML unmarshalling for v1 plugins (d.KnownFields)
- Add comprehensive test coverage for validPluginName regex
- Maintain backwards compatibility for legacy plugins

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:21:37 +01:00
Benoit Tigeot 9e1e3d21c5 fix: Make invalid name error message more similar and move tests
Follow Scott comment\
https://github.com/helm/helm/pull/31491/files#r2524933784

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
Benoit Tigeot cf077ceb27 fix: focus only on plugin name but give more info about what we get
And improve test

Follow Scott comment:
> here I would have a list of valid and invalid names based on pattern, with a check and intended outcome for each one so that we comprehensively cover the rules.

https://github.com/helm/helm/pull/31491/files#r2524820312

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
Benoit Tigeot f4b139a82c Make validation error similar and explicit for both metadatas
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
Benoit Tigeot c04e18e452 fix: improve plugin name validation error messages
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
Matt Farina a3db5f5667 Merge pull request #31408 from AndiDog/plugin-err-msg
Improve error message when plugin source cannot be determined or a non-directory is passed
2025-10-21 15:52:54 -04:00
Matt Farina 97ee09d935 Merge pull request #31365 from reddaisyy/main
refactor: use reflect.TypeFor
2025-10-21 15:43:07 -04:00
Andreas Sommer b05411506a Improve error message when plugin source cannot be determined or a non-directory is passed
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
2025-10-20 15:25:59 +02:00
wyrapeseed b9eadd3186 chore: fix some comment format
Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>
2025-10-15 11:19:41 +08:00
reddaisyy e69a12dad3 refactor: use reflect.TypeFor
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
2025-10-08 10:23:30 +08:00
George Jenkins a7a6a5e3b0 Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
Remove unused 'Settings' from plugin schema
2025-10-01 10:08:40 -07:00
George Jenkins 93c02523bb Merge pull request #31249 from banjoh/em/additional-logging
chore: add additional logging to plugin installer
2025-09-24 18:48:52 -07:00
George Jenkins 900cf2a93d Merge pull request #31320 from kosiew/sign-31181
provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)
2025-09-24 18:31:08 -07:00
juejinyuxitu 69dbd6115e chore: fix some typos in comment
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
2025-09-23 18:40:56 +08:00
Siew Kam Onn 7c9176ae35 Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
2025-09-23 16:00:45 +08:00
George Jenkins 6bc6231bcc Remove unused 'Settings' from plugin schema
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-09-21 07:53:41 -07:00
zyfy29 b24bfe4168 Merge branch 'main' into delete-unused-var
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
2025-09-17 18:20:12 +09:00
Tom Wieczorek 6181e0a873 Make test scripts run without /bin/bash
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
2025-09-12 15:24:29 +02:00
yajianggroup cfaf30083a refactor: use strings.CutPrefix
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
2025-09-12 19:03:54 +08:00
Evans Mungai 3d23230ef8 chore: add additional logging to plugin installer
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2025-09-05 10:00:35 +01:00