Matthew Fisher
40572311ab
Merge pull request #6488 from bacongobbler/port-6258
...
fix(downloader): bypass index cache when repository URL defined
2019-10-16 09:10:06 -07:00
Ken Perkins
060def3b88
Fix chartutils/errors.go stack overflow
...
- Changes to use a struct with string property
- Changes references in chartutil/values.go
Signed-off-by: Ken Perkins <ken.perkins@rackspace.com >
2019-10-15 15:03:36 -07:00
Ken Perkins
01ea487582
Introducing an tests for chartutils/errors.go
...
- Should panic on string recursion error
Signed-off-by: Ken Perkins <ken.perkins@rackspace.com >
2019-10-15 13:14:03 -07:00
Aaron Mell
6a98d1f1d2
Code Review Changes
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-14 13:14:14 -05:00
Aaron Mell
4eca26e4e1
Modified the scope of Kubeconfig so it could be set outside an env variable.
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-14 13:14:14 -05:00
Jonas Rutishauser
0650d6953d
Remove all known arguments in plugin invocations
...
Consistenly remove all arguments which are passed as environment
variables.
Get all arguments from environment variables passed to plugins.
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch >
2019-10-12 21:50:42 +02:00
Taylor Thomas
01e593fbcd
fix(action): Fixes ordering of variable binding
...
The recent init action config switched the order of how variables get bound
and where. This led to the namespace variable not being propagated down into
the calls to kubernetes.
Co-authored-by: Matthew Fisher <matt.fisher@microsoft.com >
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com >
2019-10-11 11:41:57 -06:00
Taylor Thomas
da72944611
Merge pull request #6640 from thomastaylor312/feat/parse_pre_release
...
feat(lint): Ports v2 functionality for linting pre-release charts
2019-10-11 10:42:48 -06:00
Taylor Thomas
1123e5ca1f
fix(cli): Fixes incorrect variable reference
...
Because these were additions, git didn't pick up that the recent refactor of
env settings had changed some of the variables. This fixes those small changes
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com >
2019-10-11 10:21:49 -06:00
Matthew Fisher
ed90425ebb
Merge pull request #6632 from mumoshu/add-plugin-envvars
...
v3: Propagate --kube-context, --kubeconfig and --namespace values to plugins
2019-10-11 09:05:43 -07:00
Matthew Fisher
36e30472d7
Merge pull request #6639 from jlegrone/set-default-hook-delete-policy
...
Set default hook deletion policy to before-hook-creation
2019-10-11 09:03:32 -07:00
Matthew Fisher
0f26eeb8fd
Merge pull request #6519 from SimonAlling/dev-v3
...
fix(pkg/chartutil): include values.schema.json in packaged chart
2019-10-11 09:02:01 -07:00
Taylor Thomas
38d4f33a0f
Merge pull request #6641 from VilledeMontreal/feat/refactorOutput
...
ref(cmd): Use method to list formats
2019-10-11 09:59:07 -06:00
Martin Hickey
1cc2ad0061
Port #5298 to Helm v3 ( #6613 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com >
2019-10-11 16:19:26 +01:00
Matthew Fisher
9e9f317cbf
Merge pull request #6608 from bacongobbler/refactor-switch-statement
...
ref(wait): consolidate switch cases
2019-10-11 08:03:46 -07:00
Martin Hickey
dd1a440026
Add support to scaffold chart for ingress prior to k8s 1.14 ( #6651 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com >
2019-10-11 15:33:30 +01:00
John Howard
7a22cb88d9
Drop dependency on k8s.io/kubernetes ( #6609 )
...
* Drop dependency on k8s.io/kubernetes
https://github.com/helm/helm/issues/6606
Depending on k8s.io/kubernetes is not recommended by Kubernetes, and
forces dependencies of Helm to also depend on them. We are only using
this dependency in one relatively isolated occurance, which can be
easily copied over rather than depending on the entire Kubernetes.
Copying this code is not very desirable, so if we don't want to have
this duplication we can at least use this PR as a PoC and see if we can
get Kubernetes to publish the controller package as a separate Go module
(see
https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-538740756 )
Signed-off-by: John Howard <howardjohn@google.com >
* Move to internal
Signed-off-by: John Howard <howardjohn@google.com >
* Exclude third_party from validate-license.sh
Signed-off-by: John Howard <howardjohn@google.com >
2019-10-11 14:13:25 +01:00
Yusuke Kuoka
69adc5a218
v3: Propagate --kube-context, --kubeconfig and --namespace values to plugins
...
Closes #6631
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com >
2019-10-11 21:06:17 +09:00
Simon Alling
2a462aef2d
fix(pkg/chartutil): add tests according to feedback
...
The seemingly redundant `return filename, err` line is related to how
the name `err` is used throughout the function: there is a "global" (to
the function) `err` variable, as well as several locally block-scoped
ones. It took me hours to understand why my code did not work without
that line, but I decided not to clean up the `err` code in this commit.
Signed-off-by: Simon Alling <alling.simon@gmail.com >
2019-10-11 10:49:43 +02:00
Martin Hickey
f12be4c4b6
Port #4078 to Helm v3 ( #6619 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com >
2019-10-11 09:03:36 +01:00
Marc Khouzam
483904656b
ref(cmd): Use string method to list formats
...
This greatly simplifies how to obtain the list of output.Format.
It no longer provides a way to list all output.Format, but focuses
on providing a list of string representation of output.Format, as this
is what is actually needed.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca >
2019-10-10 22:39:18 -04:00
Marc Khouzam
7fd384c8fb
ref(cmd): Use method to list formats
...
This isolates the listing of the different formats to the output.go
file. It is more future-proof if another format is added.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca >
2019-10-10 21:38:38 -04:00
Taylor Thomas
0ba959af0d
feat(lint): Ports v2 functionality for linting pre-release charts
...
This is a port of #5177
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com >
2019-10-10 16:58:47 -06:00
Jacob LeGrone
2d983f27e7
feat(hooks): never delete CustomResourceDefinitions
...
Signed-off-by: Jacob LeGrone <git@jacob.work >
2019-10-10 18:30:57 -04:00
Jacob LeGrone
34d685f8bf
feat(hooks): set default deletion policy to before-hook-creation
...
Signed-off-by: Jacob LeGrone <git@jacob.work >
2019-10-10 18:30:57 -04:00
Matthew Fisher
0227ade173
Merge pull request #6363 from jlegrone/refactor-test-command
...
Remove run test subcommand and --cleanup flag, print test status
2019-10-10 15:24:14 -07:00
Aaron Mell
8b8ffcdb21
Moved config and configOnce to struct
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 16:51:59 -05:00
Jacob LeGrone
0645b92c1b
Print test status
...
Signed-off-by: Jacob LeGrone <git@jacob.work >
2019-10-10 17:50:26 -04:00
Jacob LeGrone
6f18519957
Remove test --cleanup flag
...
Signed-off-by: Jacob LeGrone <git@jacob.work >
2019-10-10 15:11:53 -04:00
Aaron Mell
00249a3235
Moved namespace and kubeconfig variable back to original place.
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 14:01:28 -05:00
Simon Alling
50675e7cd7
fix(pkg/chartutil): include values.schema.json in packaged chart
...
Before this commit:
$ helm lint my-chart # Finds errors in values.yaml
$ helm package my-chart
$ helm lint my-chart-1.0.0.tgz # Does not find errors in values.yaml
Signed-off-by: Simon Alling <alling.simon@gmail.com >
Co-authored-by: Andreas Lindhé <andreas@lindhe.io >
2019-10-10 20:56:06 +02:00
Aaron Mell
1d66a676c8
Moved the GetNamespace and KubeConfig function from action to cli
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 13:35:46 -05:00
Aaron Mell
3264b75378
Refactoring after rebasing with latest
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 13:35:23 -05:00
Aaron Mell
01d7657c1e
Another Code review change
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 13:34:25 -05:00
Aaron Mell
851e016e90
Reverted previous commit, changes based on code review feedback.
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 13:34:25 -05:00
Aaron Mell
1ca2ab1d8d
Moving actionInit from cmd/helm/helm to pgk/action/action to make it easier to instantiate the configuration
...
Signed-off-by: Aaron Mell <amell@lumindigital.com >
2019-10-10 13:34:24 -05:00
Matthew Fisher
0141f9c806
Merge pull request #6628 from VilledeMontreal/fix/impossibleCond
...
Remove impossible condition reported by linter
2019-10-10 10:58:59 -07:00
KUOKA Yusuke
4c351c7248
fix(v3): fix type error while merging map loaded with fromYaml template func ( #6630 )
...
Fixes #6626
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com >
2019-10-10 16:37:54 +01:00
Dmitry Tokarev
1da0d011f9
Added NetworkPolicy, PodDisruptionBudget, and PodSecurityPolicy to InstallOrder. ( #6624 )
...
Port #6266 #4769 #3899 to Helm 3.
Signed-off-by: Dmitry Tokarev <dm.tokarev@yahoo.com >
2019-10-10 12:41:55 +01:00
Marc Khouzam
adbc39beb5
Remove impossible condition reported by linter
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca >
2019-10-09 23:18:03 -04:00
Taylor Thomas
6cfd47784b
Merge pull request #6625 from Dean-Coakley/get-output-cmd
...
fix(cmd): Add --output option to get values
2019-10-09 16:39:11 -06:00
Dean Coakley
3c899d0bde
Add get values table output headers
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com >
2019-10-09 23:08:22 +01:00
Dean Coakley
66268d9eee
fix(cmd): Add --output option to get values
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com >
2019-10-09 23:08:12 +01:00
Adam Reese
1e20ebae35
fix(pkg/kube): validate with OpenAPI on install
...
Signed-off-by: Adam Reese <adam@reese.io >
2019-10-09 14:25:47 -07:00
Adam Reese
442c3588e4
Merge pull request #6599 from adamreese/feat/validation
...
feat(pkg/kube): add openapi validation for k8s objects
2019-10-09 09:23:52 -07:00
Martin Hickey
f2aa97e313
fix(helm): Port accept dependency in requirements.yaml from charts directory ( #6611 )
...
* Port #6578 to Helm 3
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com >
* Update after reviw
Review comments:
- https://github.com/helm/helm/pull/6611#discussion_r332745703
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com >
2019-10-09 16:35:55 +01:00
Adam Reese
572b92dc8a
feat(pkg/kube): add openapi validation for k8s objects
...
Add back OpenAPI validation for kubernetes objects.
Fixes : #6382
Signed-off-by: Adam Reese <adam@reese.io >
2019-10-08 12:55:19 -07:00
Matthew Fisher
f55a64240f
ref(wait): remove versioned type, use unversioned instead
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com >
2019-10-08 10:05:40 -07:00
fengxsong
a4dd603f78
Refactor switch statement in pkg/kube/wait.go
...
Signed-off-by: fengxusong <fengxsong@outlook.com >
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com >
2019-10-08 10:05:40 -07:00
fengxsong
cf728f4076
fix wait.go
...
use *resource.Info.Namespace/Name because runtime.Object is a Interface
Signed-off-by: fengxusong <fengxsong@outlook.com >
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com >
2019-10-08 10:05:40 -07:00