Matthieu MOREL and Copilot Autofix powered by AI
28e64bd2dd
chore: fix gofumpt extra-rules ( #32486 )
...
* chore: fix gofumpt extra-rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-31 16:06:07 -04:00
Matthieu MOREL
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 13:24:06 +02:00
Matt Farina
29cdf6bd41
Merge pull request #31907 from LarytheLord/fix/test-kubeconfig-isolation-31470
...
test(cli): make User-Agent REST config test hermetic
2026-07-21 15:30:00 -04:00
Terry Howe and Copilot Autofix powered by AI
c2fda5ac58
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: Terry Howe <terrylhowe@gmail.com >
2026-07-18 05:33:34 -06:00
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
2026-07-07 12:05:43 -06:00
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-06 23:16:46 +02:00
Matthieu MOREL
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-06 22:35:08 +02:00
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-06 22:35:08 +02:00
LarytheLord
47bde11959
test(cli): use t.Cleanup for resetEnv with t.Setenv
...
Signed-off-by: LarytheLord <llawlietbagsum@gmail.com >
2026-07-06 15:32:34 +05:30
LarytheLord
9b30076180
test(cli): isolate user-agent rest config test from host kubeconfig
...
Signed-off-by: LarytheLord <llawlietbagsum@gmail.com >
2026-07-06 15:32:34 +05:30
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-06 08:36:33 +02:00
George Jenkins and Copilot Autofix powered by AI
144246cd28
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: George Jenkins <gvjenkins@gmail.com >
2026-06-25 15:45:36 +12:00
George Jenkins
16b0760dfd
refactor(pkg/cli): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com >
2026-06-17 21:28:58 +12:00
Sumit Solanki
213c869a98
refactor(cli): share RetryingRoundTripper via pkg/kubeenv
...
Move implementation to pkg/kubeenv per review; kube.RetryingRoundTripper
remains a type alias for API compatibility. pkg/cli uses kubeenv only.
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com >
2026-04-09 22:46:41 +05:30
Sumit Solanki
64f1d0af5b
refactor(cli): decouple EnvSettings from pkg/kube
...
Move the retrying HTTP round-tripper used by EnvSettings into pkg/cli so
pkg/cli no longer imports pkg/kube, avoiding import cycles for Helm
library consumers while preserving retry behavior for transient API
server errors.
Add pkg/cli/roundtripper_test.go with parity coverage for the moved logic.
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com >
Made-with: Cursor
2026-03-27 11:56:33 +05:30
Sumit Solanki
154993723a
refactor(cli): decouple EnvSettings from pkg/kube to avoid import cycles
...
Move the retrying round tripper used by EnvSettings into pkg/cli so
pkg/cli no longer imports pkg/kube. This preserves retry behavior while
breaking the import edge that triggers cycles for Helm library consumers
(such as the kustomize integration described in #31965 ).
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com >
2026-03-26 20:42:56 +05:30
Matthieu MOREL
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-03-23 07:07:27 +01:00
George Jenkins
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
2026-03-13 19:03:04 -07:00
Matthieu MOREL
63f03c0f5c
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-02-26 18:55:55 +01:00
Matthieu MOREL
c25c988cfb
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/registry
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-02-26 18:55:55 +01:00
George Jenkins
92b64e87ad
chore: fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com >
2026-02-23 16:46:35 -08:00
Matthieu MOREL
5cc2e55714
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/chart/v2/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-02-06 16:11:01 +01:00
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
2026-01-07 07:41:31 -07:00
Terry Howe
8802d959cb
Merge pull request #31104 from LinPr/fix
...
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
2025-12-25 04:52:18 -07:00
Zadkiel AHARONIAN
8534663e73
fix(cli): handle nil config in EnvSettings.Namespace()
...
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr >
2025-12-07 17:16:14 +01:00
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com >
2025-09-02 12:14:37 -04:00
Matt Farina
533eddc57d
Add content cache to helm env
...
Signed-off-by: Matt Farina <matt.farina@suse.com >
2025-08-24 17:57:34 -04:00
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com >
2025-08-21 14:33:51 -04:00
LinPr
b25fa862d5
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
...
Signed-off-by: LinPr <314573849@qq.com >
2025-07-31 22:46:40 +08:00
Mohammadreza Asadollahifard
0865d70304
refactor: change default color output setting to auto and remove ColorEnabled method
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-23 23:05:18 +01:00
Mohammadreza Asadollahifard
4ef0f3d5e2
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
2025-07-23 23:00:31 +01:00
Mohammadreza Asadollahifard
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-11 21:08:32 +01:00
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-11 21:04:27 +01:00
Mohammadreza Asadollahifard
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-11 20:52:40 +01:00
Mohammadreza Asadollahifard
96c54a2963
refactor color output functions to simplify noColor checks
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-11 20:27:05 +01:00
naving1989
4310b2bc36
Fixed linting issues
...
Signed-off-by: naving1989 <navinag1989@gmail.com >
2025-07-08 11:04:51 +05:30
Mohammadreza Asadollahifard
1e00790b8c
refactor tests to use t.Setenv for NO_COLOR environment variable
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-07 23:20:55 +01:00
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com >
2025-07-07 23:20:41 +01:00
naving1989
3b2f9e7d6f
test: increase test coverage for pkg/cli/options.go file
...
Signed-off-by: naving1989 <navinag1989@gmail.com >
2025-07-07 23:43:50 +05:30
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-05-30 08:12:11 +02:00
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com >
2025-04-21 12:13:10 -04:00
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com >
2025-02-25 15:20:44 -05:00
lubingtan
ef5614364b
fix: replace mergeMaps call with loader.MergeMaps in MergeValues function
...
Signed-off-by: lubingtan <bingtanlu@gmail.com >
2025-02-20 08:13:54 +08:00
lubingtan
3d84e00ce7
fix: use Reader interface as the input of LoadValues and enhance UT of LoadValues
...
Signed-off-by: lubingtan <bingtanlu@gmail.com >
2025-02-20 08:08:18 +08:00
lubingtan
92087f6e33
feat: support multi-document values files for default chart values
...
Signed-off-by: lubingtan <bingtanlu@gmail.com >
2025-02-20 08:07:46 +08:00
lubingtan
0d36cb664a
feat: support multi-document values files
...
Signed-off-by: lubingtan <bingtanlu@gmail.com >
2025-02-20 08:06:41 +08:00
Matt Farina
8edc3ac024
Merge pull request #13471 from wangjingcun/main
...
Use a more direct and less error-prone return value
2025-02-19 16:04:02 -05:00
wangjingcun
8b8cc94822
Use a more direct and less error-prone return value
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com >
2025-02-11 23:20:27 +08:00
Jonathan and George Jenkins
37020c32fa
Update pkg/cli/values/options.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com >
Signed-off-by: Jonathan <zhanweelee@gmail.com >
2025-02-09 11:11:00 +08:00
Zhanwei Li
274d43c10d
feat: Enhance JSON value parsing in Helm CLI
...
- Add support for parsing full JSON objects with `--set-json`
- Update documentation to clarify JSON value input formats
- Improve test coverage for value parsing scenarios
- Modify `MergeValues` to handle both key=value and JSON object formats
Signed-off-by: Zhanwei Li <zhanweelee@gmail.com >
2025-02-08 10:04:14 +08:00