Commit Graph
111 Commits
Author SHA1 Message Date
Matthieu MORELandCopilot Autofix powered by AI 28e64bd2dd chore: fix gofumpt extra-rules (#32486)
* chore: fix gofumpt extra-rules

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-08-31 16:06:07 -04:00
Matt Farina d2de64e64b Merge pull request #32577 from mattfarina/bump-go-1.27
Updating the Go version
2026-08-28 16:44:57 -04:00
Matt Farina b5b498b774 Updating the Go version
This is needed for goreleaser to create updates. Its latest release
needs it.

Updates needed for linting and to fix failed tests resulting from
Go std library changes.

Signed-off-by: Matt Farina <matt.farina@suse.com>
2026-08-25 20:42:36 -04:00
MsfPablo 6888b0a280 fix: correct 'doest not match' in readiness debug logs
Signed-off-by: MsfPablo <pablogarciacaceres5@gmail.com>
2026-08-24 21:03:31 +02:00
Matthieu MOREL 24bbb46c62 chore: fix gofumpt issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-27 19:53:24 +02:00
Matthieu MOREL 5142ca8ddc chore(internal): refactor: finer tests conversions to testify part 1
#### Description

refactor: finer tests conversions to testify in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-24 13:24:06 +02:00
George Jenkins 178c9f6ade Merge pull request #32406 from mmorel-35/testifylint-manual-assert-internal-2
chore(internal): refactor: convert tests to testify assert/require part 2
2026-07-21 12:26:31 -07:00
George Jenkins 440cc223c5 Merge pull request #32405 from mmorel-35/testifylint-manual-assert-internal-1
chore(internal): refactor: convert tests to testify assert/require part 1
2026-07-21 11:48:33 -07:00
George Jenkins 715888a5eb Merge pull request #32410 from mmorel-35/testifylint-manual-assert-internal-6
chore(internal): refactor: convert tests to testify assert/require part 6
2026-07-21 11:43:44 -07:00
George Jenkins e126cd327a Merge pull request #32409 from mmorel-35/testifylint-manual-assert-internal-5
chore(internal): refactor: convert tests to testify assert/require part 5
2026-07-21 11:37:35 -07:00
Matthieu MOREL 6c45810119 chore(internal): refactor: convert tests to testify assert/require part 4 (#32408)
refactor: convert tests to testify assert/require in internal/chart/v3/util

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-20 14:30:19 -06:00
Matthieu MOREL f1d5979e7d chore(internal): refactor: convert tests to testify assert/require part 5
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-20 21:15:44 +02:00
Matthieu MOREL f3402c1cd6 chore(internal): refactor: convert tests to testify assert/require part 6
refactor: convert tests to testify assert/require in internal/plugin
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-20 21:14:39 +02:00
Matthieu MOREL ba31ca0c0b chore(internal): refactor: convert tests to testify assert/require part 1
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-20 21:10:46 +02:00
Matthieu MOREL 615a299876 chore(internal): refactor: convert tests to testify assert/require part 2
#### Description

refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-20 20:50:57 +02:00
Abhay Chaurasiya 82be04d7f2 remove legacy import comments from remaining packages (#31933)
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.

Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver

Follows up on #31931 and #31932 which addressed pkg/kube.

Fixes #31846

Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2026-07-18 05:42:20 -06:00
Matthieu MOREL a2b1a60d51 fix: enhance error handling and improve test assertions (#32352)
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-18 05:28:03 -06:00
Matthieu MOREL caac755f19 chore(internal): refactor: convert tests to testify assert/require part 3
refactor: convert tests to testify assert/require in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-15 07:28:25 +02:00
George Jenkins 9aa7778886 Merge pull request #32342 from mmorel-35/testifylint-manual-assert-internal-2
chore(internal): refactor: convert tests to testify assert/require part 2
2026-07-14 15:14:27 -07:00
Matthieu MOREL a02a5713de chore: fix elseif and ifElseChain issues from gocritic (#32289)
* chore: fix elseif and ifElseChain issues from gocritic

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* test: enhance assertions in OCIInstaller and list tests using testify

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-14 15:50:53 -06:00
George Jenkins 7a7b328ba5 Merge pull request #32319 from mmorel-35/revive
feat(linters): add new revive rules for better code quality
2026-07-14 14:27:03 -07:00
Matthieu MOREL f280d9c1b5 chore(internal): refactor: convert tests to testify assert/require part 2
refactor: convert tests to testify assert/require in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-13 13:10:52 +00:00
Matthieu MOREL d72b28ebcb chore(internal): refactor: convert tests to testify assert/require part 1
refactor: convert tests to testify assert/require in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-13 12:40:18 +00:00
Matthieu MOREL 16787d65f5 feat(linters): add new revive rules for better code quality
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-10 13:03:37 +02:00
Terry Howe d262c7ca79 Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
chore: fix emptyStringTest, nestingReduce and  singleCaseSwitch checks issues from gocritic
2026-07-07 12:05:43 -06:00
Matthieu MOREL 96b315f188 chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-06 23:16:46 +02:00
Matthieu MOREL 4ade4a5495 test: replace assert.Contains with assert.ErrorContains for better error handling
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-06 22:35:08 +02:00
Matthieu MOREL f34ad6c337 chore: fix several checks issues from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-06 22:35:08 +02:00
Matthieu MOREL 07259ecc86 chore: fix several checks issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-07-06 08:36:33 +02:00
Matthieu MOREL 34cfdfdbe5 chore: enable contextcheck, fatcontext and noctx linters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-06-19 08:37:48 +00:00
George Jenkins 253da5106a Merge pull request #32171 from mmorel-35/empty-len
Fix empty and len testifylint violations across test files
2026-06-18 19:57:07 +12:00
George Jenkins 81d6f04c82 Merge pull request #30867 from mmorel-35/gocritic
chore: fix deprecatedComment issues from gocritic
2026-06-13 11:34:16 +12:00
Terry Howe 59b57c5c31 Merge pull request #31885 from mmorel-35/whitespace
chore: fix whitespace linter
2026-05-30 05:19:51 -06:00
Matthieu MOREL 488c4a805d Fix empty and len testifylint violations across test files
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-05-29 08:02:24 +02:00
Evans Mungai d374e823b2 Merge pull request #32086 from mmorel-35/error-is-as
testifylint: enable error-is-as and error-nil rules
2026-05-28 17:53:03 +01:00
Aleksei Sviridkin 979e68fbbd internal/plugin: remove zero-width spaces from plugin name comment
The comment describing allowed plugin name characters contained three
U+200B (zero-width space) characters around the '_' and '-' literals.
The rendered comment is identical without them; the ZWSP were likely
copy-pasted from a rich-text source.

Downstream impact: every project that vendors helm.sh/helm/v4 and runs
Renovate gets a repo-wide warning on its Dependency Dashboard about
hidden Unicode characters. Renovate scans the whole tree (including
vendor/) for ZWSP/bidi-override codepoints and cannot be told to skip
a path for this specific check. Removing the characters here clears
the warning everywhere downstream.

Signed-off-by: Aleksei Sviridkin <f@lex.la>
2026-05-20 13:24:39 +03:00
Matthieu MOREL f8ba28bb17 testifylint: enable error-is-as and error-nil rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-04-27 20:04:39 +02:00
George Jenkins 087736b66e fix: unnecessary-format lint issues from merge
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-04-08 22:00:58 -07:00
George Jenkins 586eb57338 fix: Plugin missing provenance bypass
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-04-08 21:31:08 -07:00
George Jenkins f8afb35f4e Merge commit from fork
fix: Plugin version path traversal
2026-04-08 21:22:47 -07:00
Matthieu MOREL 7edfff33eb chore: fix unnecessary-format issues from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-23 07:07:27 +01:00
Matthieu MOREL 83a0138172 chore: fix deprecatedComment issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-14 09:39:49 +01:00
Matthieu MOREL 1e0f702f00 chore: fix whitespace linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-03-14 08:47:43 +01:00
George Jenkins 47a084091e ignore error plugin loads (cli, getter)
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-03-12 17:56:01 -07:00
George Jenkins 36dcc27ca3 fix: Plugin version path traversal
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2026-03-11 17:43:13 -07:00
tsinglua 259f181808 chore: fix some minor issues in the comments
Signed-off-by: tsinglua <tsinglua@outlook.com>
2026-03-11 16:55:34 +08:00
George Jenkins c4392033cc Merge pull request #31853 from atombrella/feature/fmt_unneeded
Replace non-format use of t.Fatalf with t.Fatal
2026-03-01 21:24:21 -08:00
Matthieu MOREL d4f6193a7e chore(internal): enable perfsprint linter (#31871)
#### Description

enable perfsprint linter in internal/plugin

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-27 12:41:41 +00:00
Matthieu MOREL 9409226e15 chore(internal): enable perfsprint linter
#### Description

enable perfsprint linter in internal/plugin/installer

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2026-02-26 18:55:55 +01:00
Mads Jensen 36cb3a2fe9 Replace unneeded use of t.Fatalf with t.Fatal
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2026-02-26 18:18:57 +01:00