Commit Graph
1264 Commits
Author SHA1 Message Date
Joe Lanford 618447cbf2 pkg/chartutil: fix SaveDir for nested templates directories
(cherry picked from commit a9c10fe104)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
2019-03-21 11:26:22 -07:00
Alex ccf1d7bc4b fix: helm display confused error message if version is empty (without quotes) (#5310)
Signed-off-by: Alex Gladkikh <theshamuel@gmail.com>
2019-02-15 12:45:55 -05:00
Matthew Fisher e0e5197f8d bump version to v2.13
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-02-13 11:37:25 -08:00
liaoj f5986db184 fix: helm fetch wrong version chart (#4850)
when customer use --version flag, the version format include the Build
metadata, the metadata will be ingorned

Signed-off-by: jliao <jliao@alauda.io>
2019-02-12 09:02:09 -08:00
Matt Butcher 70c509e77e fix: Update gRPC to get better TLS connection handling (v2 minor release) (#5210)
* fix: Update gRPC to get better TLS connection handling

To avoid backward compatibility breakers, we have been pinned to a very
old version of gRPC. But it appears that there have been some very
significant network fixes since then. Looking closely at #3480, it
appears that some of this fixes may be directly related to solving that
bug.

Note that this regenerates a few of the Go proto files, so the binary
wire format may be broken. That means this MUST be held to a minor
version, not a patch release.

To test:

- Build both client and server
- Install Tiller into your cluster
- Perform a number of Helm-Tiller interactions (`helm version`, `helm
list`)

Closes #3480

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* Switched to latest protobuf

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
2019-02-12 08:42:58 -07:00
lIuDuI 9fb9850aca Fix function comment to consistent with its name (#5294)
Signed-off-by: xichengliudui <1693291525@qq.com>
2019-02-12 06:26:24 -08:00
Michelle Noorali 9cfb92185c Merge pull request #5291 from xichengliudui/updatefunc
Fix function comment to consistent with its name
2019-02-11 10:29:25 -05:00
Michelle Noorali d6ec975f74 Merge pull request #5140 from eladiw/master
Fix #3127: Sort resources output by 'helm status'
2019-02-11 08:58:35 -05:00
xichengliudui 5767f13aaa Fix function comment to consistent with its name
Signed-off-by: xichengliudui <1693291525@qq.com>
2019-02-10 23:59:49 -05:00
Gábor Lipták bed4054c41 Correct golint warning (#5287)
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2019-02-10 01:14:32 -08:00
Elad Iwanir 2734066bcc changing return order of test items so the sorting tests will fail if actually broken
Signed-off-by: Elad Iwanir <eladiw@users.noreply.github.com>
2019-02-07 22:58:02 +02:00
Ian Howell a1ea9678be Add unit tests for checking sort order on helm get
Signed-off-by: Ian Howell <ian.howell0@gmail.com>
2019-02-07 22:33:23 +02:00
adshmh d8bdf484cc fix(helm): add descriptive error if dependency has blank "repository" (#5152)
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2019-02-04 14:38:08 -08:00
Alexander Matyushentsev f5df47b1c8 Fix: kind sorter incorrectly compares unknown and namespace (#5186)
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
2019-02-01 09:02:06 -08:00
Flavian 69c7ba320e Fix: type conversion for zero values (#5151)
* added test for zero values

Signed-off-by: Flavian <flavian.sierk@gmail.com>

* implemented case for zero values

Signed-off-by: Flavian <flavian.sierk@gmail.com>
2019-02-01 08:12:46 -08:00
ahmadali shafiee d3373f568c making ingress path configurations more customizable (#5175)
* making ingress path configurations more customizable

Signed-off-by: Ahmadali Shafiee <mail@ahmadalli.net>

* update notes ingress reference

Signed-off-by: Ahmadali Shafiee <mail@ahmadalli.net>
2019-02-01 08:08:28 -08:00
lIuDuI 147dc225e2 Update func name (#5250)
* Update func name

Signed-off-by: xichengliudui <1693291525@qq.com>

* update pull request

Signed-off-by: xichengliudui <1693291525@qq.com>
2019-02-01 06:33:59 -08:00
JoeWrightss 9e18364fea Fix some spelling errors in comment (#5246)
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-01-31 21:33:04 -08:00
James Ravn ab0ba3aa63 fix(tiller): respect resource policy on upgrade (#5225)
Don't delete a resource on upgrade if it is annotated with
helm.io/resource-policy=keep. This can cause data loss for users if the
annotation is ignored (e.g. for a PVC).

Closes #3673

Signed-off-by: James Ravn <james@r-vn.org>
2019-01-29 12:04:17 -08:00
JoeWrightss 197e68ec1f Fix some typos in comment (#5215)
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-01-25 10:46:24 -08:00
Geoff Baskwill 05a365358f fix: ignore pax header "file"s in chart validation
Signed-off-by: Geoff Baskwill <me@geoffbaskwill.ca>
2019-01-22 11:46:11 -05:00
Michelle Noorali 2b7221b5b7 Merge pull request #4088 from jgleonard/2751
#2715 add child NOTES.txt rendering
2019-01-16 12:16:11 -05:00
Jon Leonard 315ed81116 Restore comment text
Signed-off-by: Jon Leonard <jon.leonard@sanofi.com>
2019-01-16 11:53:40 -05:00
Matt Butcher 5603fe8d3e fix: perform extra validation on paths in tar archives (#5165)
* fix: perform extra validation on paths in tar archives

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: Cover a few Windows cases and also remove a duplicate tar reader

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: removed debug output

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: Expand again preserves the files verbatim

Also added tests for Expand

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: add license block and remove println

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
2019-01-14 10:03:35 -07:00
Axel Köhler 893c3b61f6 Add chart name check to lint (#3773)
Signed-off-by: Axel Köhler <koehler.ax3l@gmail.com>
2019-01-10 09:05:44 -08:00
Matthew Fisher 8015fc3570 bump version to v2.12 (#4991)
(cherry picked from commit 657557947c)
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-01-10 08:09:55 -08:00
Elad Iwanir cbf9ad11be fix minor build issue
Signed-off-by: Elad Iwanir <eladiw@users.noreply.github.com>
2019-01-08 20:14:39 +02:00
Elad Iwanir 7c55fdcf02 Sort resources output by 'helm status'
Signed-off-by: Elad Iwanir <eladiw@users.noreply.github.com>
2019-01-08 20:04:22 +02:00
Matthew Fisher 29ab7a0a77 Revert "Fix for existing CRDs are deleted when crd-install hook is introduced (#4709)" (#5067)
This reverts commit e2a0e7fa54.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2018-12-19 12:24:00 -08:00
Alex Humphreys 89467a8bf1 Fix(helm): Use spaces in ingress template
The rest of the ingress template was using spaces, just these two lines
were tabs.

Signed-off-by: Alex Humphreys <alex.humphreys@here.com>
2018-12-18 15:24:33 +01:00
JoeWrightss e9a5465c66 Fix some spelling error (#5032)
Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>
2018-12-14 09:19:23 -08:00
Kévin Dunglas 9aa773042d create: include the namespace in NOTES.txt for LoadBalancer status (#5055)
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
2018-12-14 09:14:14 -08:00
Taylor Thomas ed5297983a Merge pull request #5015 from tariq1890/rm_k8s_dep
Remove k8s.io/kubernetes deps for simple pod and svc util methods
2018-12-06 14:52:02 -08:00
Frank Hamand 158d6dbb74 Add --parallel flag to helm test (#4144)
* Refactor test run to separate method

This will allow us to parallelise it more easily

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Add --parallel flag to helm test

(No functionality in this commit)

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Run helm tests in parallel with --parallel flag

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Add a mutex to helm test message streams

This is to protect against data races when running tests in parallel.

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Add tests for --parallel flag

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Add concurrency limit for parallel helm tests

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Add test for concurrency limit

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

* Fix rebase introduced errors

Signed-off-by: Frank Hamand <frankhamand@gmail.com>
2018-12-05 14:04:48 -08:00
Helgi Þormar Þorbjörnsson 15703cb199 Return empty string instead of nil when linting on required (#4748)
* Return empty string instead of nil when linting on required

This allows lint to work in scenarios when required is used in secrets or it's output is passed to another function.
Due to lint mode no longer failing on missing value in required it is passing nil through which not all functions can accept.

Fixes #4747

Signed-off-by: Helgi Þorbjörnsson <helgith@gmail.com>

* Apply suggestions from code review

Co-Authored-By: helgi <70530+helgi@users.noreply.github.com>
Signed-off-by: Helgi Þorbjörnsson <helgith@gmail.com>

* Add tests

Signed-off-by: Helgi Þorbjörnsson <helgith@gmail.com>
2018-12-05 13:30:42 -08:00
Henry Nash adce632c83 fix(helm): get rid of lint warning in pkg/storage (#5021)
Provide comment for constant to avoid golint warning.

Closes #5020

Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
2018-12-05 13:06:46 -08:00
tariqibrahim dc186e12c3 remove for k8s.io/kubernetes deps for simple pod and svc util methods
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-05 12:28:41 -08:00
Taylor Thomas 6d3809a416 ref(kube): Gets rid of superfluous Sprintf call
Signed-off-by: Taylor Thomas <thomastaylor312@gmail.com>
2018-12-05 10:47:41 -08:00
Taylor Thomas 88af9659a2 Merge pull request #4928 from mortent/FixCustomResourcePrinting
fix(helm): Fix line breaks when printing custom resources
2018-12-05 10:21:10 -08:00
Taylor Thomas 58272bfd4a Merge pull request #4930 from mortent/FixStatusPodOutput
fix(helm): Print details for pod resource
2018-12-05 10:15:24 -08:00
įoнииγ įoнииγ 03718ee93d Added extra padding to resources template (#4981)
This is probably a silly PR.  However, each time I create a new chart
via `helm create`, the instructions to uncomment the resource limits
require adding a couple extra spaces back to the YAML.

This PR simply brings the spacing in-line with the rest of the generated
template.

Signed-off-by: John Dewey <john@dewey.ws>
2018-12-05 10:08:06 -08:00
Tariq Ibrahim 99199c9752 add unit tests for portforwarder (#4979)
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
2018-12-04 08:25:37 -08:00
Martin Hickey 58be8e461c Update messaging in value parsing to improve traceability (#4974)
Closes #4736

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2018-11-30 10:04:37 -08:00
Morten Torkildsen 55a338579a fix(helm): Allow custom resources in hooks (#4986)
Currently the code that handles hooks uses a builder that creates the versioned types rather than unstructured. This results in an error whenever a custom resource is used in the hook as the type will not be registered in the scheme used in Helm. This changes this to use a builder that created unstructured resources and only converts to the versioned type when needed.

Signed-off-by: Morten Torkildsen <mortent@google.com>
2018-11-29 15:50:23 -08:00
Michael Merrill e2a0e7fa54 Fix for existing CRDs are deleted when crd-install hook is introduced (#4709)
Signed-off-by: mmerrill3 <michael.merrill@vonage.com>
2018-11-29 10:09:10 -08:00
Taylor Thomas a34baf0eea Merge pull request #4978 from ultimateboy/dont-delete-deployed
fix(storage): when pruning release versions, never delete the last deployed revision
2018-11-28 14:29:46 -08:00
Matt Tucker 5bf38a2d7d fix(storage): when pruning release versions, never delete the last deployed revision
Signed-off-by: Matt Tucker <ultimateboy@gmail.com>
2018-11-28 12:46:35 -07:00
Luke Hoban 75b4afaa33 Allow missing trailing '/' in --repo url (#4956)
Apply the same procedure to allow missing trailing slash in repo base URLs used in `repo/chart` inputs to `--repo` inputs.

Fixes #4954.

Signed-off-by: Luke Hoban <luke@pulumi.com>
2018-11-28 11:15:49 -08:00
Morten Torkildsen ede43a313d fix(helm): Print details for pod resource
Due to a regression from a previous change, details about pod resources
does not show up in the status output. This makes sure that the pod type
from core are passed in to the printer so the details are shown in the
output.

Signed-off-by: Morten Torkildsen <mortent@google.com>
2018-11-28 10:49:07 -08:00
Matthew Fisher 97465abda0 fix(windows): fix unit tests on Windows (#4897)
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2018-11-28 09:59:32 -08:00