37 Commits
Author SHA1 Message Date
Matt Farina a4f46d7a38 Fix error when loading irregular files
Signed-off-by: Matt Farina <matt@mattfarina.com>
2019-10-29 16:30:42 -04:00
Matthew Fisher cf30db50f5 Merge pull request #5298 from jordansissel/issue/5296/error-hinting
Extra hint in the error when failing to open a chart file.
2019-10-03 15:14:40 -07:00
Matthew Fisher d8d56fe111 Merge pull request #5610 from adshmh/feat-5552-fix-root-folder-files-error
improve error message for content outside base dir
2019-10-03 13:44:05 -07:00
Martin Hickey dd4afa6af0 Fail to load charts that are not v1 apiVersion (#6180)
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-08-10 11:55:26 +01:00
Jordan Sissel 15c6bef6a5 Try a bit harder to provide a clear error message.
When an unexpected file format is provided for a chart archive, spend
some extra effort to provide the user with some meaningful feedback.

This is intended to help users who mistakenly invoke `helm template`
like this:

    helm template values.yaml charts/mychart

This is a user error, and now we can report that the argument
`values.yaml` was expected to be a chart.

Fixes #5296

Signed-off-by: Jordan Sissel <jls@semicomplete.com>
2019-06-10 16:21:44 -07:00
Arash Deshmeh 720c28f4c5 fix(helm): improve error message for content outside base dir
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2019-04-17 15:02:09 -04:00
Geoff Baskwill 05a365358f fix: ignore pax header "file"s in chart validation
Signed-off-by: Geoff Baskwill <me@geoffbaskwill.ca>
2019-01-22 11:46:11 -05:00
Matt Butcher 5603fe8d3e fix: perform extra validation on paths in tar archives (#5165)
* fix: perform extra validation on paths in tar archives

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: Cover a few Windows cases and also remove a duplicate tar reader

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: removed debug output

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: Expand again preserves the files verbatim

Also added tests for Expand

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* fix: add license block and remove println

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
2019-01-14 10:03:35 -07:00
Matthew Fisher 97465abda0 fix(windows): fix unit tests on Windows (#4897)
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2018-11-28 09:59:32 -08:00
Matthew Fisher 2d77db11fa change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
Matthew Fisher e1027fae73 refactor symWalk() into pkg/sympath (#3199)
* refactor symWalk() into pkg/sympath

* add Go copyright

* remove dead code
2018-01-08 15:13:13 -08:00
Johnny Bergström 7cc610960f Walk symbolic link directories
Continue walking symlinks to be able to use them
for sub-charts. Useful when not specifying requirements
but still want to share charts locally.
2017-11-23 11:41:09 +01:00
Johnny Bergström d762a42168 Fix helmignore for .* (#3114)
When the first rule matching entry for top level dir
will be empty string, the .* rule will match.
Skip this entry as it's not needed for processing.
2017-11-22 09:20:41 -07:00
Matthew Fisher f278675f98 remove references to facebookgo/symwalk 2017-09-26 15:21:40 -07:00
Matthew Fisher 211f5f6f33 Revert "fix(helm): resolve symlinks when loading chart"
This reverts commit edd4e56112.
2017-09-26 15:02:33 -07:00
Sushil Kumar 99065aa331 Validates chart-dir before running dependency list command
Fixes issues/2276: helm dependency list hangs if run on large directory
2017-04-17 14:23:04 -07:00
Adam Reese 85c41ef11a ref(*): kubernetes v1.6
Rebase on kubernetes v1.6
2017-04-11 15:42:23 -07:00
Matthew Fisher de6fb23e7a expose LoadFiles as a usable function
In third-party libraries, charts can be embedded in memory rather than in files, directories or
tarballs. Exposing LoadFiles allows a third-party library the ability to load static templates
in and spit out a *chart.Chart.
2017-02-28 15:47:40 -08:00
Maxim Ivanov edd4e56112 fix(helm): resolve symlinks when loading chart
Possible fix for #1639
2017-02-23 23:09:57 +00:00
Euan Kemp 25f74989a5 fix(chartutil): improve 'missing name' error 2016-12-18 23:19:01 -08:00
Matt Butcher 7f4ea91028 Merge pull request #1645 from rodcloutier/Windows_archive_backslash_support
fix(helm): added support for compressed charts containing \ in file paths
2016-12-14 18:13:58 -06:00
Adam Reese 0c6b6d1c62 fix(*): correct file permissions on source files 2016-12-07 09:09:38 -08:00
Rodrigue Cloutier 37920761a4 fix(helm): added support for compressed charts containing \ in file paths 2016-12-06 09:13:40 -05:00
Rodrigue Cloutier f3b205c6ef fix(*): fixed tests for Windows 2016-12-05 11:17:47 -05:00
Jim 7a054e0e6b fix(pkg/chartutil): add error if chart yaml not in directory
For archived files the Chart.yaml file should be contained in a base
directory. This commit adds an error when the Chart.yaml file is found
in the root directory.

Fixes #1171
2016-10-31 22:25:38 -04:00
Matt Butcher 2388e71528 fix(helm): ignore dotfiles in charts/ directories
This causes 'helm dep [up|install]' to ignore files in charts/ that
start with either a dot or an underscore. It also changes the
chartloader to ignore those files.

Also, if a 'helm dep up' does not find a charts/ directory, it creates
one.

Closes #1342
2016-10-11 18:59:45 -06:00
Matt Butcher 593718d749 feat(helm): add 'helm dependency' commands
This also refactors significant portions of the CLI, moving much of the
shared code into a library.

Also in this release, a testing repository server has been added.
2016-09-23 16:24:22 -06:00
joe2far 96de0e35aa feat(helm): ignore by default all dotfiles in templates/ 2016-08-26 20:07:00 +01:00
Matt Butcher 2e95230b30 fix(helm): fix helmignore evaluation of dirs
This adds a few extra settings to the default .helmignore file. In
doing this, I found a bug that some directory patterns are not
evaluated correctly. Fixed that and added tests.

Closes #989
Closes #1027
2016-08-05 15:50:02 -06:00
Miguel Martinez 03d27779d3 Templates Lint rules
Template rules

Adding chart errors

Added function that checks the existence of all the values in the templates

Adding chartfile unit tests

Testing runLinterRule

Fixing out of range

Fixing out of range

Improving quote detector
2016-06-23 12:36:25 -07:00
Matt Butcher e757b24aed fix(*): add license header 2016-06-22 12:28:45 -06:00
Matt Butcher 23ce6142f9 fix(chartutil): remove a wayward println 2016-06-21 16:53:28 -06:00
Matt Butcher 713020359b feat(pkg/ignore): add helmignore library
This adds support for .helmignore files. These files roughly follow
the conventions established for .gitignore files:
https://git-scm.com/docs/gitignore

Closes #748
2016-06-15 13:00:42 -06:00
Matt Butcher 9ca8c27e16 fix(*): change TOML to YAML 2016-06-06 21:12:36 -06:00
Adam Reese 818c878700 chore(*): use k8s.io as the import path 2016-06-06 17:17:04 -07:00
Matt Butcher 2802fcbd87 feat(chartutil): optimize for re-use
This is a refactor of the loader to use in-memory buffers instead of
trying to optimize for memory usage by delaying reads until the last
possible moment. Since charts tend to stay well below 1M in size, this
makes more sense, and is easier to work with.
2016-06-02 16:09:48 -06:00
Matt Butcher 25053e6ada feat(pkg/chartutil): add chartutil package 2016-05-26 09:41:43 -06:00