77 Commits
Author SHA1 Message Date
Matt Butcher 0e32e6417b fix: lint with strict passes for helm create (#7926)
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
2020-04-15 11:48:07 -06:00
Martin Hickey 146f4315d3 Update Ingress API group in scaffold chart
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-10-09 15:48:06 +01:00
Scott Rigby d7f32def39 Merge pull request #5622 from scottrigby/chartutil-create-improve-getting-lb-service-address-notes
fix(pkg/chartutil): Improve getting LoadBalancer address in NOTES.txt
2019-08-09 20:04:39 -04:00
Naseem 9af767c0e5 Add security context
Signed-off-by: Naseem <naseemkullah@gmail.com>
2019-06-22 10:27:23 -04:00
Matthew Fisher d93b660c62 Revert "Change port forward command order in default note"
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2019-06-17 07:32:19 -07:00
Matt Farina 6c88a429ff Merge pull request #5890 from naseemkullah/sa
[helm create] Add service account to templates
2019-06-17 10:03:07 -04:00
Aisuko 2868aed321 Change port forward command order in default note
Signed-off-by: Aisuko <urakiny@gmail.com>
2019-06-17 16:53:57 +08:00
Naseem ab8585faea Keep indentation consistent
Signed-off-by: Naseem <naseemkullah@gmail.com>
2019-06-14 15:29:53 -04:00
Naseem a985f34b81 Add sa
Signed-off-by: Naseem <naseemkullah@gmail.com>
2019-06-13 17:40:23 -04:00
Tim Schrumpf 741dd4a93b Ingress ServicePort from Values
Signed-off-by: tillepille <github@tillepille.io>
2019-06-04 18:28:21 +02:00
Martin Hickey 470d92e126 Fix scaffold chart label in helper template
The 'app.kubernetes.io/version' label was not being rendered as
expected. It was appending onto the label before it and also
the next label label was appending onto it on the same line.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2019-04-30 11:49:53 +01:00
Matthew Fisher 3da600d03f Merge pull request #5271 from donbowman/add-imagePullSecret
Add imagePullSecret to the `default` helm create template
2019-04-29 11:07:08 -07:00
Luis Davim 0270f2e2b5 Reduce template code duplication. Fixes #5372
Signed-off-by: Luis Davim <luis.davim@jet.com>
2019-04-24 13:44:21 +01:00
Scott Rigby 3df75ec1d9 Improve getting LoadBalancer address in NOTES.txt
See https://github.com/helm/charts/issues/84

Signed-off-by: Scott Rigby <scott@r6by.com>
2019-04-19 19:56:17 -04:00
Luis Davim b7b372f693 Add app.kubernetes.io/version label
Signed-off-by: Luis Davim <luis.davim@jet.com>
2019-03-09 17:15:22 +00:00
Don Bowman e80f173526 Change indent of {{ with }}
Signed-off-by: Don Bowman <db@donbowman.ca>
2019-03-02 10:55:38 -05:00
Don Bowman d819efa48b Make imagePullSecrets and array, move to root level
Changes as per PR https://github.com/helm/helm/pull/5271

- make imagePullSecrets be an array
- move imagePullSecrets to 'root' level of Values

Signed-off-by: Don Bowman <db@donbowman.ca>
2019-02-23 17:57:39 -05:00
Don Bowman 3b716b6d73 Add imagePullSecret to the default helm create template
This relates to [#3529](https://github.com/helm/helm/issues/3529).
It adds image.pullSecret to the default generate blank chart
when the user does `helm create`.

Signed-off-by: Don Bowman <don@agilicus.com>
2019-02-06 12:10:30 -05:00
ahmadali shafiee d3373f568c making ingress path configurations more customizable (#5175)
* making ingress path configurations more customizable

Signed-off-by: Ahmadali Shafiee <mail@ahmadalli.net>

* update notes ingress reference

Signed-off-by: Ahmadali Shafiee <mail@ahmadalli.net>
2019-02-01 08:08:28 -08:00
Alex Humphreys 89467a8bf1 Fix(helm): Use spaces in ingress template
The rest of the ingress template was using spaces, just these two lines
were tabs.

Signed-off-by: Alex Humphreys <alex.humphreys@here.com>
2018-12-18 15:24:33 +01:00
Kévin Dunglas 9aa773042d create: include the namespace in NOTES.txt for LoadBalancer status (#5055)
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
2018-12-14 09:14:14 -08:00
įoнииγ įoнииγ 03718ee93d Added extra padding to resources template (#4981)
This is probably a silly PR.  However, each time I create a new chart
via `helm create`, the instructions to uncomment the resource limits
require adding a couple extra spaces back to the YAML.

This PR simply brings the spacing in-line with the rest of the generated
template.

Signed-off-by: John Dewey <john@dewey.ws>
2018-12-05 10:08:06 -08:00
Erik Sundell eb96576b8d Reform indentation practices using nindent (#4562)
The essence of this commit is to help people get started with a better
indentation practice than this:

```yaml
spec:
  labels:
{{ toYaml .Values.labels | indent 4 }}
```

The previous indentation practice is harder to read. Instead this commit
introduces an indentation practice using `nindent` like this:

```yaml
spec:
  labels:
    {{- toYaml .Values.labels | nindent 4 }}
```

Signed-off-by: Erik Sundell <erik.i.sundell@gmail.com>
2018-11-06 21:03:44 -08:00
Martin Hickey f6efe2f0c1 Add test template example for helm create (#4524)
* Add test template example for helm create

As helm create ganerates an nginx chart, the example is based on
https://github.com/helm/helm/blob/master/docs/examples/nginx/templates/
service-test.yaml

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Update after review

- https://github.com/helm/helm/pull/4524#pullrequestreview-155183390
- https://github.com/helm/helm/pull/4524#pullrequestreview-155379922
- Fix where app.kubernetes.io/instance was incorrect in service selector

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Add doc update

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Update GO formatting

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2018-10-17 14:10:46 -07:00
Adam Reese 26c88ec815 Merge pull request #4703 from adshmh/4556-fix-paths-ingress-template
fix paths in the ingress template and values file written by helm create
2018-10-11 14:41:06 -07:00
Florian Rusch 6f12ab24a5 Add the .vscode folder to the .helmignore file
Signed-off-by: Florian Rusch <git@florianrusch.de>
2018-10-06 10:46:31 +02:00
adshmh 2ef61fdf5c feat(helm): use apps/v1 as deployment apiVersion (#4725)
Use 'apps/v1' as the apiVersion field for the deployment.yaml written
by the 'helm create' command, rather than the deprecated 'apps/v1beta2'.

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-10-01 12:27:17 -07:00
Arash Deshmeh 1a54463bdb fix(helm): fix paths in the ingress template and values file written by helm create
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-09-26 11:24:54 -04:00
Qiang Li 4dd9047586 fix(helm): fix selector typo in service template for 'helm create' (#4663)
changed instancelease to instance in service template

closes #4661

Signed-off-by: Qiang Li <liqiang@gmail.com>
2018-09-18 13:55:22 -07:00
Martin Hickey 7306b4c28e Fix helm create note for k8 label convention changes
Update to note as per changes in Issue #4335 . Otherwise cannot
retrieve the pod with the label names.
2018-08-24 16:17:41 +01:00
Matt Farina e328d00a2f Updating to the k8s label convention
Closes #4335

Signed-off-by: Matt Farina <matt@mattfarina.com>
2018-08-08 12:21:38 -04:00
Matthew Fisher 2d77db11fa change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
Alejandro Vicente Grabovetsky 4fbc733ade Migrate 'template' to 'include' in 'helm create' to conform to Helm best practices
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
2018-05-19 02:42:49 +03:00
Julien Bordellier cf3ded91f2 Add quoting support in ingress to allow wildcard domain 2018-04-24 15:26:57 +02:00
Matthew Fisher f201db3fc2 Merge pull request #3692 from aleerizw/fix-sigsegv-create
Fixed SIGSEGV when running helm create with -p and no values.yaml file
2018-04-20 10:15:14 -07:00
Steffen Windoffer 8bd42d2645 remove unused servicePort from default ingress template 2018-04-06 11:21:54 +02:00
Zack Williams 1d3ae54185 Fix #3822 2018-04-03 13:10:56 -07:00
Ali Rizwan 99da9fb548 Fixed SIGSEGV when running helm create with -p and no values.yaml file 2018-03-15 16:09:58 +01:00
Matthew Fisher 14c7be1f92 Merge pull request #3288 from bradbeam/starter
feat Making starter templates more versatile
2018-01-19 11:14:21 -08:00
Reinhard Nägele f47e1619b0 Update initial chart experience
* Add template for chart name
* Use named ports and simplify service configuration
* Add affinity
* Add tolerations
* Use 'with' statements where possible
* Enhance ingress
* Add fullnameOverride to fullname template
2018-01-12 14:41:03 +01:00
Brad Beam 8e0eface2c Making starter templates more versatile
This adds support for changing '<CHARTNAME>'
occurances in starter chart to the destination
chart name
2018-01-01 04:34:38 +00:00
Alexandr Burdiyan f432e07126 ref(helm): improve fullname template in starter chart
Closes #1186
2017-11-23 11:23:32 +01:00
Maxime Guyot c864ba179e Add fullnameOverride 2017-11-10 10:52:56 +01:00
Dhilip 67af4998de helm create all defined template names should be namespaced … (#2845)
* helm create all defined template names should be namespaced https://docs.helm.sh/chart_best_practices/#names-of-defined-templates

* Update Doc

* Update example
2017-10-06 09:04:53 -06:00
Adnan Abdulhussein 8fd8a7c324 fix(create): port-forward should use internal port
cc @james-w
2017-09-07 10:43:53 +01:00
Maxime Guyot bbf2d6b7e8 Fix the default NOTES.txt 2017-08-09 13:29:51 +02:00
Miouge1 6cfed9d635 Updating default values.yaml comments
Following the instructions to simply uncomment the following lines results in a invalid yaml output
2017-07-27 10:53:52 +02:00
Ilya Semenov 13b15f5662 Remove service.type mention from ingress docs 2017-07-02 16:04:50 +07:00
Reinhard Nägele 76e6e15a0c Add comment on resources 2017-06-18 14:42:36 +02:00
Reinhard Nägele 51923e54b1 Improve 'helm create' 2017-06-16 09:41:38 +02:00