Johannes Schindelin 74fb18824c bisect: handle NULL commit in bisect_successful() ...

When `lookup_commit_reference_by_name()` is called to find the first bad
commit, the result is passed to `repo_format_commit_message()`
immediately, which dereferences commit without checking for NULL.

However, the commit could be NULL, even though in practice this is
unlikely because `bisect_successful()` is only called after a successful
bisect run has identified the bad commit, but the ref could still become
dangling due to a concurrent gc or repository corruption.

Pointed out by Coverity.

Assisted-by: Claude Opus 4.6
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2026-07-10 08:13:54 -07:00

..

add.c

odb: split struct odb_transaction into separate header

2026-05-15 04:44:39 +09:00

am.c

hook: mark non-parallelizable hooks

2026-04-10 07:58:53 -07:00

annotate.c

…

apply.c

…

archive.c

connect: use "service" enum for "name" argument

2026-05-19 15:05:46 +09:00

backfill.c

path-walk: add pl_sparse_trees to control tree pruning

2026-05-24 18:41:06 +09:00

bisect.c

bisect: handle NULL commit in bisect_successful()

2026-07-10 08:13:54 -07:00

blame.c

environment: stop using the_repository in is_bare_repository()

2026-06-11 05:05:54 -07:00

branch.c

object-name: turn INTERPRET_BRANCH_* constants into enum values

2026-03-18 12:52:29 -07:00

bugreport.c

…

bundle.c

…

cat-file.c

Merge branch 'ps/odb-source-packed'

2026-07-06 15:50:21 -07:00

check-attr.c

environment: stop using the_repository in is_bare_repository()

2026-06-11 05:05:54 -07:00

check-ignore.c

…

check-mailmap.c

mailmap: stop using the_repository

2026-02-20 08:13:58 -08:00

check-ref-format.c

setup: stop using the_repository in setup_git_directory_gently()

2026-05-19 19:36:24 +09:00

checkout--worker.c

…

checkout-index.c

setup: stop using the_repository in prefix_path()

2026-05-19 19:36:24 +09:00

checkout.c

refs: move parsing of "core.logAllRefUpdates" back into ref stores

2026-06-26 08:27:19 -07:00

clean.c

Merge branch 'jk/color-variable-fixes'

2025-09-29 11:40:35 -07:00

clone.c

setup: stop using the_repository in init_db()

2026-05-19 19:36:25 +09:00

column.c

…

commit-graph.c

commit-graph: add new config for changed-paths & recommend it in scalar

2025-10-22 10:40:11 -07:00

commit-tree.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

commit.c

sequencer: teach autostash apply to take optional conflict marker labels

2026-04-29 21:46:03 +09:00

config.c

config: improve diagnostic for "set" with missing value

2026-06-03 08:39:54 +09:00

count-objects.c

packfile: introduce macro to iterate through packs

2025-10-16 14:42:39 -07:00

credential-cache--daemon.c

…

credential-cache.c

…

credential-store.c

builtin/credential-store: move is_rfc3986_unreserved to url.[ch]

2026-01-12 11:56:56 -08:00

credential.c

…

describe.c

Merge branch 'td/describe-tag-iteration'

2026-06-17 11:10:11 -07:00

diagnose.c

…

diff-files.c

…

diff-index.c

setup: stop using the_repository in setup_work_tree()

2026-05-19 19:36:24 +09:00

diff-pairs.c

…

diff-tree.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

diff.c

diff: handle NULL return from repo_get_commit_tree()

2026-07-10 08:13:54 -07:00

difftool.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

fast-export.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

fast-import.c

Merge branch 'js/objects-larger-than-4gb-on-windows-more'

2026-06-21 16:41:38 -07:00

fetch-pack.c

connect: use "service" enum for "name" argument

2026-05-19 15:05:46 +09:00

fetch.c

Merge branch 'mh/fetch-follow-remote-head-config'

2026-07-06 15:50:22 -07:00

fmt-merge-msg.c

…

for-each-ref.c

…

for-each-repo.c

for-each-repo: simplify passing of parameters

2026-03-03 10:20:00 -08:00

fsck.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

fsmonitor--daemon.c

fsmonitor: convert shown khash to strset in do_handle_client

2026-04-15 08:44:34 -07:00

gc.c

Merge branch 'ps/setup-drop-global-state'

2026-07-06 15:50:19 -07:00

get-tar-commit-id.c

…

grep.c

Merge branch 'ps/odb-source-packed'

2026-07-06 15:50:21 -07:00

hash-object.c

setup: stop using the_repository in setup_git_directory()

2026-05-19 19:36:25 +09:00

help.c

setup: stop using the_repository in setup_git_directory_gently()

2026-05-19 19:36:24 +09:00

history.c

environment: stop using the_repository in is_bare_repository()

2026-06-11 05:05:54 -07:00

hook.c

hook: allow hook.jobs=-1 to use all available CPU cores

2026-04-10 07:58:55 -07:00

index-pack.c

Merge branch 'js/objects-larger-than-4gb-on-windows-more'

2026-06-21 16:41:38 -07:00

init-db.c

environment: split up concerns of is_bare_repository_cfg

2026-06-11 05:05:54 -07:00

interpret-trailers.c

Merge branch 'kh/doc-interpret-trailers-1'

2026-03-27 11:00:02 -07:00

last-modified.c

Merge branch 'tc/last-modified-not-a-tree'

2026-02-13 13:39:25 -08:00

log.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

ls-files.c

Merge branch 'js/objects-larger-than-4gb-on-windows-more'

2026-06-21 16:41:38 -07:00

ls-remote.c

ref-filter: propagate peeled object ID

2025-11-04 07:32:25 -08:00

ls-tree.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

mailinfo.c

…

mailsplit.c

mailsplit: move NULL check before first use of file handle

2026-07-10 08:13:54 -07:00

merge-base.c

commit-reach: early exit paint_down_to_common for single merge-base

2026-05-12 09:33:43 +09:00

merge-file.c

setup: stop using the_repository in setup_git_directory()

2026-05-19 19:36:25 +09:00

merge-index.c

…

merge-ours.c

merge-ours: integrate with sparse-index

2026-02-06 11:45:33 -08:00

merge-recursive.c

…

merge-tree.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

merge.c

Merge branch 'kk/merge-octopus-optim'

2026-05-27 14:15:44 +09:00

mktag.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

mktree.c

builtin/mktree: remove USE_THE_REPOSITORY_VARIABLE

2026-03-12 10:03:23 -07:00

multi-pack-index.c

midx: refactor interfaces to work on "packed" source

2026-06-17 05:00:01 -07:00

mv.c

Merge branch 'ob/more-repo-config-values'

2026-06-15 07:42:00 -07:00

name-rev.c

Merge branch 'kh/name-rev-custom-format'

2026-05-19 09:57:44 +09:00

notes.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

pack-objects.c

Merge branch 'tb/pack-path-walk-bitmap-delta-islands'

2026-07-06 15:50:23 -07:00

pack-redundant.c

pack-redundant: fix memory leak when open_pack_index() fails

2026-02-21 21:26:53 -08:00

pack-refs.c

builtin/pack-refs: factor out core logic into a shared library

2025-09-19 10:02:55 -07:00

patch-id.c

patch-id: use “patch ID” throughout

2026-01-09 06:07:21 -08:00

prune-packed.c

…

prune.c

…

pull.c

fetch: add --negotiation-include option for negotiation

2026-05-20 11:33:24 +09:00

push.c

push: support pushing to a remote group

2026-05-04 10:11:17 +09:00

range-diff.c

Merge branch 'kh/format-patch-range-diff-notes'

2025-10-14 12:56:09 -07:00

read-tree.c

setup: stop using the_repository in setup_work_tree()

2026-05-19 19:36:24 +09:00

rebase.c

use strvec_pushv() to add another strvec

2026-03-24 12:26:58 -07:00

receive-pack.c

Merge branch 'ar/receive-pack-worktree-env'

2026-06-07 23:58:24 +09:00

reflog.c

Merge branch 'ps/reflog-migrate-fixes' into maint-2.51

2025-10-15 10:29:28 -07:00

refs.c

fsck: store repository in fsck options

2026-03-23 08:33:10 -07:00

remote-ext.c

…

remote-fd.c

…

remote.c

odb: rename odb_has_object() flags

2026-03-31 20:43:14 -07:00

repack.c

Merge branch 'ps/odb-source-packed'

2026-07-06 15:50:21 -07:00

replace.c

hex: add and use strbuf_add_oid_hex()

2026-05-14 15:59:25 +09:00

replay.c

replay: allow to specify a ref with option --ref

2026-04-01 21:34:25 -07:00

repo.c

Merge branch 'jk/repo-info-path-keys'

2026-07-06 15:50:23 -07:00

rerere.c

…

reset.c

environment: stop using the_repository in is_bare_repository()

2026-06-11 05:05:54 -07:00

rev-list.c

rev-list: use reduce_heads() for --maximal-only

2026-04-06 12:02:30 -07:00

rev-parse.c

Merge branch 'jk/repo-info-path-keys'

2026-07-06 15:50:23 -07:00

revert.c

Merge branch 'pw/3.0-commentchar-auto-deprecation'

2025-09-18 10:07:00 -07:00

rm.c

setup: stop using the_repository in setup_work_tree()

2026-05-19 19:36:24 +09:00

send-pack.c

connect: use "service" enum for "name" argument

2026-05-19 15:05:46 +09:00

shortlog.c

mailmap: stop using the_repository

2026-02-20 08:13:58 -08:00

show-branch.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

show-index.c

show-index: use gettext wrapping in user facing error messages

2026-01-30 08:58:12 -08:00

show-ref.c

odb: rename odb_has_object() flags

2026-03-31 20:43:14 -07:00

sparse-checkout.c

Merge branch 'ob/more-repo-config-values'

2026-06-15 07:42:00 -07:00

stash.c

Merge branch 'aj/stash-patch-optimize-temporary-index'

2026-06-07 23:58:25 +09:00

stripspace.c

setup: stop using the_repository in setup_git_directory_gently()

2026-05-19 19:36:24 +09:00

submodule--helper.c

setup: stop using the_repository in setup_work_tree()

2026-05-19 19:36:24 +09:00

symbolic-ref.c

…

tag.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

unpack-file.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

unpack-objects.c

odb: use size_t for object_info.sizep and the size APIs

2026-06-15 07:45:41 -07:00

update-index.c

Merge branch 'ps/setup-wo-the-repository'

2026-05-27 14:15:46 +09:00

update-ref.c

update-ref: handle rejections while adding updates

2026-05-05 16:34:08 +09:00

update-server-info.c

…

upload-archive.c

setup: stop using the_repository in enter_repo()

2026-05-19 19:36:24 +09:00

upload-pack.c

setup: stop using the_repository in enter_repo()

2026-05-19 19:36:24 +09:00

url-parse.c

builtin: create url-parse command

2026-05-06 09:48:28 +09:00

var.c

…

verify-commit.c

…

verify-pack.c

…

verify-tag.c

tag: support arbitrary repositories in gpg_verify_tag()

2025-12-29 22:02:53 +09:00

worktree.c

hook: mark non-parallelizable hooks

2026-04-10 07:58:53 -07:00

write-tree.c

…