Junio C Hamano 6a2abdc125 apply: compute patch->def_name correctly under -p0 ...

Back when "git apply" was written, we made sure that the user can
skip more than the default number of path components (i.e. 1) by
giving "-p<n>", but the logic for doing so was built around the
notion of "we skip N slashes and stop".  This obviously does not
work well when running under -p0 where we do not want to skip any,
but still want to skip SP/HT that separates the pathnames of
preimage and postimage and want to reject absolute pathnames.

Stop using "stop_at_slash()", and instead introduce a new helper
"skip_tree_prefix()" with similar logic but works correctly even for
the -p0 case.

This is an ancient bug, but has been masked for a long time because
most of the patches are text and have other clues to tell us the
name of the preimage and the postimage.

Noticed by Colin McCabe.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

2012-08-24 23:11:05 -07:00

..

add.c

…

annotate.c

…

apply.c

apply: compute patch->def_name correctly under -p0

2012-08-24 23:11:05 -07:00

archive.c

…

bisect--helper.c

…

blame.c

…

branch.c

Merge branch 'jn/branch-move-to-self' into maint

2011-12-28 11:32:33 -08:00

bundle.c

…

cat-file.c

…

check-attr.c

…

check-ref-format.c

…

checkout-index.c

…

checkout.c

Merge branch 'jc/checkout-m-twoway' into maint

2011-12-28 11:44:54 -08:00

clean.c

…

clone.c

clone: the -o option has nothing to do with <branch>

2011-12-21 11:26:30 -08:00

commit-tree.c

Merge branch 'jc/show-sig'

2012-01-06 12:44:07 -08:00

commit.c

Merge branch 'jc/show-sig'

2012-01-06 12:44:07 -08:00

config.c

Merge branch 'jv/maint-config-set' into maint

2011-12-28 12:03:19 -08:00

count-objects.c

…

describe.c

…

diff-files.c

…

diff-index.c

…

diff-tree.c

…

diff.c

…

fast-export.c

…

fetch-pack.c

…

fetch.c

write first for-merge ref to FETCH_HEAD first

2012-01-03 16:13:14 -08:00

fmt-merge-msg.c

…

for-each-ref.c

…

fsck.c

…

gc.c

…

grep.c

…

hash-object.c

…

help.c

…

index-pack.c

…

init-db.c

…

log.c

Sync with v1.7.8.1

2011-12-21 12:02:44 -08:00

ls-files.c

…

ls-remote.c

…

ls-tree.c

…

mailinfo.c

…

mailsplit.c

…

merge-base.c

…

merge-file.c

…

merge-index.c

…

merge-ours.c

…

merge-recursive.c

…

merge-tree.c

…

merge.c

Merge branch 'jc/show-sig'

2012-01-06 12:44:07 -08:00

mktag.c

…

mktree.c

…

mv.c

Merge branch 'jk/maint-mv' into maint

2011-12-28 11:32:36 -08:00

name-rev.c

…

notes.c

Merge branch 'nd/war-on-nul-in-commit'

2011-12-22 11:27:26 -08:00

pack-objects.c

Merge branch 'maint'

2012-01-12 23:33:39 -08:00

pack-redundant.c

…

pack-refs.c

…

patch-id.c

…

prune-packed.c

…

prune.c

…

push.c

…

read-tree.c

…

receive-pack.c

Merge branch 'mh/ref-api-less-extra-refs'

2012-01-09 15:58:43 -08:00

reflog.c

…

remote-ext.c

…

remote-fd.c

…

remote.c

…

replace.c

…

rerere.c

…

reset.c

…

rev-list.c

…

rev-parse.c

…

revert.c

Merge branch 'rr/revert-cherry-pick'

2011-12-22 15:30:22 -08:00

rm.c

…

send-pack.c

…

shortlog.c

…

show-branch.c

…

show-ref.c

…

stripspace.c

…

symbolic-ref.c

…

tag.c

…

tar-tree.c

…

unpack-file.c

…

unpack-objects.c

…

update-index.c

…

update-ref.c

…

update-server-info.c

…

upload-archive.c

…

var.c

…

verify-pack.c

…

verify-tag.c

…

write-tree.c

…