René Scharfe
ebc067f3cc
95c11ecc73(Fix error-prone fill_directory() API; make it only return matches, 2020-04-01) optimized away pathspec matching too eagerly andcada7308ad(dir: check pathspecs before returning `path_excluded`, 2020-07-20) fixed that for files and symlinks. A corner case remained unaddressed: Ignored directories that contain a nested repository. Make sure to run match_pathspec_with_flags() for it if necessary. Add a status test to check whether the pathspec is applied correctly as well as a checkout test to exercise the changed code without a pathspec. Reported-by: Sean Whitton <spwhitton@spwhitton.name> Reported-by: Lester Longley <lester@ieee.org> Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
90 lines
2.0 KiB
Bash
Executable File
90 lines
2.0 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='checkout must not overwrite an untracked objects'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
mkdir -p a/b/c &&
|
|
>a/b/c/d &&
|
|
git add -A &&
|
|
git commit -m base &&
|
|
git tag start
|
|
'
|
|
|
|
test_expect_success 'create a commit where dir a/b changed to file' '
|
|
|
|
git checkout -b file &&
|
|
rm -rf a/b &&
|
|
>a/b &&
|
|
git add -A &&
|
|
git commit -m "dir to file"
|
|
'
|
|
|
|
test_expect_success 'checkout commit with dir must not remove untracked a/b' '
|
|
|
|
git rm --cached a/b &&
|
|
git commit -m "un-track the file" &&
|
|
test_must_fail git checkout start &&
|
|
test_path_is_file a/b
|
|
'
|
|
|
|
test_expect_success 'create a commit where dir a/b changed to symlink' '
|
|
|
|
rm -rf a/b && # cleanup if previous test failed
|
|
git checkout -f -b symlink start &&
|
|
rm -rf a/b &&
|
|
git add -A &&
|
|
test_ln_s_add foo a/b &&
|
|
git commit -m "dir to symlink"
|
|
'
|
|
|
|
test_expect_success 'checkout commit with dir must not remove untracked a/b' '
|
|
|
|
git rm --cached a/b &&
|
|
git commit -m "un-track the symlink" &&
|
|
test_must_fail git checkout start
|
|
'
|
|
|
|
test_expect_success SYMLINKS 'the symlink remained' '
|
|
|
|
test_path_is_symlink a/b
|
|
'
|
|
|
|
test_expect_success 'cleanup after previous symlink tests' '
|
|
rm a/b
|
|
'
|
|
|
|
test_expect_success SYMLINKS 'checkout -f must not follow symlinks when removing entries' '
|
|
git checkout -f start &&
|
|
mkdir dir &&
|
|
>dir/f &&
|
|
git add dir/f &&
|
|
git commit -m "add dir/f" &&
|
|
mv dir untracked &&
|
|
ln -s untracked dir &&
|
|
git checkout -f HEAD~ &&
|
|
test_path_is_file untracked/f
|
|
'
|
|
|
|
test_expect_success 'checkout --overwrite-ignore should succeed if only ignored files in the way' '
|
|
git checkout -b df_conflict &&
|
|
test_commit contents some_dir &&
|
|
git checkout start &&
|
|
mkdir some_dir &&
|
|
echo autogenerated information >some_dir/ignore &&
|
|
echo ignore >.git/info/exclude &&
|
|
git checkout --overwrite-ignore df_conflict &&
|
|
test_path_is_file some_dir
|
|
'
|
|
|
|
test_expect_success 'checkout must not overwrite untracked nested repo' '
|
|
git checkout -f start &&
|
|
rm -rf some_dir &&
|
|
git init some_dir &&
|
|
test_must_fail git checkout df_conflict
|
|
'
|
|
|
|
test_done
|