dilim/git
1
0 Fork 0
mirror of https://github.com/git/git.git synced 2026-11-06 21:37:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

wincred: avoid memory corruption

Browse Source 
`wcsncpy_s()` wants to write the terminating null character so we need
to allocate one more space for it in the target memory block.

This should fix crashes when trying to read passwords.  When this
happened, the password/token wouldn't print out and Git would therefore
ask for a new password every time.

Signed-off-by: David Macek <david.macek.0@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
David Macek authored and Junio C Hamano committed 2025-11-17 14:17:42 -08:00
1 parent f368df439b
commit d22a488482
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
contrib/credential/wincred/git-credential-wincred.c
+1 -1
View File
@@ -165,7 +165,7 @@ static void get_credential(void)
write_item("username", creds[i]->UserName,
creds[i]->UserName ? wcslen(creds[i]->UserName) : 0);
if (creds[i]->CredentialBlobSize > 0) {
secret = xmalloc(creds[i]->CredentialBlobSize);
secret = xmalloc(creds[i]->CredentialBlobSize + sizeof(WCHAR));
wcsncpy_s(secret, creds[i]->CredentialBlobSize, (LPCWSTR)creds[i]->CredentialBlob, creds[i]->CredentialBlobSize / sizeof(WCHAR));
line = wcstok_s(secret, L"\r\n", &remaining_lines);
write_item("password", line, line ? wcslen(line) : 0);