From a62c2a26fcedb635046f8d072fc9d9629e6e87ba Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sun, 5 Jul 2026 08:24:20 +0000 Subject: [PATCH] download_https_uri_to_file(): do not leak fd upon failure When the `git-remote-https` command fails, we do not want to leak `child_out`. Pointed out by Coverity. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- bundle-uri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundle-uri.c b/bundle-uri.c index 3b2e347288..34fa452e76 100644 --- a/bundle-uri.c +++ b/bundle-uri.c @@ -378,7 +378,7 @@ cleanup: if (child_in) fclose(child_in); if (finish_command(&cp)) - return 1; + result = 1; if (child_out) fclose(child_out); return result;