From d5dd17756dce04fadb5f787376aabfae4d859bb4 Mon Sep 17 00:00:00 2001 From: Kenneth Lorber Date: Sun, 2 Aug 2026 20:41:03 -0400 Subject: [PATCH] t7528: fix failure under csh Explicitly set sh mode for ssh-agent (ssh-agent -s) to prevent failure when user's login shell is csh-like. The failure is caused by propagation of the $SHELL value from the user's original shell despite the test and test harness explictly using sh, which makes ssh-agent emit initialization code for the wrong shell: > cd t > echo $SHELL /bin/tcsh > ./t7528-signed-commit-ssh.sh --verbose --debug [...] expecting success of 7528.2 'sign commits using literal public keys with ssh-agent': [...] ./t7528-signed-commit-ssh.sh: 1: eval: setenv: not found ./t7528-signed-commit-ssh.sh: 1: eval: setenv: not found [...] Signed-off-by: Kenneth Lorber Acked-by: brian m. carlson Signed-off-by: Junio C Hamano --- t/t7528-signed-commit-ssh.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7528-signed-commit-ssh.sh b/t/t7528-signed-commit-ssh.sh index b50306b9b3..7bf4a40de2 100755 --- a/t/t7528-signed-commit-ssh.sh +++ b/t/t7528-signed-commit-ssh.sh @@ -82,7 +82,7 @@ test_expect_success GPGSSH 'create signed commits' ' test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agent' ' test_when_finished "test_unconfig commit.gpgsign" && test_config gpg.format ssh && - eval $(ssh-agent -T || ssh-agent) && + eval $(ssh-agent -T -s || ssh-agent -s) && test_when_finished "kill ${SSH_AGENT_PID}" && test_when_finished "test_unconfig user.signingkey" && mkdir tmpdir &&