From 3fff230cf5ee355772c618e6d0cdf2ed489ddb61 Mon Sep 17 00:00:00 2001 From: Patrick Steinhardt Date: Thu, 15 Oct 2026 08:57:17 +0200 Subject: [PATCH] ci: improve reftable test coverage The "linux-reftable" job exercises Git with reftables as its default backend. But this job is arguably redundant because we already have the "linux-reftable-leaks" job that exercises reftables with the leak sanitizer enabled, and it is unlikely that we will catch any extra bugs with the leak sanitizer disabled. One may thus be triggered to just drop the "linux-reftable" job in favor of the leak-checking variant. But the latter disables a couple of other tests that exercise git-p4, git-svn and other tools. Those tools may not be an essential part of Git nowadays, but I don't quite feel comfortable with reducing test coverage. Instead, adapt the job to run reftables together with SHA256. which is an area that we don't have test coverage for. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- .github/workflows/main.yml | 2 +- .gitlab-ci.yml | 2 +- ci/run-build-and-tests.sh | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 47f174ed0e..fe8155772a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -405,7 +405,7 @@ jobs: - jobname: linux-sha256 image: ubuntu:rolling cc: clang - - jobname: linux-reftable + - jobname: linux-reftable-sha256 image: ubuntu:rolling cc: clang - jobname: linux-feature-testbed diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7dd98cb69a..b1105b12f8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -39,7 +39,7 @@ test:linux: - jobname: linux-sha256 image: ubuntu:rolling CC: clang - - jobname: linux-reftable + - jobname: linux-reftable-sha256 image: ubuntu:rolling CC: clang - jobname: linux-feature-testbed diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index f4fe38ab5e..c8287c4576 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh @@ -40,10 +40,13 @@ linux-feature-testbed) linux-sha256) export GIT_TEST_DEFAULT_HASH=sha256 ;; -linux-reftable|linux-reftable-leaks|osx-reftable) +linux-reftable-sha256) + export GIT_TEST_DEFAULT_REF_FORMAT=reftable + export GIT_TEST_DEFAULT_HASH=sha256 + ;; +linux-reftable-leaks|osx-reftable) export GIT_TEST_DEFAULT_REF_FORMAT=reftable ;; - esac case "$jobname" in