diff --git a/config.c b/config.c index c891f63e60..5976a418d5 100644 --- a/config.c +++ b/config.c @@ -92,7 +92,7 @@ static long config_file_ftell(struct config_source *conf) static int config_buf_fgetc(struct config_source *conf) { if (conf->u.buf.pos < conf->u.buf.len) - return conf->u.buf.buf[conf->u.buf.pos++]; + return (unsigned char)conf->u.buf.buf[conf->u.buf.pos++]; return EOF; } @@ -101,7 +101,7 @@ static int config_buf_ungetc(int c, struct config_source *conf) { if (conf->u.buf.pos > 0) { conf->u.buf.pos--; - if (conf->u.buf.buf[conf->u.buf.pos] != c) + if ((unsigned char)conf->u.buf.buf[conf->u.buf.pos] != c) BUG("config_buf can only ungetc the same character"); return c; } diff --git a/t/t1307-config-blob.sh b/t/t1307-config-blob.sh index 5cb546dd00..e2c0883350 100755 --- a/t/t1307-config-blob.sh +++ b/t/t1307-config-blob.sh @@ -72,6 +72,27 @@ test_expect_success 'can parse blob ending with CR' ' test_cmp expect actual ' +test_expect_success 'a byte 0xff does not end a blob' ' + test_commit --printf FF config "# caf\\377\\n[some]\\n\\tkey = value\\n" && + echo value >expect && + git config --blob=HEAD:config some.key >actual && + test_cmp expect actual +' + +test_expect_success 'a byte 0xff after a CR in a blob' ' + test_commit --printf CRFF config "# a\\r\\377\\n[some]\\n\\tkey = value\\n" && + echo value >expect && + git config --blob=HEAD:config some.key >actual && + test_cmp expect actual +' + +test_expect_success 'can parse blob starting with a byte order mark' ' + test_commit --printf BOM config "\\357\\273\\277[some]\\n\\tkey = value\\n" && + echo value >expect && + git config --blob=HEAD:config some.key >actual && + test_cmp expect actual +' + test_expect_success 'config --blob outside of a repository is an error' ' nongit test_must_fail git config --blob=foo --list '