From 03ddaacda7ca04656dd32bfbad56121cf4108dc7 Mon Sep 17 00:00:00 2001 From: Harald Nordgren Date: Tue, 27 Oct 2026 08:32:15 +0000 Subject: [PATCH] ci: drop quarantine removal for macos perforce binaries The xattr -d call that strips com.apple.quarantine from the macOS perforce binaries has been doing nothing for years, and can simply go. 5ed9fc3fc8 (ci: prevent `perforce` from being quarantined, 2020-02-27) added that call to stop p4d -V from hanging on a GUI confirmation dialog that never comes on a CI box, back when perforce was installed via Homebrew's --no-quarantine cask flag. When 49af448197 (ci: reintroduce prevention from perforce being quarantined in macOS, 2022-05-12) replaced that with a plain wget and tar download, it kept the xattr -d call as a precaution, while noting that it already does nothing on GitHub Actions. A file downloaded with wget never gets com.apple.quarantine set in the first place, only Safari, Finder, and AirDrop apply that attribute through the LaunchServices quarantine API. The same holds on GitLab CI's macOS runners, so the call has been a silent no-op everywhere since 2022. Signed-off-by: Harald Nordgren Signed-off-by: Junio C Hamano --- ci/install-dependencies.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index d57dce5663..203e8401cf 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -122,7 +122,6 @@ macos-*) mkdir -p "$CUSTOM_PATH" wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" && tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d && - sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true rm helix-core-server.tgz case "$jobname" in