mirror of
https://github.com/containerd/containerd.git
synced 2026-11-06 13:27:16 +00:00
ayush-panta
a26143af1e
On Windows, os.RemoveAll and os.ReadFile can fail with a sharing violation when a file handle has not been fully released by the OS. Unlike Unix, Windows does not allow deleting or reading a file while any handle is open, and handles may be held briefly after Close returns. This causes a race between the gRPC server-side writer Close (which writes updatedat.tmp) and both Abort (which calls RemoveAll on the ingest directory) and status (which reads the updatedat file), surfacing as a flaky TestContentClient/CommitErrorState on Windows CI. Add platform-specific removePath and readFileWithRetry helpers that retry with incremental backoff on Windows. On non-Windows platforms they pass through to os.RemoveAll and os.ReadFile directly. This follows the same pattern as ensureRemoveAll in the CRI server helpers, which retries on EBUSY for mount races on Linux. Signed-off-by: ayush-panta <ayushkp@amazon.com>
30 lines
794 B
Go
30 lines
794 B
Go
//go:build !windows
|
|
|
|
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package local
|
|
|
|
import "os"
|
|
|
|
func removePath(path string) error {
|
|
return os.RemoveAll(path)
|
|
}
|
|
|
|
func readFileWithRetry(path string) ([]byte, error) {
|
|
return os.ReadFile(path)
|
|
}
|