mirror of
https://github.com/containerd/containerd.git
synced 2026-11-06 13:27:16 +00:00
The UpdateSandboxRequest and UpdateSandboxResponse messages have been present since the Sandbox API was introduced, but no RPC ever used them, and controllerLocal.Update was an unconditional no-op. A shim therefore had no way to learn about an update of the sandbox metadata object, a CRI pod level resource resize for example. Add the missing UpdateSandbox RPC and extend UpdateSandboxRequest with the sandbox object and the updated fieldpaths, mirroring the daemon side ControllerUpdateRequest, which is what Controller.Update carries. The pre-existing resources and annotations fields are kept but marked deprecated, containerd has no input to populate them from. controllerLocal.Update now calls the new RPC. Implementing it is optional: shims that don't support updates answer with a ttrpc Unimplemented error, which maps to errdefs.ErrNotImplemented and is already tolerated by the CRI caller in UpdatePodSandboxResources. next.txtpb additionally picks up unrelated churn, the committed descriptor set does not match what the pinned buf version produces. Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
372 lines
10 KiB
Go
372 lines
10 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package sandbox
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"time"
|
|
|
|
"github.com/containerd/errdefs"
|
|
"github.com/containerd/errdefs/pkg/errgrpc"
|
|
"github.com/containerd/log"
|
|
"github.com/containerd/plugin"
|
|
"github.com/containerd/plugin/registry"
|
|
"github.com/containerd/typeurl/v2"
|
|
imagespec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
|
|
runtimeAPI "github.com/containerd/containerd/api/runtime/sandbox/v1"
|
|
"github.com/containerd/containerd/api/types"
|
|
|
|
"github.com/containerd/containerd/v2/core/events"
|
|
"github.com/containerd/containerd/v2/core/events/exchange"
|
|
"github.com/containerd/containerd/v2/core/mount"
|
|
"github.com/containerd/containerd/v2/core/runtime"
|
|
v2 "github.com/containerd/containerd/v2/core/runtime/v2"
|
|
"github.com/containerd/containerd/v2/core/sandbox"
|
|
"github.com/containerd/containerd/v2/plugins"
|
|
)
|
|
|
|
func init() {
|
|
registry.Register(&plugin.Registration{
|
|
Type: plugins.SandboxControllerPlugin,
|
|
ID: "shim",
|
|
Requires: []plugin.Type{
|
|
plugins.ShimPlugin,
|
|
plugins.EventPlugin,
|
|
},
|
|
InitFn: func(ic *plugin.InitContext) (any, error) {
|
|
shimPlugin, err := ic.GetSingle(plugins.ShimPlugin)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
exchangePlugin, err := ic.GetByID(plugins.EventPlugin, "exchange")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var (
|
|
shims = shimPlugin.(*v2.ShimManager)
|
|
publisher = exchangePlugin.(*exchange.Exchange)
|
|
)
|
|
state := ic.Properties[plugins.PropertyStateDir]
|
|
root := ic.Properties[plugins.PropertyRootDir]
|
|
for _, d := range []string{root, state} {
|
|
if err := os.MkdirAll(d, 0700); err != nil {
|
|
return nil, err
|
|
}
|
|
// chmod is needed for upgrading from an older release that created the dir with 0o711
|
|
if err := os.Chmod(d, 0o700); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
if err := shims.LoadExistingShims(ic.Context, state, root); err != nil {
|
|
return nil, fmt.Errorf("failed to load existing shim sandboxes, %v", err)
|
|
}
|
|
|
|
c := &controllerLocal{
|
|
root: root,
|
|
state: state,
|
|
shims: shims,
|
|
publisher: publisher,
|
|
}
|
|
return c, nil
|
|
},
|
|
})
|
|
}
|
|
|
|
type controllerLocal struct {
|
|
root string
|
|
state string
|
|
shims *v2.ShimManager
|
|
publisher events.Publisher
|
|
}
|
|
|
|
var _ sandbox.Controller = (*controllerLocal)(nil)
|
|
|
|
func (c *controllerLocal) cleanupShim(ctx context.Context, sandboxID string, svc runtimeAPI.TTRPCSandboxService) {
|
|
// Let the shim exit, then we can clean up the bundle after.
|
|
if _, sErr := svc.ShutdownSandbox(ctx, &runtimeAPI.ShutdownSandboxRequest{
|
|
SandboxID: sandboxID,
|
|
}); sErr != nil {
|
|
log.G(ctx).WithError(sErr).WithField("sandboxID", sandboxID).
|
|
Error("failed to shutdown sandbox")
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
|
|
defer cancel()
|
|
|
|
dErr := c.shims.Delete(ctx, sandboxID)
|
|
if dErr != nil {
|
|
log.G(ctx).WithError(dErr).WithField("sandboxID", sandboxID).
|
|
Error("failed to delete shim")
|
|
}
|
|
}
|
|
|
|
func (c *controllerLocal) Create(ctx context.Context, info sandbox.Sandbox, opts ...sandbox.CreateOpt) (retErr error) {
|
|
var coptions sandbox.CreateOptions
|
|
sandboxID := info.ID
|
|
for _, opt := range opts {
|
|
opt(&coptions)
|
|
}
|
|
|
|
if _, err := c.shims.Get(ctx, sandboxID); err == nil {
|
|
return fmt.Errorf("sandbox %s already running: %w", sandboxID, errdefs.ErrAlreadyExists)
|
|
}
|
|
|
|
bundle, err := v2.NewBundle(ctx, c.root, c.state, sandboxID, info.Spec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
if retErr != nil {
|
|
bundle.Delete()
|
|
}
|
|
}()
|
|
|
|
shim, err := c.shims.Start(ctx, sandboxID, bundle, runtime.CreateOpts{
|
|
Spec: info.Spec,
|
|
RuntimeOptions: info.Runtime.Options,
|
|
Runtime: info.Runtime.Name,
|
|
TaskOptions: nil,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("failed to start new shim for sandbox %s: %w", sandboxID, err)
|
|
}
|
|
|
|
svc, err := sandbox.NewClient(shim.Client())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err := svc.CreateSandbox(ctx, &runtimeAPI.CreateSandboxRequest{
|
|
SandboxID: sandboxID,
|
|
BundlePath: shim.Bundle(),
|
|
Rootfs: mount.ToProto(coptions.Rootfs),
|
|
Options: typeurl.MarshalProto(coptions.Options),
|
|
NetnsPath: coptions.NetNSPath,
|
|
Annotations: coptions.Annotations,
|
|
}); err != nil {
|
|
c.cleanupShim(ctx, sandboxID, svc)
|
|
return fmt.Errorf("failed to create sandbox %s: %w", sandboxID, errgrpc.ToNative(err))
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *controllerLocal) Start(ctx context.Context, sandboxID string) (sandbox.ControllerInstance, error) {
|
|
shim, err := c.shims.Get(ctx, sandboxID)
|
|
if err != nil {
|
|
return sandbox.ControllerInstance{}, fmt.Errorf("unable to find sandbox %q", sandboxID)
|
|
}
|
|
|
|
svc, err := sandbox.NewClient(shim.Client())
|
|
if err != nil {
|
|
return sandbox.ControllerInstance{}, err
|
|
}
|
|
|
|
resp, err := svc.StartSandbox(ctx, &runtimeAPI.StartSandboxRequest{SandboxID: sandboxID})
|
|
if err != nil {
|
|
c.cleanupShim(ctx, sandboxID, svc)
|
|
return sandbox.ControllerInstance{}, fmt.Errorf("failed to start sandbox %s: %w", sandboxID, errgrpc.ToNative(err))
|
|
}
|
|
address, version := shim.Endpoint()
|
|
return sandbox.ControllerInstance{
|
|
SandboxID: sandboxID,
|
|
Pid: resp.GetPid(),
|
|
Address: address,
|
|
Version: uint32(version),
|
|
CreatedAt: resp.GetCreatedAt().AsTime(),
|
|
Spec: resp.GetSpec(),
|
|
}, nil
|
|
}
|
|
|
|
func (c *controllerLocal) Platform(ctx context.Context, sandboxID string) (imagespec.Platform, error) {
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if err != nil {
|
|
return imagespec.Platform{}, err
|
|
}
|
|
|
|
response, err := svc.Platform(ctx, &runtimeAPI.PlatformRequest{SandboxID: sandboxID})
|
|
if err != nil {
|
|
return imagespec.Platform{}, fmt.Errorf("failed to get sandbox platform: %w", errgrpc.ToNative(err))
|
|
}
|
|
|
|
var platform imagespec.Platform
|
|
if p := response.GetPlatform(); p != nil {
|
|
platform.OS = p.OS
|
|
platform.Architecture = p.Architecture
|
|
platform.Variant = p.Variant
|
|
}
|
|
return platform, nil
|
|
}
|
|
|
|
func (c *controllerLocal) Stop(ctx context.Context, sandboxID string, opts ...sandbox.StopOpt) error {
|
|
var soptions sandbox.StopOptions
|
|
for _, opt := range opts {
|
|
opt(&soptions)
|
|
}
|
|
req := &runtimeAPI.StopSandboxRequest{SandboxID: sandboxID}
|
|
if soptions.Timeout != nil {
|
|
req.TimeoutSecs = uint32(soptions.Timeout.Seconds())
|
|
}
|
|
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if errdefs.IsNotFound(err) {
|
|
return nil
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err := svc.StopSandbox(ctx, req); err != nil {
|
|
err = errgrpc.ToNative(err)
|
|
if !errdefs.IsNotFound(err) && !errdefs.IsUnavailable(err) {
|
|
return fmt.Errorf("failed to stop sandbox: %w", err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *controllerLocal) Shutdown(ctx context.Context, sandboxID string) error {
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = svc.ShutdownSandbox(ctx, &runtimeAPI.ShutdownSandboxRequest{SandboxID: sandboxID})
|
|
if err != nil {
|
|
return fmt.Errorf("failed to shutdown sandbox: %w", errgrpc.ToNative(err))
|
|
}
|
|
|
|
if err := c.shims.Delete(ctx, sandboxID); err != nil {
|
|
return fmt.Errorf("failed to delete sandbox shim: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *controllerLocal) Wait(ctx context.Context, sandboxID string) (sandbox.ExitStatus, error) {
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if err != nil {
|
|
return sandbox.ExitStatus{}, err
|
|
}
|
|
|
|
resp, err := svc.WaitSandbox(ctx, &runtimeAPI.WaitSandboxRequest{
|
|
SandboxID: sandboxID,
|
|
})
|
|
|
|
if err != nil {
|
|
return sandbox.ExitStatus{}, fmt.Errorf("failed to wait sandbox %s: %w", sandboxID, errgrpc.ToNative(err))
|
|
}
|
|
|
|
return sandbox.ExitStatus{
|
|
ExitStatus: resp.GetExitStatus(),
|
|
ExitedAt: resp.GetExitedAt().AsTime(),
|
|
}, nil
|
|
}
|
|
|
|
func (c *controllerLocal) Status(ctx context.Context, sandboxID string, verbose bool) (sandbox.ControllerStatus, error) {
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if errdefs.IsNotFound(err) {
|
|
return sandbox.ControllerStatus{
|
|
SandboxID: sandboxID,
|
|
ExitedAt: time.Now(),
|
|
}, nil
|
|
}
|
|
if err != nil {
|
|
return sandbox.ControllerStatus{}, err
|
|
}
|
|
|
|
resp, err := svc.SandboxStatus(ctx, &runtimeAPI.SandboxStatusRequest{
|
|
SandboxID: sandboxID,
|
|
Verbose: verbose,
|
|
})
|
|
if err != nil {
|
|
return sandbox.ControllerStatus{}, fmt.Errorf("failed to query sandbox %s status: %w", sandboxID, err)
|
|
}
|
|
|
|
shim, err := c.shims.Get(ctx, sandboxID)
|
|
if err != nil {
|
|
return sandbox.ControllerStatus{}, fmt.Errorf("unable to find sandbox %q", sandboxID)
|
|
}
|
|
address, version := shim.Endpoint()
|
|
|
|
return sandbox.ControllerStatus{
|
|
SandboxID: resp.GetSandboxID(),
|
|
Pid: resp.GetPid(),
|
|
State: resp.GetState(),
|
|
Info: resp.GetInfo(),
|
|
CreatedAt: resp.GetCreatedAt().AsTime(),
|
|
ExitedAt: resp.GetExitedAt().AsTime(),
|
|
Extra: resp.GetExtra(),
|
|
Address: address,
|
|
Version: uint32(version),
|
|
}, nil
|
|
}
|
|
|
|
func (c *controllerLocal) Metrics(ctx context.Context, sandboxID string) (*types.Metric, error) {
|
|
sb, err := c.getSandbox(ctx, sandboxID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
req := &runtimeAPI.SandboxMetricsRequest{SandboxID: sandboxID}
|
|
resp, err := sb.SandboxMetrics(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return resp.Metrics, nil
|
|
}
|
|
|
|
func (c *controllerLocal) Update(
|
|
ctx context.Context,
|
|
sandboxID string,
|
|
sb sandbox.Sandbox,
|
|
fields ...string) error {
|
|
svc, err := c.getSandbox(ctx, sandboxID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
req := &runtimeAPI.UpdateSandboxRequest{
|
|
SandboxID: sandboxID,
|
|
Sandbox: sandbox.ToProto(&sb),
|
|
Fields: fields,
|
|
}
|
|
|
|
// Shims are not required to implement UpdateSandbox, in which case ttrpc
|
|
// answers with an unimplemented error that callers are expected to tolerate.
|
|
if _, err := svc.UpdateSandbox(ctx, req); err != nil {
|
|
return fmt.Errorf("failed to update sandbox %s: %w", sandboxID, errgrpc.ToNative(err))
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *controllerLocal) getSandbox(ctx context.Context, id string) (runtimeAPI.TTRPCSandboxService, error) {
|
|
shim, err := c.shims.Get(ctx, id)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return sandbox.NewClient(shim.Client())
|
|
}
|