/* Copyright The containerd Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package mount import ( "fmt" "os" "os/exec" "path/filepath" "reflect" "strings" "syscall" "testing" kernel "github.com/containerd/containerd/v2/pkg/kernelversion" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "github.com/containerd/continuity/testutil" "golang.org/x/sys/unix" ) func TestLongestCommonPrefix(t *testing.T) { tcases := []struct { in []string expected string }{ {[]string{}, ""}, {[]string{"foo"}, "foo"}, {[]string{"foo", "bar"}, ""}, {[]string{"foo", "foo"}, "foo"}, {[]string{"foo", "foobar"}, "foo"}, {[]string{"foo", "", "foobar"}, ""}, } for i, tc := range tcases { if got := longestCommonPrefix(tc.in); got != tc.expected { t.Fatalf("[%d case] expected (%s), but got (%s)", i+1, tc.expected, got) } } } func TestCompactLowerdirOption(t *testing.T) { tcases := []struct { opts []string commondir string newopts []string }{ // no lowerdir or only one { []string{"workdir=a"}, "", []string{"workdir=a"}, }, { []string{"workdir=a", "lowerdir=b"}, "", []string{"workdir=a", "lowerdir=b"}, }, // >= 2 lowerdir { []string{"lowerdir=/snapshots/1/fs:/snapshots/10/fs"}, "/snapshots/", []string{"lowerdir=1/fs:10/fs"}, }, { []string{"lowerdir=/snapshots/1/fs:/snapshots/10/fs:/snapshots/2/fs"}, "/snapshots/", []string{"lowerdir=1/fs:10/fs:2/fs"}, }, // if common dir is / { []string{"lowerdir=/snapshots/1/fs:/other_snapshots/1/fs"}, "", []string{"lowerdir=/snapshots/1/fs:/other_snapshots/1/fs"}, }, // if common dir is . { []string{"lowerdir=a:aaa"}, "", []string{"lowerdir=a:aaa"}, }, } for i, tc := range tcases { dir, opts := compactLowerdirOption(tc.opts) if dir != tc.commondir { t.Fatalf("[%d case] expected common dir (%s), but got (%s)", i+1, tc.commondir, dir) } if !reflect.DeepEqual(opts, tc.newopts) { t.Fatalf("[%d case] expected options (%v), but got (%v)", i+1, tc.newopts, opts) } } } func TestFUSEHelper(t *testing.T) { testutil.RequiresRoot(t) const fuseoverlayfsBinary = "fuse-overlayfs" _, err := exec.LookPath(fuseoverlayfsBinary) if err != nil { t.Skip("fuse-overlayfs not installed") } td := t.TempDir() for _, dir := range []string{"lower1", "lower2", "upper", "work", "merged"} { if err := os.Mkdir(filepath.Join(td, dir), 0755); err != nil { t.Fatal(err) } } opts := fmt.Sprintf("lowerdir=%s:%s,upperdir=%s,workdir=%s", filepath.Join(td, "lower2"), filepath.Join(td, "lower1"), filepath.Join(td, "upper"), filepath.Join(td, "work")) m := Mount{ Type: "fuse3." + fuseoverlayfsBinary, Source: "overlay", Options: []string{opts}, } dest := filepath.Join(td, "merged") if err := m.Mount(dest); err != nil { t.Fatal(err) } if err := UnmountAll(dest, 0); err != nil { t.Fatal(err) } } func TestMountAt(t *testing.T) { testutil.RequiresRoot(t) dir1 := t.TempDir() dir2 := t.TempDir() defer unix.Unmount(filepath.Join(dir2, "bar"), unix.MNT_DETACH) if err := os.WriteFile(filepath.Join(dir1, "foo"), []byte("foo"), 0644); err != nil { t.Fatal(err) } if err := os.WriteFile(filepath.Join(dir2, "bar"), []byte{}, 0644); err != nil { t.Fatal(err) } wd, err := os.Getwd() if err != nil { t.Fatal(err) } // mount ${dir1}/foo at ${dir2}/bar // But since we are using `mountAt` we only need to specify the relative path to dir2 as the target mountAt will chdir to there. if err := mountAt(dir2, filepath.Join(dir1, "foo"), "bar", "none", unix.MS_BIND, ""); err != nil { t.Fatal(err) } b, err := os.ReadFile(filepath.Join(dir2, "bar")) if err != nil { t.Fatal(err) } if string(b) != "foo" { t.Fatalf("unexpected file content: %s", b) } newWD, err := os.Getwd() if err != nil { t.Fatal(err) } if wd != newWD { t.Fatalf("unexpected working directory: %s", newWD) } } func TestUnmountMounts(t *testing.T) { testutil.RequiresRoot(t) target, mounts := setupMounts(t) if err := UnmountMounts(mounts, target, 0); err != nil { t.Fatal(err) } } func TestUnmountRecursive(t *testing.T) { testutil.RequiresRoot(t) target, _ := setupMounts(t) if err := UnmountRecursive(target, 0); err != nil { t.Fatal(err) } } func TestDoPrepareIDMappedOverlayCleanups(t *testing.T) { testutil.RequiresRoot(t) if !supportsIDMap(t.TempDir()) { t.Skip("IDmapped mounts not supported on filesystem selected by t.TempDir()") } testCases := []struct { name string lowerDirs []string tmpDir string callbackFailure bool success bool }{ { name: "mount failure", lowerDirs: []string{"/non/existent/path"}, }, { name: "tmpdir creation failure", lowerDirs: []string{"/non/existent/path"}, tmpDir: "/non/existent/", }, { name: "cleanup callback failure", callbackFailure: true, success: true, }, { name: "all fine", success: true, }, } usernsFD, err := getUsernsFD(testUIDMaps, testGIDMaps) require.NoError(t, err) defer usernsFD.Close() for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { tmpDir := tc.tmpDir if tmpDir == "" { tmpDir = t.TempDir() } lowerDirs := tc.lowerDirs if len(lowerDirs) == 0 { // Create a temporary directory with a file to simulate lowerDirs dir := t.TempDir() require.NoError(t, os.Mkdir(dir+"/l", 0755)) require.NoError(t, os.WriteFile(dir+"/l/bar", []byte("foo"), 0644)) lowerDirs = []string{dir + "/l"} } retLowerDirs, cleanup, err := doPrepareIDMappedOverlay(tmpDir, lowerDirs, int(usernsFD.Fd())) if tc.success && err != nil { t.Fatalf("unexpected error: %v", err) } if !tc.success && err == nil { t.Fatal("expected error but got none") } if err != nil { return } if !tc.callbackFailure { cleanup() // Verify that tmpDir is empty assert.NoError(t, os.Remove(tmpDir), "expected temporary directory %s to be removed, but got error", tmpDir) } // Let's make the cleanup callback fail and make sure nothing is deleted. if tc.callbackFailure { // We won't be able to umount if there is an open fd to it. busyDh, err := os.Open(retLowerDirs[0]) assert.NoError(t, err) cleanup() defer busyDh.Close() // close even if asserts fails before we close manually below. // Verify that tmpDir is NOT empty (cleanup failed and child dirs // were not removed). assert.Error(t, os.Remove(tmpDir), "expected remove directory %v to fail, but worked fine", tmpDir) // Let's not leak mounts, let's close the handle and do the unmount. // If this fails, golang will mark the test as failed, as it can't // clean up the tmp directories. assert.NoError(t, busyDh.Close()) cleanup() } // Verify that the lowerDirs were not modified. // So we don't regress on issue #10704. for _, dir := range lowerDirs { _, err := os.Stat(dir) assert.NoError(t, err, "expected lower directory %s to exist, but it does not", dir) assert.Error(t, os.Remove(dir), "expected remove directory %s to fail, but worked fine", dir) } }) } } func TestDoPrepareIDMappedOverlay(t *testing.T) { testutil.RequiresRoot(t) k512 := kernel.KernelVersion{Kernel: 5, Major: 12} ok, err := kernel.GreaterEqualThan(k512) require.NoError(t, err) if !ok { t.Skip("GetUsernsFD requires kernel >= 5.12") } usernsFD, err := getUsernsFD(testUIDMaps, testGIDMaps) require.NoError(t, err) defer usernsFD.Close() type testCase struct { name string injectUmountFault bool } tcases := []testCase{ { name: "normal", injectUmountFault: false, }, { name: "umount-fault", injectUmountFault: true, }, } for _, tc := range tcases { t.Run(tc.name, func(t *testing.T) { fakeLowerDirsDir := t.TempDir() if !supportsIDMap(fakeLowerDirsDir) { t.Skip("IDmapped mounts not supported on filesystem selected by t.TempDir()") } lowerDirs := []string{filepath.Join(fakeLowerDirsDir, "lower1"), filepath.Join(fakeLowerDirsDir, "lower2")} for _, dir := range lowerDirs { require.NoError(t, os.Mkdir(dir, 0755)) require.NoError(t, os.WriteFile(filepath.Join(dir, filepath.Base(dir)), []byte("foo"), 0644)) } remountsLocation := t.TempDir() tmpLowerDirs, cleanup, err := doPrepareIDMappedOverlay(remountsLocation, lowerDirs, int(usernsFD.Fd())) require.NoError(t, err) require.Len(t, tmpLowerDirs, len(lowerDirs)) lowerContents := make([][]byte, len(lowerDirs)) for i, dir := range lowerDirs { correspondingRemount := tmpLowerDirs[i] filename := filepath.Base(dir) expectedFile, err := os.ReadFile(filepath.Join(dir, filename)) require.NoError(t, err, "reading comparison test fixture file") lowerContents[i] = expectedFile actualFile, err := os.ReadFile(filepath.Join(correspondingRemount, filename)) require.NoError(t, err, "reading file in temporary remount") assert.Equal(t, expectedFile, actualFile, "file content in temporary remount") } var busyDh *os.File if tc.injectUmountFault { busyDh, err = os.Open(tmpLowerDirs[0]) require.NoError(t, err) defer busyDh.Close() } cleanup() err = os.Remove(remountsLocation) if tc.injectUmountFault { // We should have failed to remove the remounts location if the unmount failed. assert.Error(t, err, "expected remove to fail (dir not empty), expected remount child locations to still exist after unmount failure") } else { assert.NoError(t, err, "expected remove to work (dir empty), the child directory should be unmounted and removed") } // Original lowerdirs should be unaffected. for i, dir := range lowerDirs { filename := filepath.Base(dir) actualFile, err := os.ReadFile(filepath.Join(dir, filename)) require.NoError(t, err, "reading file in original lowerdir") assert.Equal(t, lowerContents[i], actualFile, "file content in original lowerdir") } // If we blocked cleanup, allow it now so the test stays tidy. if tc.injectUmountFault { require.NoError(t, busyDh.Close()) cleanup() } }) } } func TestGetUnprivilegedMountFlags(t *testing.T) { testutil.RequiresRoot(t) td := t.TempDir() target := filepath.Join(td, "mnt") require.NoError(t, os.Mkdir(target, 0755)) // Mount a tmpfs with noexec,noatime,nodiratime -- these are the flags // that were previously missed due to iterating over slice indices // instead of values. require.NoError(t, unix.Mount("tmpfs", target, "tmpfs", unix.MS_NOEXEC|unix.MS_NOATIME|unix.MS_NODIRATIME, "")) defer unix.Unmount(target, unix.MNT_DETACH) flags, err := getUnprivilegedMountFlags(target) require.NoError(t, err) for _, tc := range []struct { flag int name string }{ {unix.MS_NOEXEC, "MS_NOEXEC"}, {unix.MS_NOATIME, "MS_NOATIME"}, {unix.MS_NODIRATIME, "MS_NODIRATIME"}, } { if flags&tc.flag != tc.flag { t.Errorf("expected %s (0x%x) to be set in flags 0x%x", tc.name, tc.flag, flags) } } // MS_NOSUID and MS_NODEV should NOT be set since we didn't mount with them. for _, tc := range []struct { flag int name string }{ {unix.MS_NOSUID, "MS_NOSUID"}, {unix.MS_NODEV, "MS_NODEV"}, {unix.MS_RDONLY, "MS_RDONLY"}, } { if flags&tc.flag != 0 { t.Errorf("expected %s (0x%x) to NOT be set in flags 0x%x", tc.name, tc.flag, flags) } } } func setupMounts(t *testing.T) (target string, mounts []Mount) { dir1 := t.TempDir() dir2 := t.TempDir() if err := os.Mkdir(filepath.Join(dir1, "foo"), 0755); err != nil { t.Fatal(err) } mounts = append(mounts, Mount{ Type: "bind", Source: dir1, Options: []string{ "ro", "rbind", }, }) if err := os.WriteFile(filepath.Join(dir2, "bar"), []byte("bar"), 0644); err != nil { t.Fatal(err) } mounts = append(mounts, Mount{ Type: "bind", Source: dir2, Target: "foo", Options: []string{ "ro", "rbind", }, }) target = t.TempDir() if err := All(mounts, target); err != nil { t.Fatal(err) } b, err := os.ReadFile(filepath.Join(target, "foo/bar")) if err != nil { t.Fatal(err) } if string(b) != "bar" { t.Fatalf("unexpected file content: %s", b) } return target, mounts } func supportsIDMap(path string) bool { treeFD, err := unix.OpenTree(-1, path, uint(unix.OPEN_TREE_CLONE|unix.OPEN_TREE_CLOEXEC)) if err != nil { return false } defer unix.Close(treeFD) // We want to test if idmap mounts are supported. // So we use just some random mapping, it doesn't really matter which one. // For the helper command, we just need something that is alive while we // test this, a sleep 5 will do it. cmd := exec.Command("sleep", "5") cmd.SysProcAttr = &syscall.SysProcAttr{ Cloneflags: syscall.CLONE_NEWUSER, UidMappings: []syscall.SysProcIDMap{{ContainerID: 0, HostID: 65536, Size: 65536}}, GidMappings: []syscall.SysProcIDMap{{ContainerID: 0, HostID: 65536, Size: 65536}}, } if err := cmd.Start(); err != nil { return false } defer func() { _ = cmd.Process.Kill() _ = cmd.Wait() }() usernsFD := fmt.Sprintf("/proc/%d/ns/user", cmd.Process.Pid) var usernsFile *os.File if usernsFile, err = os.Open(usernsFD); err != nil { return false } defer usernsFile.Close() attr := unix.MountAttr{ Attr_set: unix.MOUNT_ATTR_IDMAP, Userns_fd: uint64(usernsFile.Fd()), } if err := unix.MountSetattr(treeFD, "", unix.AT_EMPTY_PATH, &attr); err != nil { return false } return true } func TestBuildIDMappedPaths(t *testing.T) { testCases := []struct { name string lowerDirs []string commonDir string idMappedDir string expected []string }{ { name: "basic path rewriting", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/2/fs", }, commonDir: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots", idMappedDir: "/tmp/idmapped123", expected: []string{ "/tmp/idmapped123/1/fs", "/tmp/idmapped123/2/fs", }, }, { name: "single layer", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs", }, commonDir: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs", idMappedDir: "/tmp/idmapped789", expected: []string{ "/tmp/idmapped789", }, }, { name: "single layer with ending slash", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs/", }, commonDir: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs/", idMappedDir: "/tmp/idmapped789", expected: []string{ "/tmp/idmapped789", }, }, { name: "snapshots with common prefix in snapshot id", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/79/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/78/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/77/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/76/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/75/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/73/fs", }, commonDir: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots", idMappedDir: "/tmp/ovl-idmapped1095187461", expected: []string{ "/tmp/ovl-idmapped1095187461/79/fs", "/tmp/ovl-idmapped1095187461/78/fs", "/tmp/ovl-idmapped1095187461/77/fs", "/tmp/ovl-idmapped1095187461/76/fs", "/tmp/ovl-idmapped1095187461/75/fs", "/tmp/ovl-idmapped1095187461/73/fs", }, }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { result := buildIDMappedPaths(tc.lowerDirs, tc.commonDir, tc.idMappedDir) if len(result) != len(tc.expected) { t.Fatalf("expected %d paths, got %d", len(tc.expected), len(result)) } for i, expected := range tc.expected { if result[i] != expected { t.Errorf("path %d: expected %s, got %s", i, expected, result[i]) } } }) } } func TestGetCommonDirectory(t *testing.T) { testCases := []struct { name string lowerDirs []string expected string expectError bool errorMsg string }{ { name: "no lowerdirs", lowerDirs: []string{}, expectError: true, errorMsg: "no common prefix found", }, { name: "normal snapshots", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/37712/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/16590/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/16585/fs", }, expected: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots", }, { name: "no common prefix at all", lowerDirs: []string{ "/completely/different/path/1", "/totally/unrelated/path/2", }, expectError: true, errorMsg: "invalid common directory:", }, { name: "single dir", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/16585/fs", }, expected: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/16585", }, { name: "snapshots with common prefix in snapshot id", lowerDirs: []string{ "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/79/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/78/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/77/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/76/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/75/fs", "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/73/fs", }, expected: "/mnt/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots", }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { result, err := getCommonDirectory(tc.lowerDirs) if tc.expectError { if err == nil { t.Fatalf("expected error containing %q, got nil", tc.errorMsg) } if !strings.Contains(err.Error(), tc.errorMsg) { t.Errorf("expected error containing %q, got %q", tc.errorMsg, err.Error()) } return } if err != nil { t.Fatalf("unexpected error: %v", err) } if result != tc.expected { t.Errorf("expected %q, got %q", tc.expected, result) } }) } } func TestXContainerdOptionsFiltered(t *testing.T) { testutil.RequiresRoot(t) target := filepath.Join(t.TempDir(), "mnt") require.NoError(t, os.MkdirAll(target, 0755)) m := Mount{ Type: "tmpfs", Source: "tmpfs", Options: []string{ "size=10M", "X-containerd.custom=test-value", "mode=0755", }, } err := m.Mount(target) require.Error(t, err, "X-containerd.* options should cause an error") }