From 8fbeab28d263a3a0bbea4bbe398e449725f11015 Mon Sep 17 00:00:00 2001 From: Amit Barve Date: Wed, 29 Oct 2025 15:06:15 -0400 Subject: [PATCH] Fix incorrect default config value for block CIM snapshotter This change updates an incorrect default config value for the block CIM snapshotter. The `ntfsFormat` should always be false for the block CIM snapshotter. If the scratch needs to be formatted with NTFS, a format option named `WithNTFSFormat` can be provided. Signed-off-by: Amit Barve --- plugins/snapshots/windows/cimfs.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/snapshots/windows/cimfs.go b/plugins/snapshots/windows/cimfs.go index 436048eff..222d9d95d 100644 --- a/plugins/snapshots/windows/cimfs.go +++ b/plugins/snapshots/windows/cimfs.go @@ -83,7 +83,7 @@ func WithSize(size uint64) scratchCreationOpt { // defaultScratchCreationOptions returns the default options for scratch VHD creation func defaultScratchCreationOptions() *scratchCreationOptions { return &scratchCreationOptions{ - ntfsFormat: true, + ntfsFormat: false, sizeInBytes: defaultScratchVHDSizeInBytes, } } @@ -420,7 +420,7 @@ func createDifferencingScratchVHDs(ctx context.Context, path string) (err error) }() if !baseVHDExists { - if err = createScratchVHD(ctx, baseVHDPath); err != nil { + if err = createScratchVHD(ctx, baseVHDPath, WithNTFSFormat()); err != nil { return fmt.Errorf("failed to create base vhd: %w", err) } }