From 7b8fd44aefe0e6d03bba7ceae084c811e70ab112 Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Fri, 23 Oct 2026 13:24:50 -0700 Subject: [PATCH] ci: run the PodPID critest spec through the sandboxed shim The sandboxed shim shares a pod PID namespace now, so the critest step for it no longer skips "runtime should support PodPID". The user namespace specs still skip themselves. Signed-off-by: Maksym Pavlenko --- .github/workflows/ci.yml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 084560e669..808cf50273 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -609,14 +609,10 @@ jobs: # Experimental: the same critest suite through the pause-less sandbox # shim (containerd-shim-sandboxed-runc-v2 selected with runtime_path, - # with the shim sandboxer). Specs that need what the shim does not - # support yet are skipped by their full name; the list shrinks as the - # features land: - # - "runtime should support PodPID": a shared pod PID namespace needs - # a durable PID 1 (sandbox-init). - # The user namespace specs skip themselves: the handler does not - # advertise user namespaces until the shim supports them. - # The sandboxed shim is a Go shim: it runs on the runc.v2 legs only. + # with the shim sandboxer). The user namespace specs skip themselves: + # the handler does not advertise user namespaces until the shim + # supports them. The sandboxed shim is a Go shim: it runs on the + # runc.v2 legs only. - if: matrix.runtime == 'io.containerd.runc.v2' name: cri-tools critest (sandbox shim) env: @@ -624,7 +620,6 @@ jobs: TEST_RUNTIME_PATH: /usr/local/bin/containerd-shim-sandboxed-runc-v2 SANDBOXER: shim CGROUP_DRIVER: ${{ matrix.cgroup_driver }} - SKIP_TEST: "NamespaceOption runtime should support PodPID" run: | env sudo -E PATH=$PATH ./script/critest.sh "${{github.workspace}}/report-sandbox-shim"