mirror of
https://github.com/moby/buildkit.git
synced 2026-07-06 06:37:16 +00:00
During git refactoring, git refs accidentally became significantly broader in definition - specifically, files like "foo.bar/test.git" - is this a git repo at "foo.bar", or a local git directory? We need to restrict this a lot more, previously, we only did this clever conversion for the "github.com" prefix. This restores this previous behavior. Signed-off-by: Justin Chadwell <me@jedevc.com>
156 lines
3.2 KiB
Go
156 lines
3.2 KiB
Go
package gitutil
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestParseGitRef(t *testing.T) {
|
|
cases := []struct {
|
|
ref string
|
|
expected *GitRef
|
|
}{
|
|
{
|
|
ref: "https://example.com/",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://example.com/foo",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://example.com/foo.git",
|
|
expected: &GitRef{
|
|
Remote: "https://example.com/foo.git",
|
|
ShortName: "foo",
|
|
},
|
|
},
|
|
{
|
|
ref: "https://example.com/foo.git#deadbeef",
|
|
expected: &GitRef{
|
|
Remote: "https://example.com/foo.git",
|
|
ShortName: "foo",
|
|
Commit: "deadbeef",
|
|
},
|
|
},
|
|
{
|
|
ref: "https://example.com/foo.git#release/1.2",
|
|
expected: &GitRef{
|
|
Remote: "https://example.com/foo.git",
|
|
ShortName: "foo",
|
|
Commit: "release/1.2",
|
|
},
|
|
},
|
|
{
|
|
ref: "https://example.com/foo.git/",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://example.com/foo.git.bar",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "git://example.com/foo",
|
|
expected: &GitRef{
|
|
Remote: "git://example.com/foo",
|
|
ShortName: "foo",
|
|
UnencryptedTCP: true,
|
|
},
|
|
},
|
|
{
|
|
ref: "github.com/moby/buildkit",
|
|
expected: &GitRef{
|
|
Remote: "github.com/moby/buildkit",
|
|
ShortName: "buildkit",
|
|
IndistinguishableFromLocal: true,
|
|
},
|
|
},
|
|
{
|
|
ref: "custom.xyz/moby/buildkit.git",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://github.com/moby/buildkit",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://github.com/moby/buildkit.git",
|
|
expected: &GitRef{
|
|
Remote: "https://github.com/moby/buildkit.git",
|
|
ShortName: "buildkit",
|
|
},
|
|
},
|
|
{
|
|
ref: "https://foo:bar@github.com/moby/buildkit.git",
|
|
expected: &GitRef{
|
|
Remote: "https://foo:bar@github.com/moby/buildkit.git",
|
|
ShortName: "buildkit",
|
|
},
|
|
},
|
|
{
|
|
ref: "git@github.com:moby/buildkit",
|
|
expected: &GitRef{
|
|
Remote: "git@github.com:moby/buildkit",
|
|
ShortName: "buildkit",
|
|
},
|
|
},
|
|
{
|
|
ref: "git@github.com:moby/buildkit.git",
|
|
expected: &GitRef{
|
|
Remote: "git@github.com:moby/buildkit.git",
|
|
ShortName: "buildkit",
|
|
},
|
|
},
|
|
{
|
|
ref: "git@bitbucket.org:atlassianlabs/atlassian-docker.git",
|
|
expected: &GitRef{
|
|
Remote: "git@bitbucket.org:atlassianlabs/atlassian-docker.git",
|
|
ShortName: "atlassian-docker",
|
|
},
|
|
},
|
|
{
|
|
ref: "https://github.com/foo/bar.git#baz/qux:quux/quuz",
|
|
expected: &GitRef{
|
|
Remote: "https://github.com/foo/bar.git",
|
|
ShortName: "bar",
|
|
Commit: "baz/qux",
|
|
SubDir: "quux/quuz",
|
|
},
|
|
},
|
|
{
|
|
ref: "http://github.com/docker/docker.git:#branch",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: "https://github.com/docker/docker.git#:myfolder",
|
|
expected: &GitRef{
|
|
Remote: "https://github.com/docker/docker.git",
|
|
ShortName: "docker",
|
|
SubDir: "myfolder",
|
|
},
|
|
},
|
|
{
|
|
ref: "./.git",
|
|
expected: nil,
|
|
},
|
|
{
|
|
ref: ".git",
|
|
expected: nil,
|
|
},
|
|
}
|
|
for _, tt := range cases {
|
|
tt := tt
|
|
t.Run(tt.ref, func(t *testing.T) {
|
|
got, err := ParseGitRef(tt.ref)
|
|
if tt.expected == nil {
|
|
require.Nil(t, got)
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
require.Equal(t, tt.expected, got)
|
|
}
|
|
})
|
|
}
|
|
}
|