diff --git a/cmd/buildkitd/config/config.go b/cmd/buildkitd/config/config.go index d8da19eca..32eaa7bd6 100644 --- a/cmd/buildkitd/config/config.go +++ b/cmd/buildkitd/config/config.go @@ -142,6 +142,8 @@ type ContainerdConfig struct { MaxParallelism int `toml:"max-parallelism"` + DefaultCgroupParent string `toml:"defaultCgroupParent"` + Rootless bool `toml:"rootless"` } diff --git a/cmd/buildkitd/main_containerd_worker.go b/cmd/buildkitd/main_containerd_worker.go index ae8b2316d..5d2dcacd7 100644 --- a/cmd/buildkitd/main_containerd_worker.go +++ b/cmd/buildkitd/main_containerd_worker.go @@ -328,7 +328,7 @@ func containerdWorkerInitializer(c *cli.Context, common workerInitializerOpt) ([ Options: opts, } } - opt, err := containerd.NewWorkerOpt(common.config.Root, cfg.Address, snapshotter, cfg.Namespace, cfg.Rootless, cfg.Labels, dns, nc, common.config.Workers.Containerd.ApparmorProfile, common.config.Workers.Containerd.SELinux, parallelismSem, common.traceSocket, runtime, ctd.WithTimeout(60*time.Second)) + opt, err := containerd.NewWorkerOpt(common.config.Root, cfg.Address, snapshotter, cfg.Namespace, cfg.DefaultCgroupParent, cfg.Rootless, cfg.Labels, dns, nc, common.config.Workers.Containerd.ApparmorProfile, common.config.Workers.Containerd.SELinux, parallelismSem, common.traceSocket, runtime, ctd.WithTimeout(60*time.Second)) if err != nil { return nil, err } diff --git a/docs/buildkitd.toml.md b/docs/buildkitd.toml.md index b117bf6e5..9abe6d87f 100644 --- a/docs/buildkitd.toml.md +++ b/docs/buildkitd.toml.md @@ -104,6 +104,8 @@ insecure-entitlements = [ "network.host", "security.insecure" ] # maintain a pool of reusable CNI network namespaces to amortize the overhead # of allocating and releasing the namespaces cniPoolSize = 16 + # defaultCgroupParent sets the parent cgroup of all containers. + defaultCgroupParent = "buildkit" [worker.containerd.labels] "foo" = "bar" diff --git a/worker/containerd/containerd.go b/worker/containerd/containerd.go index 42987b727..d9629ad66 100644 --- a/worker/containerd/containerd.go +++ b/worker/containerd/containerd.go @@ -33,7 +33,7 @@ type RuntimeInfo = containerdexecutor.RuntimeInfo // NewWorkerOpt creates a WorkerOpt. func NewWorkerOpt( root string, - address, snapshotterName, ns string, + address, snapshotterName, ns, cgroupParent string, rootless bool, labels map[string]string, dns *oci.DNSConfig, @@ -62,6 +62,7 @@ func NewWorkerOpt( client, snapshotterName, ns, + cgroupParent, rootless, labels, dns, @@ -74,7 +75,7 @@ func NewWorkerOpt( ) } -func newContainerd(root string, client *containerd.Client, snapshotterName, ns string, rootless bool, labels map[string]string, dns *oci.DNSConfig, nopt netproviders.Opt, apparmorProfile string, selinux bool, parallelismSem *semaphore.Weighted, traceSocket string, runtime *RuntimeInfo) (base.WorkerOpt, error) { +func newContainerd(root string, client *containerd.Client, snapshotterName, ns, cgroupParent string, rootless bool, labels map[string]string, dns *oci.DNSConfig, nopt netproviders.Opt, apparmorProfile string, selinux bool, parallelismSem *semaphore.Weighted, traceSocket string, runtime *RuntimeInfo) (base.WorkerOpt, error) { if strings.Contains(snapshotterName, "/") { return base.WorkerOpt{}, errors.Errorf("bad snapshotter name: %q", snapshotterName) } @@ -176,7 +177,7 @@ func newContainerd(root string, client *containerd.Client, snapshotterName, ns s Labels: xlabels, MetadataStore: md, NetworkProviders: np, - Executor: containerdexecutor.New(client, root, "", np, dns, apparmorProfile, selinux, traceSocket, rootless, runtime), + Executor: containerdexecutor.New(client, root, cgroupParent, np, dns, apparmorProfile, selinux, traceSocket, rootless, runtime), Snapshotter: snap, ContentStore: cs, Applier: winlayers.NewFileSystemApplierWithWindows(cs, df), diff --git a/worker/containerd/containerd_test.go b/worker/containerd/containerd_test.go index 82e804a4f..d6bbb8dbd 100644 --- a/worker/containerd/containerd_test.go +++ b/worker/containerd/containerd_test.go @@ -31,7 +31,7 @@ func TestContainerdWorkerIntegration(t *testing.T) { func newWorkerOpt(t *testing.T, addr string) base.WorkerOpt { tmpdir := t.TempDir() rootless := false - workerOpt, err := NewWorkerOpt(tmpdir, addr, "overlayfs", "buildkit-test", rootless, nil, nil, netproviders.Opt{Mode: "host"}, "", false, nil, "", nil) + workerOpt, err := NewWorkerOpt(tmpdir, addr, "overlayfs", "buildkit-test", "", rootless, nil, nil, netproviders.Opt{Mode: "host"}, "", false, nil, "", nil) require.NoError(t, err) return workerOpt }