mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2026-11-06 13:28:17 +00:00
Kacper Michajłow
0bd69b4ba5
The denominator loop multiplied an int past INT_MAX after 3^19, step it in int64_t over the same values. Compare infinities and NaNs exactly, the relative tolerance accepted an infinity of either sign, and check INT_MIN and zero denominators. Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
218 lines
8.2 KiB
C
218 lines
8.2 KiB
C
/*
|
|
* rational numbers
|
|
* Copyright (c) 2003 Michael Niedermayer <michaelni@gmx.at>
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "libavutil/rational.c"
|
|
#include "libavutil/integer.h"
|
|
#include "libavutil/intfloat.h"
|
|
|
|
static int check_q2intfloat(AVRational q)
|
|
{
|
|
float f = av_int2float(av_q2intfloat(q));
|
|
float f2 = av_q2d(q);
|
|
int fail;
|
|
|
|
if (isnan(f) || isnan(f2))
|
|
fail = !isnan(f) || !isnan(f2);
|
|
else if (isinf(f) || isinf(f2))
|
|
fail = f != f2;
|
|
else
|
|
fail = fabs(f - f2) > fabs(f)/5000000;
|
|
if (fail)
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d %f %f\n", q.num, q.den, f, f2);
|
|
return fail;
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
AVRational a,b,r;
|
|
int i,j,k;
|
|
int ret = 0;
|
|
static const int64_t numlist[] = {
|
|
INT64_MIN, INT64_MIN+1, INT64_MAX, INT32_MIN, INT32_MAX, 1,0,-1,
|
|
123456789, INT32_MAX-1, INT32_MAX+1LL, UINT32_MAX-1, UINT32_MAX, UINT32_MAX+1LL
|
|
};
|
|
|
|
for (a.num = -2; a.num <= 2; a.num++) {
|
|
for (a.den = -2; a.den <= 2; a.den++) {
|
|
for (b.num = -2; b.num <= 2; b.num++) {
|
|
for (b.den = -2; b.den <= 2; b.den++) {
|
|
int c = av_cmp_q(a,b);
|
|
double d = av_q2d(a) == av_q2d(b) ?
|
|
0 : (av_q2d(a) - av_q2d(b));
|
|
if (d > 0) d = 1;
|
|
else if (d < 0) d = -1;
|
|
else if (d != d) d = INT_MIN;
|
|
if (c != d) {
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d %d/%d, %d %f\n", a.num,
|
|
a.den, b.num, b.den, c,d);
|
|
ret = 1;
|
|
}
|
|
r = av_sub_q(av_add_q(b,a), b);
|
|
if(b.den && (r.num*a.den != a.num*r.den || !r.num != !a.num || !r.den != !a.den)) {
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d ", r.num, r.den);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Check overflow behavior and edge cases */
|
|
static const AVRational unit_mul_q[][3] = {
|
|
{{INT_MAX, 2}, { 2, 1}, { INT_MAX, 1}},
|
|
{{INT_MAX, 2}, {-2, 1}, {-INT_MAX, 1}},
|
|
{{INT_MAX, 2}, { 0, 1}, {0, 1}},
|
|
{{INT_MIN, 2}, { 2, 1}, {-INT_MAX, 1}}, /* not INT_MIN */
|
|
{{INT_MIN, 2}, {-2, 1}, { INT_MAX, 1}},
|
|
{{INT_MIN, 2}, { 0, 1}, {0, 1}},
|
|
{{INT_MAX >> 8, 1}, {INT_MAX >> 8, 1}, {INT_MAX, 1}},
|
|
{{1, INT_MAX >> 8}, {1, INT_MAX >> 8}, {0, 1}},
|
|
{{1, 1}, {0, 0}, {0, 0}},
|
|
{{0, 1}, {0, 0}, {0, 0}},
|
|
};
|
|
|
|
for (i = 0; i < FF_ARRAY_ELEMS(unit_mul_q); i++) {
|
|
for (int c = 0; c < 2; c++) { /* test commutativity */
|
|
AVRational a = unit_mul_q[i][c ? 1 : 0];
|
|
AVRational b = unit_mul_q[i][c ? 0 : 1];
|
|
AVRational c = unit_mul_q[i][2];
|
|
AVRational r = av_mul_q(a, b);
|
|
if (r.num != c.num || r.den != c.den) {
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d * %d/%d = %d/%d, expected %d/%d\n",
|
|
a.num, a.den, b.num, b.den, r.num, r.den, c.num, c.den);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
static const AVRational unit_add_q[][3] = {
|
|
{{INT_MAX, 1}, { 2, 2}, { INT_MAX, 1}},
|
|
{{INT_MAX, 1}, {-2, 2}, { INT_MAX - 1, 1}},
|
|
{{INT_MAX, 1}, { 0, 2}, { INT_MAX, 1}},
|
|
{{INT_MIN, 1}, { 2, 2}, {-INT_MAX, 1}},
|
|
{{INT_MIN, 1}, {-2, 2}, {-INT_MAX, 1}},
|
|
{{INT_MIN, 1}, { 0, 2}, {-INT_MAX, 1}},
|
|
{{INT_MAX - 10, 1}, {20, 1}, { INT_MAX, 1}},
|
|
{{2, INT_MAX}, {2, INT_MAX}, {4, INT_MAX}},
|
|
{{1, 1}, {0, 0}, {0, 0}},
|
|
{{0, 1}, {0, 0}, {0, 0}},
|
|
};
|
|
|
|
for (i = 0; i < FF_ARRAY_ELEMS(unit_add_q); i++) {
|
|
for (int c = 0; c < 2; c++) { /* test commutativity */
|
|
AVRational a = unit_add_q[i][c ? 1 : 0];
|
|
AVRational b = unit_add_q[i][c ? 0 : 1];
|
|
AVRational c = unit_add_q[i][2];
|
|
AVRational r = av_add_q(a, b);
|
|
if (r.num != c.num || r.den != c.den) {
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d + %d/%d = %d/%d, expected %d/%d\n",
|
|
a.num, a.den, b.num, b.den, r.num, r.den, c.num, c.den);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for (i = 0; i < FF_ARRAY_ELEMS(numlist); i++) {
|
|
int64_t a = numlist[i];
|
|
|
|
for (j = 0; j < FF_ARRAY_ELEMS(numlist); j++) {
|
|
int64_t b = numlist[j];
|
|
if (b<=0)
|
|
continue;
|
|
for (k = 0; k < FF_ARRAY_ELEMS(numlist); k++) {
|
|
int64_t c = numlist[k];
|
|
int64_t res;
|
|
AVInteger ai;
|
|
|
|
if (c<=0)
|
|
continue;
|
|
res = av_rescale_rnd(a,b,c, AV_ROUND_ZERO);
|
|
|
|
ai = av_mul_i(av_int2i(a), av_int2i(b));
|
|
ai = av_div_i(ai, av_int2i(c));
|
|
|
|
if (av_cmp_i(ai, av_int2i(INT64_MAX)) > 0 && res == INT64_MIN)
|
|
continue;
|
|
if (av_cmp_i(ai, av_int2i(INT64_MIN)) < 0 && res == INT64_MIN)
|
|
continue;
|
|
if (av_cmp_i(ai, av_int2i(res)) == 0)
|
|
continue;
|
|
|
|
// Special exception for INT64_MIN, remove this in case INT64_MIN is handled without off by 1 error
|
|
if (av_cmp_i(ai, av_int2i(res-1)) == 0 && a == INT64_MIN)
|
|
continue;
|
|
|
|
av_log(NULL, AV_LOG_ERROR, "%"PRId64" * %"PRId64" / %"PRId64" = %"PRId64" or %"PRId64"\n", a,b,c, res, av_i2int(ai));
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for (a.num = 1; a.num <= 10; a.num++) {
|
|
for (a.den = 1; a.den <= 10; a.den++) {
|
|
if (av_gcd(a.num, a.den) > 1)
|
|
continue;
|
|
for (b.num = 1; b.num <= 10; b.num++) {
|
|
for (b.den = 1; b.den <= 10; b.den++) {
|
|
int start;
|
|
if (av_gcd(b.num, b.den) > 1)
|
|
continue;
|
|
if (av_cmp_q(b, a) < 0)
|
|
continue;
|
|
for (start = 0; start < 10 ; start++) {
|
|
int acc= start;
|
|
int i;
|
|
|
|
for (i = 0; i<100; i++) {
|
|
int exact = start + av_rescale_q(i+1, b, a);
|
|
acc = av_add_stable(a, acc, b, 1);
|
|
if (FFABS(acc - exact) > 2) {
|
|
av_log(NULL, AV_LOG_ERROR, "%d/%d %d/%d, %d %d\n", a.num,
|
|
a.den, b.num, b.den, acc, exact);
|
|
return 1;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
for (int64_t den = 1; den <= INT_MAX; den *= 3) {
|
|
a.den = den;
|
|
for (a.num = -1; a.num < (1<<27); a.num += 1 + a.num/100) {
|
|
if (check_q2intfloat(a))
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
static const AVRational q2intfloat_list[] = {
|
|
{INT_MIN, 1}, {1, INT_MIN}, {INT_MIN, INT_MIN}, {INT_MIN, -1}, {-1, INT_MIN},
|
|
{INT_MAX, INT_MIN}, {INT_MIN, INT_MAX}, {-3, -7}, {3, -7},
|
|
{1, 0}, {-1, 0}, {INT_MIN, 0}, {0, 0}, {0, 1}, {0, INT_MIN},
|
|
};
|
|
|
|
for (i = 0; i < FF_ARRAY_ELEMS(q2intfloat_list); i++)
|
|
ret |= check_q2intfloat(q2intfloat_list[i]);
|
|
|
|
return ret;
|
|
}
|