From 45ec2cae195ec43662cbdb6899caee99a6d657fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Tue, 8 Sep 2026 09:46:02 +0200 Subject: [PATCH] configure: drop -Werror from the C++ warning probe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 0ce413af9c gave check_disable_warning() a C++ checks at a time when unknown_warning_flags was a single set probed with test_cflags, so it said nothing about what the C++ compiler accepts. The -Werror was added as a glue that reject C only flags from C++ compilation and probe time. However, after 005510501e made those flags per language and unknown_warning_cxxflags is now probed with test_cxxflags, so the Werror is no longer relevant. This is not only cosmetic change, because -Werror itself is not valid flag for MSVC, all tests were failing there. Signed-off-by: Kacper Michajłow --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8f3c7ded34..beb5e1460f 100755 --- a/configure +++ b/configure @@ -7791,7 +7791,7 @@ check_warning(){ warning_flag=$1 flag_to_add=${2:-$1} test_cflags $unknown_warning_cflags $warning_flag && add_cflags $flag_to_add - test_cxxflags -Werror $unknown_warning_cxxflags $warning_flag && add_cxxflags $flag_to_add + test_cxxflags $unknown_warning_cxxflags $warning_flag && add_cxxflags $flag_to_add } check_disable_warning(){