mirror of
https://github.com/Kitware/CMake.git
synced 2026-08-11 01:24:12 +00:00
a121419908
Currently, getting properties from an ALIAS target retrieves the property from the target which the alias references while setting properties results in an error. This relaxes set_property and set_target_properties to accept ALIAS targets and act on the referenced target, mirroring the get behavior. An error is raised when setting ALIAS_GLOBAL or ALIASED_TARGET on an ALIAS target. Closes: #19445
64 lines
2.1 KiB
C++
64 lines
2.1 KiB
C++
/* Distributed under the OSI-approved BSD 3-Clause License. See accompanying
|
|
file LICENSE.rst or https://cmake.org/licensing for details. */
|
|
#include "cmSetTargetPropertiesCommand.h"
|
|
|
|
#include <algorithm>
|
|
#include <iterator>
|
|
|
|
#include "cmExecutionStatus.h"
|
|
#include "cmMakefile.h"
|
|
#include "cmStringAlgorithms.h"
|
|
#include "cmTarget.h"
|
|
|
|
bool cmSetTargetPropertiesCommand(std::vector<std::string> const& args,
|
|
cmExecutionStatus& status)
|
|
{
|
|
if (args.size() < 2) {
|
|
status.SetError("called with incorrect number of arguments");
|
|
return false;
|
|
}
|
|
|
|
// first identify the properties arguments
|
|
auto propsIter = std::find(args.begin(), args.end(), "PROPERTIES");
|
|
if (propsIter == args.end() || propsIter + 1 == args.end()) {
|
|
status.SetError("called with illegal arguments, maybe missing a "
|
|
"PROPERTIES specifier?");
|
|
return false;
|
|
}
|
|
|
|
if (std::distance(propsIter, args.end()) % 2 != 1) {
|
|
status.SetError("called with incorrect number of arguments.");
|
|
return false;
|
|
}
|
|
|
|
cmMakefile& mf = status.GetMakefile();
|
|
|
|
// loop over all the targets
|
|
for (std::string const& tname : cmStringRange{ args.begin(), propsIter }) {
|
|
if (cmTarget* target = mf.FindTargetToUse(tname)) {
|
|
if (target->IsSymbolic()) {
|
|
status.SetError("can not be used on a SYMBOLIC target.");
|
|
return false;
|
|
}
|
|
// loop through all the props and set them
|
|
for (auto k = propsIter + 1; k != args.end(); k += 2) {
|
|
// Better error message for alias properties set on an alias target.
|
|
if (*k == "ALIASED_TARGET" || *k == "ALIAS_GLOBAL") {
|
|
if (mf.IsAlias(tname)) {
|
|
status.SetError(cmStrCat("can not set property ", *k,
|
|
" on an ALIAS target: ", tname));
|
|
return false;
|
|
}
|
|
}
|
|
target->SetProperty(*k, *(k + 1));
|
|
target->CheckProperty(*k, &mf);
|
|
}
|
|
} else {
|
|
status.SetError(
|
|
cmStrCat("Can not find target to add properties to: ", tname));
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|