dilim/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-08-05 15:20:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Help/dev: mention how the robot performs its checks

Browse Source 
Fixes: #16264.
This commit is contained in:
Ben Boeckel
2017-03-21 13:07:42 -04:00
parent 48dc2d122d
commit 7d22203912
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Help/dev/review.rst
View File

@@ -65,9 +65,14 @@ The "Kitware Robot" (``@kwrobot``) automatically performs basic checks on
the commits proposed in a MR. If all is well the robot silently reports the commits proposed in a MR. If all is well the robot silently reports
a successful "build" status to GitLab. Otherwise the robot posts a comment a successful "build" status to GitLab. Otherwise the robot posts a comment
with its diagnostics. **A topic may not be merged until the automatic with its diagnostics. **A topic may not be merged until the automatic
review succeeds.** The MR submitter is expected to address the robot's review succeeds.**
comments by *rewriting* the commits named by the robot's diagnostics
(e.g. via ``git rebase -i``). Note that the MR submitter is expected to address the robot's comments by
*rewriting* the commits named by the robot's diagnostics (e.g., via
``git rebase -i``). This is because the robot checks each commit individually,
not the topic as a whole. This is done in order to ensure that commits in the
middle of a topic do not, for example, add a giant file which is then later
removed in the topic.
The automatic check is repeated whenever the topic branch is updated. The automatic check is repeated whenever the topic branch is updated.
One may explicitly request a re-check by adding a comment with the One may explicitly request a re-check by adding a comment with the