dilim/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-06-24 08:47:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

pvs-studio: (V555) Clarify size_type comparison

Browse Source 
The expression 'r - l > 0' implies a sign to r and l that does not exist.
This commit is contained in:
Martin Duffy
2026-05-05 01:42:38 -04:00
parent 88072f17fe
commit 7217af55da
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.pvsconfig
View File

@@ -14,8 +14,6 @@
//-V::539
# Expression is always true/false.
//-V::547
# Expression of the 'A - B > 0' kind will work as 'A != B'.
//-V::555
# Possible array overrun.
//-V::557
# Part of conditional expression is always true/false.

2
Source/cmStringReplaceHelper.cxx
View File

@@ -93,7 +93,7 @@ void cmStringReplaceHelper::ParseReplaceExpression()
this->Replacements.emplace_back(
this->ReplaceExpression.substr(l, r - l));
} else {
if (r - l > 0) {
if (r != l) {
this->Replacements.emplace_back(
this->ReplaceExpression.substr(l, r - l));
}