Ninja: Revert "Optimize target depends closure" due to performance regression

Revert commit 1f16af01f4 (cmGlobalNinjaGenerator: Optimize target
depends closure, 2023-01-17, v3.26.0-rc1~74^2).  It regressed generation
time for some projects.  Revert it pending further investigation.

Source/cmGlobalNinjaGenerator.cxx

@@ -8,7 +8,6 @@
 #include <cstdio>
 #include <functional>
 #include <sstream>
-#include <tuple>
 #include <utility>
 
 #include <cm/iterator>
@@ -585,7 +584,7 @@ void cmGlobalNinjaGenerator::Generate()
   }
 
   for (auto& it : this->Configs) {
-    it.second.TargetDependsClosureLocalOutputs.clear();
+    it.second.TargetDependsClosures.clear();
   }
 
   this->InitOutputPathPrefix();
@@ -1366,85 +1365,70 @@ void cmGlobalNinjaGenerator::AppendTargetDependsClosure(
   cmGeneratorTarget const* target, cmNinjaDeps& outputs,
   const std::string& config, const std::string& fileConfig, bool genexOutput)
 {
-  struct Entry
+  cmNinjaOuts outs;
-  {
+  this->AppendTargetDependsClosure(target, outs, config, fileConfig,
-    Entry(cmGeneratorTarget const* target_, std::string config_,
+                                   genexOutput, true);
-          std::string fileConfig_)
+  cm::append(outputs, outs);
-      : target(target_)
+}
-      , config(std::move(config_))
-      , fileConfig(std::move(fileConfig_))
-    {
-    }
 
-    bool operator<(Entry const& other) const
+void cmGlobalNinjaGenerator::AppendTargetDependsClosure(
-    {
+  cmGeneratorTarget const* target, cmNinjaOuts& outputs,
-      return std::tie(target, config, fileConfig) <
+  const std::string& config, const std::string& fileConfig, bool genexOutput,
-        std::tie(other.target, other.config, other.fileConfig);
+  bool omit_self)
-    }
+{
 
-    cmGeneratorTarget const* target;
+  // try to locate the target in the cache
-    std::string config;
+  ByConfig::TargetDependsClosureKey key{
-    std::string fileConfig;
+    target,
+    config,
+    genexOutput,
   };
+  auto find = this->Configs[fileConfig].TargetDependsClosures.lower_bound(key);
 
-  cmNinjaOuts outputSet;
+  if (find == this->Configs[fileConfig].TargetDependsClosures.end() ||
-  std::vector<Entry> stack;
+      find->first != key) {
-  stack.emplace_back(target, config, fileConfig);
+    // We now calculate the closure outputs by inspecting the dependent
-  std::set<Entry> seen = { stack.back() };
+    // targets recursively.
+    // For that we have to distinguish between a local result set that is only
+    // relevant for filling the cache entries properly isolated and a global
+    // result set that is relevant for the result of the top level call to
+    // AppendTargetDependsClosure.
+    cmNinjaOuts this_outs; // this will be the new cache entry
 
-  do {
+    for (auto const& dep_target : this->GetTargetDirectDepends(target)) {
-    Entry entry = std::move(stack.back());
-    stack.pop_back();
-
-    // generate the outputs of the target itself, if applicable
-    if (entry.target != target) {
-      // try to locate the target in the cache
-      ByConfig::TargetDependsClosureKey localCacheKey{
-        entry.target,
-        entry.config,
-        genexOutput,
-      };
-      auto& configs = this->Configs[entry.fileConfig];
-      auto lb =
-        configs.TargetDependsClosureLocalOutputs.lower_bound(localCacheKey);
-
-      if (lb == configs.TargetDependsClosureLocalOutputs.end() ||
-          lb->first != localCacheKey) {
-        cmNinjaDeps outs;
-        this->AppendTargetOutputs(entry.target, outs, entry.config,
-                                  DependOnTargetArtifact);
-        configs.TargetDependsClosureLocalOutputs.emplace_hint(
-          lb, localCacheKey, outs);
-        for (auto& value : outs) {
-          outputSet.emplace(std::move(value));
-        }
-      } else {
-        outputSet.insert(lb->second.begin(), lb->second.end());
-      }
-    }
-
-    // push next dependencies
-    for (const auto& dep_target : this->GetTargetDirectDepends(entry.target)) {
       if (!dep_target->IsInBuildSystem()) {
         continue;
       }
 
-      if (!this->IsSingleConfigUtility(entry.target) &&
+      if (!this->IsSingleConfigUtility(target) &&
           !this->IsSingleConfigUtility(dep_target) &&
           this->EnableCrossConfigBuild() && !dep_target.IsCross() &&
           !genexOutput) {
         continue;
       }
 
-      auto emplaceRes = seen.emplace(
+      if (dep_target.IsCross()) {
-        dep_target, dep_target.IsCross() ? entry.fileConfig : entry.config,
+        this->AppendTargetDependsClosure(dep_target, this_outs, fileConfig,
-        entry.fileConfig);
+                                         fileConfig, genexOutput, false);
-      if (emplaceRes.second) {
+      } else {
-        stack.emplace_back(*emplaceRes.first);
+        this->AppendTargetDependsClosure(dep_target, this_outs, config,
+                                         fileConfig, genexOutput, false);
       }
     }
-  } while (!stack.empty());
+    find = this->Configs[fileConfig].TargetDependsClosures.emplace_hint(
-  cm::append(outputs, outputSet);
+      find, key, std::move(this_outs));
+  }
+
+  // now fill the outputs of the final result from the newly generated cache
+  // entry
+  outputs.insert(find->second.begin(), find->second.end());
+
+  // finally generate the outputs of the target itself, if applicable
+  cmNinjaDeps outs;
+  if (!omit_self) {
+    this->AppendTargetOutputs(target, outs, config, DependOnTargetArtifact);
+  }
+  outputs.insert(outs.begin(), outs.end());
 }
 
 void cmGlobalNinjaGenerator::AddTargetAlias(const std::string& alias,

Source/cmGlobalNinjaGenerator.h

@@ -354,6 +354,11 @@ public:
                                   const std::string& config,
                                   const std::string& fileConfig,
                                   bool genexOutput);
+  void AppendTargetDependsClosure(cmGeneratorTarget const* target,
+                                  cmNinjaOuts& outputs,
+                                  const std::string& config,
+                                  const std::string& fileConfig,
+                                  bool genexOutput, bool omit_self);
 
   void AppendDirectoryForConfig(const std::string& prefix,
                                 const std::string& config,
@@ -612,8 +617,7 @@ private:
       bool GenexOutput;
     };
 
-    std::map<TargetDependsClosureKey, cmNinjaDeps>
+    std::map<TargetDependsClosureKey, cmNinjaOuts> TargetDependsClosures;
-      TargetDependsClosureLocalOutputs;
 
     TargetAliasMap TargetAliases;