dilim/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-06-24 08:47:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmStateSnapshot: CanPop* should be const

Browse Source 
Checking if the policy/diagnostic stack is non-empty doesn't require a
mutable state snapshot. Mark the relevant methods `const`.
This commit is contained in:
Matthew Woehlke
2026-03-04 11:28:18 -05:00
parent a0612aeb5d
commit 2b7ee7137b
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/cmStateSnapshot.cxx
View File

@@ -169,7 +169,7 @@ bool cmStateSnapshot::PopPolicy()
return true;
}
bool cmStateSnapshot::CanPopPolicyScope()
bool cmStateSnapshot::CanPopPolicyScope() const
{
return this->Position->Policies != this->Position->PolicyScope;
}
@@ -243,7 +243,7 @@ bool cmStateSnapshot::PopDiagnostic()
return true;
}
bool cmStateSnapshot::CanPopDiagnosticScope()
bool cmStateSnapshot::CanPopDiagnosticScope() const
{
return this->Position->Diagnostics != this->Position->DiagnosticScope;
}

4
Source/cmStateSnapshot.h
View File

@@ -56,7 +56,7 @@ public:
bool parent_scope = false) const;
void PushPolicy(cmPolicies::PolicyMap const& entry, bool weak);
bool PopPolicy();
bool CanPopPolicyScope();
bool CanPopPolicyScope() const;
void SetDiagnostic(cmDiagnostics::DiagnosticCategory category,
cmDiagnostics::DiagnosticAction action, bool recursive);
@@ -77,7 +77,7 @@ public:
}
void PushDiagnostic(cmDiagnostics::DiagnosticMap entry, bool weak);
bool PopDiagnostic();
bool CanPopDiagnosticScope();
bool CanPopDiagnosticScope() const;
cmState* GetState() const;